Skip to content

[CodeStyle] remove compat module (long_type, int_type, get_exception_message, floor_division) - #46686

Merged
luotao1 merged 10 commits into
PaddlePaddle:developfrom
cattidea:py2/fix/compat
Oct 11, 2022
Merged

luotao1 merged 10 commits into
PaddlePaddle:developfrom
cattidea:py2/fix/compat

Conversation

@SigureMo

@SigureMo SigureMo commented Sep 30, 2022 •

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Describe

清理 compat 模块的尝试

  • long_type
  • int_type
  • get_exception_message
  • floor_division

  • round(有点麻烦,之后再说)
  • to_bytes
  • to_text

剩下的其余 PR 再清除

@paddle-bot

paddle-bot Bot commented Sep 30, 2022

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added contributor External developers status: proposed labels Sep 30, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle] remove compat module [WIP][CodeStyle] remove compat module (long_type, int_type, get_exception_message, floor_division) Oct 1, 2022
@SigureMo SigureMo changed the title [WIP][CodeStyle] remove compat module (long_type, int_type, get_exception_message, floor_division) [CodeStyle] remove compat module (long_type, int_type, get_exception_message, floor_division) Oct 1, 2022
executable_path = os.path.abspath(os.path.dirname(sys.executable))
raise ImportError(
"""NOTE: You may need to run \"set PATH=%s;%%PATH%%\"
raise ImportError("""NOTE: You may need to run \"set PATH=%s;%%PATH%%\"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试覆盖率没过,不过与本 PR 无关

image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已豁免

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants