Skip to content

fix(scoring): require solved-by-PR evidence for linked issues - #506

Merged
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-validation-bypass-issue
Jun 10, 2026
Merged

fix(scoring): require solved-by-PR evidence for linked issues#506
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-validation-bypass-issue

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Prevent caller-supplied linkedIssueContext.status = "validated" from granting the standard linked-issue multiplier without concrete solved-by-PR evidence, which allowed forged private preview records to inflate scores.

Description

  • Change scoring logic in src/scoring/preview.ts so a requested status: "validated" is downgraded to raw/unavailable unless solvedByPullRequests (or an internal projection marker) provides solved-by-PR evidence and branch eligibility also passes.
  • Add an internal-only projectedSolvedByPullRequestValidation flag to LinkedIssueMultiplierContext and the projection helper withValidatedLinkedIssueScenario so scenario projections can model future solved-by-PR validation without trusting API input.
  • Update unit tests in test/unit/scoring.test.ts to assert that forged validated contexts without solver PR evidence remain ineligible and receive no multiplier, and adjust test/unit/eligibility-scenarios.test.ts fixtures to include concrete solved-by-PR evidence for genuinely validated cases.

Testing

  • Ran the targeted unit test with npx vitest run test/unit/scoring.test.ts -t "requires solved-by-PR validation" --reporter verbose and it passed.
  • Ran the two test suites with npx vitest run test/unit/scoring.test.ts test/unit/eligibility-scenarios.test.ts --reporter verbose and all tests passed.
  • Performed type checking with npm run typecheck and ran git diff --check with no issues reported.

Codex Task

@dosubot dosubot Bot added the size:S label Jun 9, 2026
@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 9, 2026
@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #506 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 9865211 Commit Preview URL

Branch Preview URL
Jun 10 2026, 08:03 AM

@superagent-security superagent-security Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superagent found 1 security concern(s).

@superagent-security superagent-security Bot added the pr:flagged PR flagged for review by security analysis. label Jun 9, 2026
@JSONbored JSONbored self-assigned this Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/propose-fix-for-validation-bypass-issue branch 2 times, most recently from ec6e662 to 1c64477 Compare June 10, 2026 07:56
@JSONbored
JSONbored force-pushed the codex/propose-fix-for-validation-bypass-issue branch from 1c64477 to 9865211 Compare June 10, 2026 08:02
@dosubot dosubot Bot added size:M and removed size:S labels Jun 10, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@superagent-security superagent-security Bot removed the pr:flagged PR flagged for review by security analysis. label Jun 10, 2026
@JSONbored
JSONbored merged commit 6724337 into main Jun 10, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/propose-fix-for-validation-bypass-issue branch June 10, 2026 08:04
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
@JSONbored JSONbored added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jun 10, 2026
@github-actions github-actions Bot mentioned this pull request Jun 10, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant