fix(analytics): redact MCP client telemetry buckets - #505
Merged
JSONbored merged 1 commit intoJun 10, 2026
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 90a9846 | Commit Preview URL Branch Preview URL |
Jun 10 2026, 07:48 AM |
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/propose-fix-for-mcp-telemetry-vulnerability
branch
from
June 10, 2026 07:40
79d7ce0 to
870af70
Compare
JSONbored
force-pushed
the
codex/propose-fix-for-mcp-telemetry-vulnerability
branch
from
June 10, 2026 07:47
870af70 to
90a9846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
x-gittensory-mcp-client-versioncontaining build metadata (e.g.0.3.0+alice) to be stored and returned in aggregatebyClientVersionanalytics without actor redaction.clientVersion, permitting per-actor identifiers to appear in supposedly aggregate-only operator analytics.Description
clientNameandclientVersionwith the existing actor redaction pipeline before persisting events by applyingredactProductUsageActorinrecordProductUsageEvent(src/db/repositories.ts).aggregateMcpClientVersionwhich strips build metadata (+...) and returns the semver core/prerelease portion formcpClientVersionForEvent(src/db/repositories.ts).test/unit/product-usage.test.tsand extendingtest/unit/product-usage-mcp-adoption.test.ts.Testing
npx vitest run test/unit/product-usage.test.ts test/unit/product-usage-mcp-adoption.test.tsand all tests passed.npm run typecheck(tsc --noEmit) and the typecheck succeeded.Codex Task