Skip to content

fix(sync): isolate unauthenticated fallback rate limits - #499

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-unauthenticated-fallback-causing-sync-stalls
Jun 10, 2026
Merged

fix(sync): isolate unauthenticated fallback rate limits#499
JSONbored merged 1 commit into
mainfrom
codex/fix-unauthenticated-fallback-causing-sync-stalls

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • A scoped GITHUB_PUBLIC_TOKEN 404 retry triggers an unauthenticated REST fallback whose rate-limit headers (unauthenticated 60-request bucket) were being recorded into the shared REST observation table, which can cause later token-backed segments to wait erroneously.

Description

  • Stop persisting unauthenticated fallback responses in githubJsonWithHeaders so fallback fetches still return data but their x-ratelimit-* headers are not recorded into the shared REST backoff state (src/github/backfill.ts).
  • Add a regression test keeps successful unauthenticated fallback responses out of the shared REST backoff that simulates a public-token 404 followed by a successful unauthenticated response with unauthenticated rate-limit headers and then asserts a later token-backed segment proceeds (test/unit/backfill.test.ts).
  • Changed files: src/github/backfill.ts and test/unit/backfill.test.ts.
  • Preserves existing functionality of performing the unauthenticated retry while preventing shared limiter poisoning.

Testing

  • Ran npm run typecheck (tsc --noEmit) which completed successfully.
  • Ran the unit tests with npm run test:unit -- test/unit/backfill.test.ts and observed all unit tests pass (Test Files 93 passed, Tests 1344 passed).

Codex Task

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui b60f494 Commit Preview URL

Branch Preview URL
Jun 10 2026, 07:08 AM

@dosubot dosubot Bot added the size:XS label Jun 9, 2026
@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #499 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 9, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/fix-unauthenticated-fallback-causing-sync-stalls branch from 016b581 to 0e6cf41 Compare June 10, 2026 07:05
@JSONbored
JSONbored force-pushed the codex/fix-unauthenticated-fallback-causing-sync-stalls branch from 0e6cf41 to b60f494 Compare June 10, 2026 07:07
@JSONbored
JSONbored merged commit 785bc8b into main Jun 10, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/fix-unauthenticated-fallback-causing-sync-stalls branch June 10, 2026 07:10
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
@JSONbored JSONbored added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant