Skip to content

fix(signals): account for queue burden in readiness score - #501

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-quality-gate-undercounting-issue
Jun 10, 2026
Merged

fix(signals): account for queue burden in readiness score#501
JSONbored merged 1 commit into
mainfrom
codex/fix-quality-gate-undercounting-issue

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • The queue-pressure component previously scored purely from signals.openPullRequests, which could produce a perfect queue score for small open-PR counts even when QueueHealth.burdenScore/level indicated critical burden from stale/unlinked/collision signals, allowing a readiness total to bypass a configured blocking quality Gate.

Description

  • Change queuePressureScore to accept QueueHealth and use the more conservative score between open-PR pressure and QueueHealth.level, while preserving 10/10 for genuine zero open-PR evidence by short-circuiting on openPullRequests === 0 in queuePressureScore.
  • Introduce queuePressureOpenPullRequestScore and queuePressureLevelScore helper functions and wire them into queuePressureComponent so level-derived burden cannot be ignored.
  • Add a regression test in test/unit/signals-coverage.test.ts that constructs a small (4 PR) queue with stale/unlinked items and asserts the queue component scores low and reports the expected evidence.

Testing

  • Ran the focused test: npm test -- test/unit/signals-coverage.test.ts, which passed after the changes.
  • Ran type checking: npm run typecheck, which passed with no errors.
  • Ran the full test suite: npm test, with all tests passing (1388 passed | 1 skipped).
  • Ran git diff --check and code formatting/type checks with no issues reported.

Codex Task

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 04eb8ee Commit Preview URL

Branch Preview URL
Jun 10 2026, 07:16 AM

@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 9, 2026
@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #501 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/fix-quality-gate-undercounting-issue branch from e43dacf to 4db067c Compare June 10, 2026 07:13
@dosubot dosubot Bot added the size:S label Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/fix-quality-gate-undercounting-issue branch from 4db067c to 04eb8ee Compare June 10, 2026 07:15
@ghost ghost mentioned this pull request Jun 10, 2026
@JSONbored
JSONbored merged commit 2f76612 into main Jun 10, 2026
10 checks passed
@JSONbored
JSONbored deleted the codex/fix-quality-gate-undercounting-issue branch June 10, 2026 07:18
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
@JSONbored JSONbored added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jun 10, 2026
JSONbored pushed a commit that referenced this pull request Jul 17, 2026
…actor (#6769)

self-review-context.js's LINKED_PR_PATTERN was a bare /PR|pull request #N/ with
no closing-keyword requirement, despite claiming to mirror the host's
extractLinkedPrNumbers exactly. The host requires close/fix/resolve precisely to
avoid counting an incidental mention (its own #issue-body-pr-mention-pollution
fix); the miner's copy never got it. So a body saying "similar to what we saw in
PR #501" populated linkedPrs, the issue-quality report read the issue as
"already references a PR", and the miner skipped an available issue. Mirror the
host pattern and correct the comment.

Closes #6769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant