Skip to content

fix(commands): redact private score projection deltas #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jun 10, 2026
Merged

fix(commands): redact private score projection deltas #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/github/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,8 +1337,9 @@ function sanitizeFeedbackAnswerId(answerId: string): string {

export function sanitizePublicComment(value: string): string {
const sanitized = value
.replace(/\bprojected score changes?\b(?:\s+from)?\s+[-+]?\d+(?:\.\d+)?\s*(?:->|→|to)\s*[-+]?\d+(?:\.\d+)?/gi, "private context")
.replace(/\b(raw trust score|trust score|wallet|hotkey|coldkey|seed phrase|mnemonic)\b/gi, "private context")
.replace(/\b(public score estimate|estimated score|score estimate|reward estimates?|payout|farming|scoreability|score preview)\b/gi, "private context")
.replace(/\b(public score estimate|estimated score|score estimate|reward estimates?|payout|farming|scoreability|score preview|projected score changes?)\b/gi, "private context")
.replace(/\b(private reviewability|reviewability internals?)\b/gi, "private context")
.replace(/\b(private ranking|private rankings)\b/gi, "private context")
.replace(/\blikely_duplicate\b/gi, "possible overlap with existing work");
Expand Down
32 changes: 32 additions & 0 deletions test/unit/github-commands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,42 @@ describe("GitHub mention commands", () => {
);
expect(sanitizePublicComment("public score estimate and scoreability should stay private")).not.toMatch(/public score estimate|scoreability/i);
expect(sanitizePublicComment("public score estimate private scoreability context score preview")).not.toMatch(/public score estimate|scoreability|score preview/i);
expect(sanitizePublicComment("projected score changes 12.3 -> 45.6")).not.toMatch(/projected score changes|12\.3|45\.6/i);
expect(sanitizePublicComment("Command: @gittensory reviewability")).toContain("@gittensory reviewability");
expect(sanitizePublicComment("private ranking, wallet, payout")).toBe("private context");
});

it("redacts private score projection deltas from public command rerun guidance", () => {
const baseBundle = sampleBundle();
const bundle = {
...baseBundle,
actions: [
{
...baseBundle.actions[0]!,
actionType: "prepare_pr_packet" as const,
publicSafeSummary: "Prepare public PR packet after validation completes.",
rerunWhen:
"Rerun after pending PRs merge/close or after open PR count is at or below 3; projected score changes 12.3 -> 45.6.",
},
],
};

for (const mention of ["@gittensory preflight", "@gittensory reviewability", "@gittensory packet"]) {
const body = buildPublicAgentCommandComment({
command: parseGittensoryMentionCommand(mention)!,
repo: { fullName: "owner/repo" } as any,
issue: { number: 12, title: "PR", state: "open", pull_request: {} },
pullRequest: null,
actorKind: "author",
bundle,
});

expect(body).toContain("Rerun when:");
expect(body).toContain("private context");
expect(body).not.toMatch(/projected score changes|12\.3|45\.6/i);
}
});

it("adds parseable aggregate-only feedback context without public leak terms", () => {
const body = buildPublicAgentCommandComment({
command: parseGittensoryMentionCommand("@gittensory preflight")!,
Expand Down