Skip to content

fix(issues): prevent self-solved issue discovery credit - #504

Merged
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-self-solved-issue-count-issue
Jun 10, 2026
Merged

fix(issues): prevent self-solved issue discovery credit#504
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-self-solved-issue-count-issue

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • Fix an integrity bug in the cached fallback for issue-discovery counts where a contributor's own merged PRs could be treated as valid_solved evidence, inflating private outcome totals and downstream scoring when official Gittensor data is absent.

Description

  • Change lifecycle classification to detect when all linked merged solver PRs are authored by the issue reporter and mark those cases as solved (not valid_solved) for issue_discovery/split lanes by adding mergedSolverPrs, issueAuthorLogin, and selfSolvedLoop checks in classifyIssueDiscoveryLifecycle in src/signals/engine.ts.
  • Update the cached fallback comment in cachedSolvedIssueCounts to clarify that merged-PR evidence still grants solved credit but does not inflate valid issue-discovery credit for self-solved loops.
  • Add a unit test (test/unit/signals-v2.test.ts) that asserts a self-authored issue/merged-PR pair is classified as solved (not valid_solved) and update expectations for contributor outcome history, reconciliation, and strengths accordingly.

Testing

  • Ran git diff --check with no issues found.
  • Ran npm run typecheck which completed successfully.
  • Ran npx vitest run test/unit/signals-v2.test.ts and all tests passed (30 passed).
  • Ran the focused test npx vitest run test/unit/signals-v2.test.ts -t "derives solved and valid-solved" which also passed.

Codex Task

@ghost

ghost commented Jun 9, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #504 is no longer open. No action.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 9, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 2f20a90 Commit Preview URL

Branch Preview URL
Jun 10 2026, 07:38 AM

@JSONbored JSONbored self-assigned this Jun 10, 2026
@JSONbored JSONbored changed the title Prevent self-solved issue discovery credit fix(issues): Prevent self-solved issue discovery credit Jun 10, 2026
@github-actions github-actions Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 10, 2026
@ghost ghost mentioned this pull request Jun 10, 2026
@JSONbored
JSONbored force-pushed the codex/propose-fix-for-self-solved-issue-count-issue branch from 2d459dc to 2f20a90 Compare June 10, 2026 07:36
@JSONbored JSONbored changed the title fix(issues): Prevent self-solved issue discovery credit fix(issues): prevent self-solved issue discovery credit Jun 10, 2026
@JSONbored
JSONbored merged commit d9cbc9d into main Jun 10, 2026
11 checks passed
@JSONbored
JSONbored deleted the codex/propose-fix-for-self-solved-issue-count-issue branch June 10, 2026 07:39
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 10, 2026
@JSONbored JSONbored added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant