feat(signals): add MinerGoalSpec type contract - #2392
Closed
Helios531 wants to merge 1 commit into
Closed
Conversation
Contributor
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 222 223 +1
Lines 24661 24662 +1
Branches 8949 8949
=======================================
+ Hits 23605 23606 +1
Misses 433 433
Partials 623 623
🚀 New features to boost your workflow:
|
Contributor
Author
|
@JSONbored Could u plz review my PR? |
This was referenced Jul 1, 2026
Closed
Merged
Owner
Stop tagging me for reviews, next time you'll wait +5 days for a review or be auto-closed. |
JSONbored
reviewed
Jul 2, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
This is a problem, closing.
The main maintainability risk is that the exported default contains mutable arrays, which future consumers can accidentally mutate as shared process state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements
#2293by adding the initial type surface for.gittensory-miner.yml.It defines the foundation-phase
MinerGoalSpeccontract and a safeDEFAULT_MINER_GOAL_SPEC, covering:minerEnabledwantedPathsblockedPathspreferredLabelsmaxConcurrentClaimsissueDiscoveryPolicyThis PR is intentionally types-only. It does not add parsing, file discovery, or CLI wiring yet.
Related Issue
Closes: #2293
Change Type
Real Behavior Proof
Before
.gittensory-miner.ymlAfter
MinerGoalSpectypeDEFAULT_MINER_GOAL_SPECValidation
Commands Run
Key Files
src/signals/miner-goal-spec.tstest/unit/miner-goal-spec.test.tsChecklist
MinerGoalSpectype addedDEFAULT_MINER_GOAL_SPECadded