feat(miner-packaging): add startup npm version nudge to gittensory-miner - #2404
Conversation
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-02 04:51:17 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 6 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2404 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 224 224
Lines 25006 25006
Branches 9094 9094
=======================================
Hits 23964 23964
Misses 428 428
Partials 614 614 🚀 New features to boost your workflow:
|
|
Hi, @JSONbored |
|
It just told you. |
|
Follow the blockers listed in the AI review. Once i enable automatic mode PRs will be closed automatically. |
|
Thanks for letting me know. I will fix righ now. |
|
I just completed work, could you please review again? |
Moving forward, please don't ask for reviews. I'm aware it needs a review, i'm working through them as time permits. The code of conduct and contribution docs both mention +5 day waits for reviews for "review nagging" - just a heads up. |
Summary
@jsonbored/gittensory-minerworkspace scaffold (CLI bin,--help/--version, engine placeholder dependency) so the packaging issue can extend a real entrypoint.gittensory-minerinvocation, starts an async npm registry lookup (5s timeout,GITTENSORY_NPM_REGISTRY_URLoverride) and printsnpm install -g @jsonbored/gittensory-miner@latestto stderr when the installed version is behind npm latest — without blocking or failing the requested command.--no-update-checkandGITTENSORY_MINER_NO_UPDATE_CHECK=1for offline/air-gapped fleets; registry/network failures are silently swallowed.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run build:minernpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateSafety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.Notes
packages/gittensory-mcp/bin/gittensory-mcp.jslines 13–17 (packageVersion/npmRegistryUrl/upgradeCommand) and the semver/npm-latest helpers used byinspectInstallVersion.#2287miner skeleton); this branch includes the minimal scaffold needed to wire the startup check. Rebase or coordinate if feat(miner): scaffold gittensory-miner package #2389 merges first.build:mineradded to roottest:ciso the new workspace package is syntax-checked in CI.Files changed
packages/gittensory-engine/packages/gittensory-miner/bin/gittensory-miner.jspackages/gittensory-miner/lib/update-check.jspackages/gittensory-miner/lib/cli.js--help/ unknown-command helperstest/unit/miner-cli.test.tstest/unit/support/miner-cli-harness.tspackage.jsonbuild:minerscript; wired intotest:cipackage-lock.json