Skip to content

feat(signals): classify Go workspace sum and toolchain pin configs - #2437

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
kiannidev:feat/signals-path-classifiers-misc
Jul 2, 2026
Merged

feat(signals): classify Go workspace sum and toolchain pin configs#2437
JSONbored merged 2 commits into
JSONbored:mainfrom
kiannidev:feat/signals-path-classifiers-misc

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Classify go.work.sum as a lockfile for slop/path matching
  • Treat .ruby-version, .node-version, .python-version, and pnpm-workspace.yaml as config files

Test plan

  • npx vitest run test/unit/path-matchers.test.ts

Made with Cursor

Recognize go.work.sum as a lockfile and treat .ruby-version, .node-version,
.python-version, and pnpm-workspace.yaml as config files for slop classification.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 2, 2026 00:22
@dosubot dosubot Bot added the size:XS label Jul 2, 2026
@loopover-orb

loopover-orb Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-02 05:23:37 UTC

2 files · 1 AI reviewer · no blockers · readiness 66/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The diff cleanly extends the path matchers by adding `go.work.sum` to exact lockfile detection and several tool/version/workspace files to exact config detection. The implementation follows the existing lowercase-basename set pattern, so nested paths and case-insensitive names continue to behave correctly. The new unit coverage exercises the direct matcher behavior, and there is no visible contract or ordering regression in `classifyChangedFile`.

Nits — 5 non-blocking
  • nit: `src/signals/path-matchers.ts:85` now includes `pnpm-workspace.yaml` under a comment that names Turborepo, Nx, and Lerna but omits pnpm, so the comment should be broadened to match the set.
  • nit: `test/unit/path-matchers.test.ts:276` does not add representative `classifyChangedFile` cases for the newly added names, even though that exported classifier is the main consumer-facing API.
  • Add `go.work.sum`, `.node-version`, `.python-version`, `.ruby-version`, and `pnpm-workspace.yaml` to the `classifyChangedFile` representative table in `test/unit/path-matchers.test.ts` to pin the integrated category behavior.
  • Update the monorepo config comment in `src/signals/path-matchers.ts` to include pnpm workspace config or make it generic enough that future exact basenames do not drift from the comment.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 2292 registered-repo PR(s), 1214 merged, 40 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 2292 PR(s), 40 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 2292 PR(s), 40 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 2, 2026
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.94%. Comparing base (8c63ec4) to head (0681838).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2437      +/-   ##
==========================================
+ Coverage   95.93%   95.94%   +0.01%     
==========================================
  Files         225      226       +1     
  Lines       25338    25369      +31     
  Branches     9218     9227       +9     
==========================================
+ Hits        24308    24341      +33     
  Misses        417      417              
+ Partials      613      611       -2     
Files with missing lines Coverage Δ
src/signals/path-matchers.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm label Jul 2, 2026
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jul 2, 2026
@JSONbored
JSONbored merged commit 7e0acf4 into JSONbored:main Jul 2, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants