Add Looker product and Instance resource support by efeelaiho · Pull Request #7898 · GoogleCloudPlatform/magic-modules

efeelaiho · 2023-05-08T21:11:20Z

Add support for Looker (Google Cloud core) as it has officially reached GA. Additions include general product and Instance resource.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.

make test is having failures even with a fresh repo

Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Add Looker Instance resource to Terraform

modular-magician · 2023-05-08T21:12:00Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @trodge, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-05-08T21:32:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2474 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2474 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 556 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 110 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (1 total tests)
Untested fields: private_ip_enabled, admin_settings.allowed_email_domains, public_ip_enabled, custom_domain.domain, consumer_network, deny_maintenance_period.start_date.year, deny_maintenance_period.start_date.day, deny_maintenance_period.start_date.month, deny_maintenance_period.time.seconds, deny_maintenance_period.time.hours, deny_maintenance_period.time.minutes, deny_maintenance_period.time.nanos, deny_maintenance_period.end_date.month, deny_maintenance_period.end_date.year, deny_maintenance_period.end_date.day, user_metadata.additional_developer_user_count, user_metadata.additional_standard_user_count, user_metadata.additional_viewer_user_count, maintenance_window.day_ofweek, maintenance_window.start_time.hours, maintenance_window.start_time.minutes, maintenance_window.start_time.nanos, maintenance_window.start_time.seconds, reserved_range

Please add acceptance tests which include these fields.

modular-magician · 2023-05-08T22:26:05Z

Tests analytics

Total tests: 2720
Passed tests 2432
Skipped tests: 279
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-08T22:39:44Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

trodge · 2023-05-09T20:40:47Z

Could you add a test that covers all the untested fields?

modular-magician · 2023-05-09T21:23:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2475 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2475 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 557 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 110 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (1 total tests)
Untested fields: custom_domain.domain, maintenance_window.day_ofweek, maintenance_window.start_time.seconds, maintenance_window.start_time.hours, maintenance_window.start_time.minutes, maintenance_window.start_time.nanos, reserved_range, user_metadata.additional_standard_user_count, user_metadata.additional_viewer_user_count, user_metadata.additional_developer_user_count, admin_settings.allowed_email_domains, consumer_network, public_ip_enabled, deny_maintenance_period.end_date.month, deny_maintenance_period.end_date.year, deny_maintenance_period.end_date.day, deny_maintenance_period.start_date.day, deny_maintenance_period.start_date.month, deny_maintenance_period.start_date.year, deny_maintenance_period.time.hours, deny_maintenance_period.time.minutes, deny_maintenance_period.time.nanos, deny_maintenance_period.time.seconds, private_ip_enabled

Please add acceptance tests which include these fields.

modular-magician · 2023-05-09T22:14:22Z

Tests analytics

Total tests: 2726
Passed tests 2436
Skipped tests: 279
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable|TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer|TestAccSqlDatabaseInstance_basicMSSQL|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccLookerInstance_lookerInstanceBasicExample

Get to know how VCR tests work

modular-magician · 2023-05-09T22:28:11Z

Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable[Debug log]
TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer[Debug log]
TestAccSqlDatabaseInstance_basicMSSQL[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…ioning

modular-magician · 2023-05-09T23:09:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2387 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2387 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 528 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 110 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (1 total tests)
Untested fields: private_ip_enabled, deny_maintenance_period.end_date.day, deny_maintenance_period.end_date.month, deny_maintenance_period.end_date.year, deny_maintenance_period.start_date.day, deny_maintenance_period.start_date.month, deny_maintenance_period.start_date.year, deny_maintenance_period.time.hours, deny_maintenance_period.time.minutes, deny_maintenance_period.time.nanos, deny_maintenance_period.time.seconds, user_metadata.additional_standard_user_count, user_metadata.additional_viewer_user_count, user_metadata.additional_developer_user_count, consumer_network, admin_settings.allowed_email_domains, maintenance_window.day_ofweek, maintenance_window.start_time.seconds, maintenance_window.start_time.hours, maintenance_window.start_time.minutes, maintenance_window.start_time.nanos, public_ip_enabled, reserved_range

Please add acceptance tests which include these fields.

modular-magician · 2023-05-10T00:08:12Z

Tests analytics

Total tests: 2726
Passed tests 2439
Skipped tests: 279
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-10T00:22:17Z

Tests passed during RECORDING mode:
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-10T15:13:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2387 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2387 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 528 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 110 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (1 total tests)
Untested fields: private_ip_enabled, admin_settings.allowed_email_domains, reserved_range, user_metadata.additional_developer_user_count, user_metadata.additional_standard_user_count, user_metadata.additional_viewer_user_count, maintenance_window.day_of_week, maintenance_window.start_time.hours, maintenance_window.start_time.minutes, maintenance_window.start_time.nanos, maintenance_window.start_time.seconds, consumer_network, public_ip_enabled, deny_maintenance_period.time.minutes, deny_maintenance_period.time.nanos, deny_maintenance_period.time.seconds, deny_maintenance_period.time.hours, deny_maintenance_period.end_date.month, deny_maintenance_period.end_date.year, deny_maintenance_period.end_date.day, deny_maintenance_period.start_date.month, deny_maintenance_period.start_date.year, deny_maintenance_period.start_date.day

Please add acceptance tests which include these fields.

modular-magician · 2023-05-10T16:04:50Z

Tests analytics

Total tests: 2726
Passed tests 2439
Skipped tests: 279
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccLookerInstance_lookerInstanceBasicExample|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-10T16:19:25Z

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-10T16:51:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2387 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2387 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 528 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 110 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (1 total tests)
Untested fields: admin_settings.allowed_email_domains, consumer_network, private_ip_enabled, user_metadata.additional_developer_user_count, user_metadata.additional_standard_user_count, user_metadata.additional_viewer_user_count, deny_maintenance_period.start_date.year, deny_maintenance_period.start_date.day, deny_maintenance_period.start_date.month, deny_maintenance_period.time.minutes, deny_maintenance_period.time.nanos, deny_maintenance_period.time.seconds, deny_maintenance_period.time.hours, deny_maintenance_period.end_date.year, deny_maintenance_period.end_date.day, deny_maintenance_period.end_date.month, maintenance_window.day_of_week, maintenance_window.start_time.hours, maintenance_window.start_time.minutes, maintenance_window.start_time.nanos, maintenance_window.start_time.seconds, reserved_range, public_ip_enabled

Please add acceptance tests which include these fields.

modular-magician · 2023-05-10T17:43:34Z

Tests analytics

Total tests: 2726
Passed tests 2439
Skipped tests: 279
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-05-10T17:57:26Z

Tests passed during RECORDING mode:
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceBasicExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-30T14:52:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2453 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2453 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 528 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 110 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (1 total tests)
Untested fields: reserved_range, private_ip_enabled, consumer_network, maintenance_window.start_time.minutes, maintenance_window.start_time.nanos, maintenance_window.start_time.seconds, maintenance_window.start_time.hours, maintenance_window.day_of_week, public_ip_enabled, user_metadata.additional_developer_user_count, user_metadata.additional_standard_user_count, user_metadata.additional_viewer_user_count, admin_settings.allowed_email_domains, deny_maintenance_period.end_date.day, deny_maintenance_period.end_date.month, deny_maintenance_period.end_date.year, deny_maintenance_period.start_date.year, deny_maintenance_period.start_date.day, deny_maintenance_period.start_date.month, deny_maintenance_period.time.hours, deny_maintenance_period.time.minutes, deny_maintenance_period.time.nanos, deny_maintenance_period.time.seconds

Please add acceptance tests which include these fields.

modular-magician · 2023-05-30T15:45:50Z

Tests analytics

Total tests: 2754
Passed tests 2461
Skipped tests: 283
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccLookerInstance_lookerInstanceBasicExample|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-30T16:37:06Z

Tests passed during RECORDING mode:
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccLookerInstance_lookerInstanceBasicExample[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-31T17:20:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2591 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2591 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 528 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 260 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_looker_instance (2 total tests)
Untested fields: consumer_network, public_ip_enabled, reserved_range, private_ip_enabled

Please add acceptance tests which include these fields.

modular-magician · 2023-05-31T18:14:49Z

Tests analytics

Total tests: 2760
Passed tests 2466
Skipped tests: 283
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccLookerInstance_lookerInstanceStandardBasicExample|TestAccBillingSubaccount_basic|TestAccBillingSubaccount_renameOnDestroy|TestAccComputeFirewallPolicyRule_multipleRules|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-31T19:45:41Z

Tests passed during RECORDING mode:
TestAccLookerInstance_lookerInstanceStandardBasicExample[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Error message] [Debug log]
TestAccBillingSubaccount_basic[Error message] [Debug log]
TestAccBillingSubaccount_renameOnDestroy[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-06-09T19:45:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2592 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2592 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 528 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 260 insertions(+))

modular-magician · 2023-06-11T20:14:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2605 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2605 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 518 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 276 insertions(+))

modular-magician · 2023-06-11T20:14:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2605 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2605 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 518 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 276 insertions(+))

modular-magician · 2023-06-11T21:10:54Z

Tests analytics

Total tests: 2786
Passed tests 2485
Skipped tests: 295
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccKmsCryptoKeyIamPolicy|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccLookerInstance_lookerInstanceStandardBasicExample

Get to know how VCR tests work

modular-magician · 2023-06-11T21:15:56Z

Tests analytics

Total tests: 2786
Passed tests 2486
Skipped tests: 295
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccLookerInstance_lookerInstanceStandardBasicExample|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

modular-magician · 2023-06-11T22:01:38Z

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]
TestAccKmsCryptoKeyIamPolicy[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccLookerInstance_lookerInstanceStandardBasicExample[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-06-11T22:06:43Z

Tests passed during RECORDING mode:
TestAccLookerInstance_lookerInstanceStandardBasicExample[Debug log]
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

trodge · 2023-06-23T20:27:44Z

/gcbrun

modular-magician · 2023-06-23T20:44:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2605 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2605 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 518 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 276 insertions(+))

modular-magician · 2023-06-23T22:02:14Z

Tests analytics

Total tests: 2817
Passed tests 2513
Skipped tests: 301
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-06-23T22:23:44Z

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson · 2023-06-27T21:01:22Z

Spoke w/ @efeelaiho offline, #8110 supersedes this PR!

efeelaiho and others added 8 commits May 6, 2023 17:54

add Looker product

a35c07f

Update Instance.yaml

a9a6e34

Update description for allowed email domains in Instance.yaml

60cce0f

Add looker_instance_basic example

b5235a6

add async definition to product.yaml

2eebe60

Update Instance.yaml for Looker

6971f45

update Instance yaml and looker_instance_basic example

db84947

Merge branch 'GoogleCloudPlatform:main' into main

e24e40a

modular-magician requested a review from trodge May 8, 2023 21:11

Merge branch 'GoogleCloudPlatform:main' into main

2d06723

efeelaiho added 2 commits May 9, 2023 22:46

remove custom domain as it requires steps outside of terraform provis…

e2d19ac

…ioning

Merge branch 'main' of https://github.com/efeelaiho/magic-modules

0d7cbd2

fix day of week name for maintenance window in Instance.yaml

b9db09a

Merge branch 'GoogleCloudPlatform:main' into main

6bbb0b6

Merge branch 'GoogleCloudPlatform:main' into main

4bedf6d

efeelaiho added 2 commits May 31, 2023 16:55

Add Enterprise example

1dc6de5

Merge branch 'GoogleCloudPlatform:main' into main

3780615

efeelaiho added 2 commits June 9, 2023 19:28

add connections variables to the examples

2cc971e

Merge branch 'GoogleCloudPlatform:main' into main

5c889b8

efeelaiho added 4 commits June 9, 2023 20:10

Merge branch 'main' of https://github.com/efeelaiho/magic-modules

fe1af54

Move netwirk to the root of module

83316b1

Merge branch 'main' of https://github.com/efeelaiho/magic-modules

60d0eca

Merge branch 'GoogleCloudPlatform:main' into main

c2eba44

rileykarson closed this Jun 27, 2023

Uh oh!

Conversation

efeelaiho commented May 8, 2023

Uh oh!

modular-magician commented May 8, 2023

Uh oh!

modular-magician commented May 8, 2023

Diff report

Missing test report

Uh oh!

modular-magician commented May 8, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented May 8, 2023

Uh oh!

trodge commented May 9, 2023

Uh oh!

modular-magician commented May 9, 2023

Diff report

Missing test report

Uh oh!

modular-magician commented May 9, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented May 9, 2023

Uh oh!

modular-magician commented May 9, 2023

Diff report

Missing test report

Uh oh!

modular-magician commented May 10, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented May 10, 2023

Uh oh!

modular-magician commented May 10, 2023

Diff report

Missing test report

Uh oh!

modular-magician commented May 10, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented May 10, 2023

Uh oh!

modular-magician commented May 10, 2023

Diff report

Missing test report

Uh oh!

modular-magician commented May 10, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented May 10, 2023

Uh oh!

modular-magician commented May 30, 2023

Diff report

Missing test report

Uh oh!

modular-magician commented May 30, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented May 30, 2023

Uh oh!

modular-magician commented May 31, 2023

Diff report

Missing test report

Uh oh!

modular-magician commented May 31, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented May 31, 2023

Uh oh!

modular-magician commented Jun 9, 2023

Diff report