Skip to content

Add Looker product and Instance resource support#469

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-e44997101d9c10594ccd3c8182543533ba189332
Jul 14, 2023
Merged

Add Looker product and Instance resource support#469
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-e44997101d9c10594ccd3c8182543533ba189332

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_looker_instance`

Derived from GoogleCloudPlatform/magic-modules#8110

Co-authored-by: Riley Karson <rileykarson@google.com>
Co-authored-by: Efe Elaiho <efeelaiho@google.com>
Co-authored-by: efeelaiho <efeelaiho15@utexas.edu>
Signed-off-by: Modular Magician <magic-modules@google.com>
@google-cla

google-cla Bot commented Jul 14, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician merged commit 538e15a into terraform-google-modules:master Jul 14, 2023
@modular-magician modular-magician deleted the downstream-pr-e44997101d9c10594ccd3c8182543533ba189332 branch November 18, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant