Skip to content

Added short sleep to google_chronicle_rule test_check_destroy#17505

Merged
malhotrasagar2212 merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:tpg-27300
May 11, 2026
Merged

Added short sleep to google_chronicle_rule test_check_destroy#17505
malhotrasagar2212 merged 1 commit into
GoogleCloudPlatform:mainfrom
melinath:tpg-27300

Conversation

@melinath

@melinath melinath commented May 11, 2026

Copy link
Copy Markdown
Member

Fixed hashicorp/terraform-provider-google#27300 (TestAccChronicleRule_chronicleRuleBasicExample_update)

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 129c4d5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 3 insertions(+)
google-beta provider View Diff 1 file changed, 3 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@melinath, @ankitgoyal0301, @malhotrasagar2212 VCR tests complete for 129c4d5!

@malhotrasagar2212 malhotrasagar2212 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@malhotrasagar2212 malhotrasagar2212 added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 1c1377d May 11, 2026
24 checks passed
@melinath

Copy link
Copy Markdown
Member Author

@melinath melinath deleted the tpg-27300 branch May 11, 2026 19:24
@melinath

Copy link
Copy Markdown
Member Author

Yeah, still fails. I'll make a new PR to extend this & test it before sending for review.

@melinath melinath restored the tpg-27300 branch May 11, 2026 21:12
@melinath melinath deleted the tpg-27300 branch May 11, 2026 21:12
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccChronicleRule_chronicleRuleBasicExample_update

3 participants