Added short sleep to google_chronicle_rule test_check_destroy#17505
Conversation
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 129c4d5: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the build log @melinath, @ankitgoyal0301, @malhotrasagar2212 VCR tests complete for 129c4d5! |
malhotrasagar2212
left a comment
There was a problem hiding this comment.
LGTM, thanks!
1c1377d
|
Manual non-recording test run to verify: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_CHRONICLE/664528 |
|
Yeah, still fails. I'll make a new PR to extend this & test it before sending for review. |
Fixed hashicorp/terraform-provider-google#27300 (TestAccChronicleRule_chronicleRuleBasicExample_update)
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.