Add Terraform support for Native Dashboard for v1 endpoint#17403
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
5a79207 to
140ff65
Compare
140ff65 to
93b1d5d
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 93b1d5d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log @divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 93b1d5d! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5a79207: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log @divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 5a79207! |
Can you confirm if the run was successful locally? |
Yes, I've run the tests locally and they are all passing for the v1 endpoint. |
|
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
/gcbrun The tests for google_chronicle_dashboard_chart are currently failing for the GA provider because native_dashboard hasn't been promoted yet. |
|
I'll take this over as release shepherd for last week, since I need it for release validation. |
|
@modular-magician reassign-reviewer @melinath |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 93b1d5d: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log @divyamjain000, @melinath, @ankitgoyal0301 VCR tests complete for 93b1d5d! |
|
Manual GA test run (you won't have access to this): https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_CHRONICLE/664522 |
|
Tests passed (except for an unrelated failure that should be fixed by #17505) |
b5b629b
This commit introduces Terraform resources for the Google Chronicle Data Table Row v1 API, including:
google_chronicle_native_dashboardFixes hashicorp/terraform-provider-google#27213
Fixed hashicorp/terraform-provider-google#27308
Fixed hashicorp/terraform-provider-google#27307
Fixed hashicorp/terraform-provider-google#27305
Release Note Template for Downstream PRs (will be copied)