Skip to content

Add Terraform support for Native Dashboard for v1 endpoint#17403

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
divyamjain000:chronicle-nativedashboard-divyamjain
May 11, 2026
Merged

Add Terraform support for Native Dashboard for v1 endpoint#17403
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
divyamjain000:chronicle-nativedashboard-divyamjain

Conversation

@divyamjain000

@divyamjain000 divyamjain000 commented May 4, 2026

Copy link
Copy Markdown
Contributor

This commit introduces Terraform resources for the Google Chronicle Data Table Row v1 API, including:

  • google_chronicle_native_dashboard

Fixes hashicorp/terraform-provider-google#27213
Fixed hashicorp/terraform-provider-google#27308
Fixed hashicorp/terraform-provider-google#27307
Fixed hashicorp/terraform-provider-google#27305

Release Note Template for Downstream PRs (will be copied)

`google_chronicle_native_dashboard` (ga)

@github-actions github-actions Bot requested a review from trodge May 4, 2026 05:19
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@divyamjain000 divyamjain000 force-pushed the chronicle-nativedashboard-divyamjain branch from 5a79207 to 140ff65 Compare May 4, 2026 05:20
@divyamjain000 divyamjain000 force-pushed the chronicle-nativedashboard-divyamjain branch from 140ff65 to 93b1d5d Compare May 4, 2026 05:22
@modular-magician

modular-magician commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 93b1d5d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1851 insertions(+), 5 deletions(-)
google-beta provider View Diff 3 files changed, 3 insertions(+), 7 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample
🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log

@divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 93b1d5d!

@modular-magician

modular-magician commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5a79207:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1851 insertions(+), 5 deletions(-)
google-beta provider View Diff 3 files changed, 3 insertions(+), 7 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample
🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log

@divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 5a79207!

@ankitgoyal0301

Copy link
Copy Markdown
Contributor

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5a79207:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1851 insertions(+), 5 deletions(-)
google-beta provider View Diff 3 files changed, 3 insertions(+), 7 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample 🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages

  • chronicle

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log

@divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 5a79207!

Can you confirm if the run was successful locally?

@divyamjain000

Copy link
Copy Markdown
Contributor Author

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5a79207:

Diff report

Your PR generated the following diffs in downstream repositories:
Repository Diff Link Changes
google provider View Diff 5 files changed, 1851 insertions(+), 5 deletions(-)
google-beta provider View Diff 3 files changed, 3 insertions(+), 7 deletions(-)

Test report

Important
Manual Verification Required (GA-only additions)
The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:
🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample 🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages

  • chronicle

Learn how VCR tests work
Step 1: Replaying Mode
🟢 All tests passed in Replaying mode! No Recording was needed.
Caution
Issues requiring attention before PR completion
🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.
Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.
View the build log
@divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 5a79207!

Can you confirm if the run was successful locally?

Yes, I've run the tests locally and they are all passing for the v1 endpoint.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@melinath

Copy link
Copy Markdown
Member

/gcbrun

The tests for google_chronicle_dashboard_chart are currently failing for the GA provider because native_dashboard hasn't been promoted yet.

@melinath

Copy link
Copy Markdown
Member

I'll take this over as release shepherd for last week, since I need it for release validation.

@melinath

Copy link
Copy Markdown
Member

@modular-magician reassign-reviewer @melinath

@github-actions github-actions Bot requested review from melinath and removed request for trodge May 11, 2026 16:37
@modular-magician

modular-magician commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 93b1d5d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 1899 insertions(+), 5 deletions(-)
google-beta provider View Diff 3 files changed, 3 insertions(+), 7 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardBasicExample
🔴 TestAccChronicleNativeDashboard_chronicleNativedashboardUpdateExample

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log

@divyamjain000, @melinath, @ankitgoyal0301 VCR tests complete for 93b1d5d!

@melinath

melinath commented May 11, 2026

Copy link
Copy Markdown
Member

@melinath

Copy link
Copy Markdown
Member

Tests passed (except for an unrelated failure that should be fixed by #17505)

@melinath melinath added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit b5b629b May 11, 2026
25 checks passed
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

4 participants