Skip to content

Revert "Added short sleep to google_chronicle_rule test_check_destroy"#17518

Merged
malhotrasagar2212 merged 1 commit into
mainfrom
revert-17505-tpg-27300
May 12, 2026
Merged

Revert "Added short sleep to google_chronicle_rule test_check_destroy"#17518
malhotrasagar2212 merged 1 commit into
mainfrom
revert-17505-tpg-27300

Conversation

@melinath

@melinath melinath commented May 11, 2026

Copy link
Copy Markdown
Member

Reverts #17505.

This didn't actually fix the problem. Reverting to avoid confusion.

@modular-magician

modular-magician commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2471d80:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 3 deletions(-)
google-beta provider View Diff 1 file changed, 3 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@melinath, @ankitgoyal0301, @malhotrasagar2212 VCR tests complete for 2471d80!

@malhotrasagar2212 malhotrasagar2212 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants