Skip to content

Add support for enabling Pod Snapshots#15262

Closed
tonyzhc wants to merge 8 commits into
GoogleCloudPlatform:mainfrom
tonyzhc:add-pod-snapshots-config
Closed

Add support for enabling Pod Snapshots#15262
tonyzhc wants to merge 8 commits into
GoogleCloudPlatform:mainfrom
tonyzhc:add-pod-snapshots-config

Conversation

@tonyzhc

@tonyzhc tonyzhc commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

container: added `pod_snapshot_config` field to `google_container_cluster` resource.

…luster

This change adds the `pod_snapshots_config` field to the `addons_config` block of the `google_container_cluster` resource.

This new field allows users to enable or disable the Pod Snapshots feature for their GKE clusters.
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 19 files changed, 282 insertions(+), 2384 deletions(-))
google-beta provider: Diff ( 19 files changed, 282 insertions(+), 2384 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 625 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • beyondcorp
  • compute
  • container
  • networksecurity
  • vertexai

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@tonyzhc tonyzhc force-pushed the add-pod-snapshots-config branch from da16767 to b897312 Compare September 30, 2025 16:38
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 42 insertions(+))
google-beta provider: Diff ( 3 files changed, 42 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • container

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@tonyzhc tonyzhc marked this pull request as ready for review October 8, 2025 16:02
@tonyzhc

tonyzhc commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

To the reviewer: the field rollout is still pending, but I'd like to get a review in advance so that we can line up the submission of the CL with the launch.

@github-actions github-actions Bot requested a review from trodge October 8, 2025 16:03
@github-actions

github-actions Bot commented Oct 8, 2025

Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@trodge

trodge commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

Here's the current build error:

Error: google/services/container/resource_container_cluster.go:5190:6: ac.PodSnapshotConfig undefined (type *"google.golang.org/api/container/v1".AddonsConfig has no field or method PodSnapshotConfig)
Error: google/services/container/resource_container_cluster.go:5190:37: undefined: container.PodSnapshotConfig
Error: google/services/container/resource_container_cluster.go:6586:7: c.PodSnapshotConfig undefined (type *"google.golang.org/api/container/v1".AddonsConfig has no field or method PodSnapshotConfig)
Error: google/services/container/resource_container_cluster.go:6589:18: c.PodSnapshotConfig undefined (type *"google.golang.org/api/container/v1".AddonsConfig has no field or method PodSnapshotConfig)

I'm guessing that this will be resolved when we upgrade our container api version to the one that includes the new feature, but the new feature isn't released yet?

@trodge trodge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the new feature is available, please upgrade the go.mod file in a separate PR then rebase this one after it merges.

@github-actions

Copy link
Copy Markdown

@tonyzhc, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

@tonyzhc, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions

Copy link
Copy Markdown

@tonyzhc, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions

Copy link
Copy Markdown

@tonyzhc, this PR is being closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants