Fix Test and Update AuthZ policy resource to support new API signature

[maxi-cit]

Fixes: hashicorp/terraform-provider-google#23036
Fixes: hashicorp/terraform-provider-google#23037

Due to the API update for AuthzPolicies, some limits have been revised and the signatures of certain fields have changed. The provider still accepts the old format, but calls will be rejected because of the API change. This PR aims to reconcile the provider with the new signature and deprecate the fields that are no longer available.

The deprecated fields should be removed in another PR for version 8.0 of the provider.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networksecurity: added `ip_blocks`  field to `google_network_security_authz_policy` resource

networksecurity: deprecated `ignore_case`, `exact`, `prefix`, `suffix` and `contains` on `google_network_security_authz_policy.http_rules.from.not_sources` and `google_network_security_authz_policy.http_rules.from.sources`. Use `location` instead.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[NickElliot]

largely lgtm pending test runs, but a bunch of changes to formatting are necessary

also if you could write a changelog note that would be great thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 974 insertions(+), 175 deletions(-))
google-beta provider: Diff ( 4 files changed, 974 insertions(+), 175 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 258 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  http_rules {
    from {
      not_sources {
        ip_blocks {
          length = # value needed
          prefix = # value needed
        }
        principals {
          contains    = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
      sources {
        ip_blocks {
          length = # value needed
          prefix = # value needed
        }
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 67
Passed tests: 61
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

• networksecurity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample
• TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyHttpRules

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Error message] [Debug log]
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyHttpRules [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[maxi-cit]

Hello @NickElliot, I added the missing IpBlocks to test. However I am not sure on how to proceed with the test check for untested fields. The old fields were removed from the API signature but I understand I will have to follow the deprecation steps to get them removed in provider ver 8.0

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 995 insertions(+), 176 deletions(-))
google-beta provider: Diff ( 4 files changed, 995 insertions(+), 176 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 258 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  http_rules {
    from {
      not_sources {
        principals {
          contains    = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
      sources {
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          suffix      = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 67
Passed tests: 61
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

• networksecurity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample
• TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyHttpRules

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Error message] [Debug log]
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyHttpRules [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[github-actions]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[NickElliot]

the tests are failing due to errors about prefix, i.e.

          on terraform_plugin_test.tf line 135, in resource "google_network_security_authz_policy" "default":
         135:           prefix = "10.1.6.0"
        
        Inappropriate value for attribute "prefix": a number is required.

can you fix your additions to the tests? thanks!

[maxi-cit]

Hi @NickElliot, this is not consistent with API docs.

https://cloud.google.com/load-balancing/docs/reference/network-security/rest/v1beta1/projects.locations.authzPolicies#IpBlock

I am checking this with the appropiate team.

[maxi-cit]

Hello @NickElliot, could you run tests please? I already talked with team regarding some of the updates and I updated the PR appropiately.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 924 insertions(+), 206 deletions(-))
google-beta provider: Diff ( 4 files changed, 924 insertions(+), 206 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 270 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  http_rules {
    from {
      not_sources {
        principals {
          contains    = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains = # value needed
            prefix   = # value needed
            suffix   = # value needed
          }
          suffix = # value needed
        }
      }
      sources {
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains = # value needed
            prefix   = # value needed
            suffix   = # value needed
          }
          suffix = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 68
Passed tests: 62
Skipped tests: 4
Affected tests: 2

Click here to see the affected service packages

• networksecurity

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample
• TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyHttpRules

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyHttpRules [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[NickElliot]

LGTM!

misclick

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 942 insertions(+), 208 deletions(-))
google-beta provider: Diff ( 5 files changed, 942 insertions(+), 208 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 270 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_security_authz_policy (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_security_authz_policy" "primary" {
  http_rules {
    from {
      not_sources {
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains = # value needed
            prefix   = # value needed
            suffix   = # value needed
          }
          suffix = # value needed
        }
      }
      sources {
        principals {
          contains    = # value needed
          exact       = # value needed
          ignore_case = # value needed
          prefix      = # value needed
          principal {
            contains = # value needed
            prefix   = # value needed
            suffix   = # value needed
          }
          suffix = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 68
Passed tests: 63
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages

• networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[NickElliot]

LGTM