Skip to content

new-resource: google_vertex_ai_cache_config#15157

Merged
roaks3 merged 2 commits into
GoogleCloudPlatform:mainfrom
ramonvermeulen:ramon/22968-vertexai-cache-configuration
Sep 29, 2025
Merged

new-resource: google_vertex_ai_cache_config#15157
roaks3 merged 2 commits into
GoogleCloudPlatform:mainfrom
ramonvermeulen:ramon/22968-vertexai-cache-configuration

Conversation

@ramonvermeulen

Copy link
Copy Markdown
Contributor

Closes hashicorp/terraform-provider-google#22968

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_vertex_ai_cache_config`

@github-actions

Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, running checks now

Comment thread mmv1/products/vertexai/CacheConfig.yaml Outdated
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 480 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 480 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_cache_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 73
Passed tests: 66
Skipped tests: 3
Affected tests: 4

Click here to see the affected service packages
  • vertexai

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccVertexAICacheConfig_vertexAiCacheConfigExample
  • TestAccVertexAIEndpointIamPolicy
  • TestAccVertexAIEndpointIamPolicyGenerated
  • TestAccVertexAIFeatureOnlineStoreFeatureviewIamPolicyGenerated

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccVertexAICacheConfig_vertexAiCacheConfigExample [Debug log]
TestAccVertexAIEndpointIamPolicy [Debug log]
TestAccVertexAIEndpointIamPolicyGenerated [Debug log]
TestAccVertexAIFeatureOnlineStoreFeatureviewIamPolicyGenerated [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions Bot requested a review from roaks3 September 19, 2025 06:44
@github-actions

Copy link
Copy Markdown

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I think I just missed the follow-up on this last week (and then went OOO). Waiting on the checks to run once more, then I'll merge.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 480 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 480 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_vertex_ai_cache_config

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 78
Passed tests: 75
Skipped tests: 3
Affected tests: 0

Click here to see the affected service packages
  • vertexai

🟢 All tests passed!

View the build log

@roaks3 roaks3 added this pull request to the merge queue Sep 29, 2025
Merged via the queue into GoogleCloudPlatform:main with commit 61a1369 Sep 29, 2025
25 of 26 checks passed
tonyzhc pushed a commit to tonyzhc/magic-modules that referenced this pull request Sep 30, 2025
jkrish-c pushed a commit to jkrish-c/magic-modules that referenced this pull request Oct 14, 2025
g-dreva pushed a commit to g-dreva/magic-modules that referenced this pull request Oct 15, 2025
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 20, 2025
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow enabling/disabling Context Caching in in Vertex AI in GCP

3 participants