Repository navigation
Accept Named stellar spectra v1 or v2 in the manifest pin tests - #962
Merged
Merged
Conversation
Named stellar spectra v2 (Zenodo 23197931) adds toi561.txt to the 11 files of v1 (15721440). The shared-dataset tests now accept either record for star.spectra.named, so moving the fwl-io pin to v2 does not turn PROTEUS red. Any other record still fails.
The Named registry has 11 files in v1 and 12 in v2, so the file count now follows the pinned record, and on v2 the toi561.txt checksum is pinned too. The accepted records move into a one-entry mapping.
The versioned-directory test now takes the record from the pinned DOI, checks that it is an accepted record, and compares the directory exactly, so a resolver that serves the v1 directory under a v2 pin fails. The pin check strips the Zenodo DOI prefix instead of building every accepted DOI.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
=======================================
Coverage 93.57% 93.58%
=======================================
Files 127 127
Lines 21186 21186
Branches 3597 3597
=======================================
+ Hits 19824 19826 +2
+ Misses 941 940 -1
+ Partials 421 420 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Named stellar spectra record on Zenodo has a new version, 23197931, which holds the 11 v1 files plus
toi561.txt. fwl-io moves itsstar.spectra.namedpin to that version in its next release, with the DataverseNL mirror10.34894/URD02X. Until then the manifest tests must pass with either pin, or the PROTEUS CI goes red on the day the pin moves. Part of FormingWorlds/fwl-io#58 (FormingWorlds/fwl-io#58).toi561.txtchecksum for v2.Once fwl-io ships the v2 pin, the v1 branch of these tests goes, together with a bump of the fwl-io floor. No source code changes.
Validation of changes
tests/data/test_manifest.pypasses against the installed fwl-io 26.10.6 (v1 pin) and against a copy of that package with the v2 pin and the 12-line registry. These wrong states each fail at least one test: a v2 pin with the 11-line registry, a v1 pin with 12 lines, a wrongtoi561.txtchecksum, a foreign DOI prefix, and a wrong record number. The 11 v1 checksums are identical in the v2 record on Zenodo. The branch merges clean with #960.Tested on macOS with Python 3.12.
Checklist