Skip to content

Accept Named stellar spectra v1 or v2 in the manifest pin tests - #962

Merged
timlichtenberg merged 3 commits into
mainfrom
tl/named-v2-anchor
Oct 7, 2026
Merged

timlichtenberg merged 3 commits into
mainfrom
tl/named-v2-anchor

Conversation

@timlichtenberg

Copy link
Copy Markdown
Member

Description

The Named stellar spectra record on Zenodo has a new version, 23197931, which holds the 11 v1 files plus toi561.txt. fwl-io moves its star.spectra.named pin to that version in its next release, with the DataverseNL mirror 10.34894/URD02X. Until then the manifest tests must pass with either pin, or the PROTEUS CI goes red on the day the pin moves. Part of FormingWorlds/fwl-io#58 (FormingWorlds/fwl-io#58).

  • The shared-pin test accepts the v1 or the v2 record for the Named dataset and still requires the Zenodo DOI prefix; every other dataset keeps its exact pin.
  • The registry test expects 11 files with the v1 pin and 12 with the v2 pin, and pins the toi561.txt checksum for v2.
  • The version-directory test compares the directory with the record the manifest pins, and checks that this record is one of the two.

Once fwl-io ships the v2 pin, the v1 branch of these tests goes, together with a bump of the fwl-io floor. No source code changes.

Validation of changes

tests/data/test_manifest.py passes against the installed fwl-io 26.10.6 (v1 pin) and against a copy of that package with the v2 pin and the 12-line registry. These wrong states each fail at least one test: a v2 pin with the 11-line registry, a v1 pin with 12 lines, a wrong toi561.txt checksum, a foreign DOI prefix, and a wrong record number. The 11 v1 checksums are identical in the v2 record on Zenodo. The branch merges clean with #960.

Tested on macOS with Python 3.12.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Named stellar spectra v2 (Zenodo 23197931) adds toi561.txt to the 11 files of v1 (15721440). The shared-dataset tests now accept either record for star.spectra.named, so moving the fwl-io pin to v2 does not turn PROTEUS red. Any other record still fails.
The Named registry has 11 files in v1 and 12 in v2, so the file count now follows the pinned record, and on v2 the toi561.txt checksum is pinned too. The accepted records move into a one-entry mapping.
The versioned-directory test now takes the record from the pinned DOI, checks that it is an accepted record, and compares the directory exactly, so a resolver that serves the v1 directory under a v2 pin fails. The pin check strips the Zenodo DOI prefix instead of building every accepted DOI.
@timlichtenberg
timlichtenberg requested a review from a team as a code owner October 7, 2026 03:57
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.58%. Comparing base (4936a75) to head (5ea1b25).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   93.57%   93.58%           
=======================================
  Files         127      127           
  Lines       21186    21186           
  Branches     3597     3597           
=======================================
+ Hits        19824    19826    +2     
+ Misses        941      940    -1     
+ Partials      421      420    -1     
Flag Coverage Δ
nightly 93.54% <ø> (ø)
unit-tests 92.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timlichtenberg
timlichtenberg merged commit f32fb15 into main Oct 7, 2026
41 checks passed
@timlichtenberg
timlichtenberg deleted the tl/named-v2-anchor branch October 7, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant