Repository navigation
Accept only Named stellar spectra v2 and require fwl-io 26.10.7.1 - #967
Merged
Merged
Conversation
fwl-io pins star.spectra.named to the v2 record 23197931, which holds 12 spectra including toi561.txt. The manifest tests now require that record: the shared-pin and version-directory tests compare against it directly, and the registry test expects 12 files with the toi561.txt checksum.
fwl-io 26.10.7.1 pins the Named stellar spectra to v2, which the manifest tests now require. The pyproject floor and FWL_IO_FLOOR, which the upgrade messages name, move to that release.
The floor is the oldest fwl-io that reads the manifest schema and pins each shared dataset PROTEUS reads at the expected version, which for 26.10.7.1 is the Named stellar spectra v2.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
==========================================
- Coverage 93.97% 93.65% -0.33%
==========================================
Files 128 128
Lines 20891 20891
Branches 3515 3515
==========================================
- Hits 19633 19566 -67
- Misses 908 914 +6
- Partials 350 411 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
8 tasks done
timlichtenberg
added a commit
that referenced
this pull request
Oct 7, 2026
…#968) A star_name that neither the MUSCLES nor the solar registry lists now resolves to the Named stellar spectra in the fwl-io dataset directory, and input/planets/toi561b.toml uses star_name = "toi561" instead of a hard-coded path that fwl-io never writes. The source follows the registries, not the local files, so a missing local file never switches a listed star to a different spectrum. Named file names keep their case. The error for an unknown name lists all three sets and names proteus get stellar for the Named spectra. The spectrum guide describes the fallback. The TOI-561 spectrum needs fwl-io>=26.10.7.1 (#967).
IKisvardai
added a commit
that referenced
this pull request
Oct 9, 2026
Brings in the prescribed orbital migration (#937), the CALLIOPE cold-start seed (#958), the fwl-io dataset fetch and stellar spectra changes (#960, #964, #967, #968), the PETSc download (#965), Zalmoxis Anderson acceleration with fwl-aragog 26.10.08 (#971) and the CI changes (#955, #970). The schema invariant tests keep both the trapping and the migration validators, and the golden trajectory is main's re-recorded one with the trapping columns added.
15 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fwl-io 26.10.07.1 pins the Named stellar spectra to their second Zenodo version, 23197931, with the DataverseNL mirror 10.34894/URD02X, so the manifest tests now accept that version only, and PROTEUS requires fwl-io>=26.10.7.1. The tests compare the pin exactly and expect 12 Named spectra, with the
toi561.txtchecksum pinned. Part of FormingWorlds/fwl-io#58; follows #962.Validation of changes
With fwl-io 26.10.7.1 installed,
tests/dataandtests/utils/test_data.pypass (189). Against fwl-io 26.10.07, which still pins version 1, three manifest tests fail, as they should.Tested on macOS with Python 3.12.
Checklist