fix(ci): target staging environment for desktop release builds#464
Conversation
Desktop releases should use the staging environment and API until a production deployment is set up. This fixes missing env vars (GOOGLE_CLIENT_ID, API_URL) that caused login failures in production binaries, and also resolves the Web3Auth network mismatch since staging maps to DEVNET which matches the client ID registration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 45316dc217a8
|
Warning Review limit reached
More reviews will be available in 54 minutes and 3 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Desktop Release workflow is updated to build desktop binaries against the staging environment instead of production. All three platform jobs (macOS, Windows, Linux) have their ChangesDesktop Release Workflow Staging Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Targets the staging GitHub environment for the desktop release workflow so that release builds are compiled with the correct Vite env vars (API URL, Google OAuth client ID context, and Web3Auth network selection), avoiding fallbacks to localhost and Web3Auth network mismatch.
Changes:
- Switched macOS/Windows/Linux desktop release jobs to use the
stagingGitHub Actions environment. - Updated build-time Vite variables to use
vars.STAGING_API_URLandVITE_ENVIRONMENT=stagingacross all three jobs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: efb07ddb8f56
Release PreviewNo version bumps detected. All changes are in unversioned paths or use exempt commit types. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: bb337ece2327
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 62.37% 62.34% -0.03%
==========================================
Files 135 135
Lines 10157 10157
Branches 1083 1081 -2
==========================================
- Hits 6335 6332 -3
- Misses 3598 3601 +3
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
productionGitHub environment which has no vars configuredVITE_API_URL(Rust backend fell back tolocalhost:3000) and emptyVITE_GOOGLE_CLIENT_ID(Google OAuth failed)VITE_ENVIRONMENT=productionmapped toMAINNET, but the client ID is registered onsapphire_devnet)stagingenvironment,STAGING_API_URL, andVITE_ENVIRONMENT=stagingSupersedes #462 — the
NETWORK_MAPcode change is no longer needed sincestagingalready maps toDEVNET.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit