fix(ci): wire Tauri signing keys into staging desktop builds#370
Conversation
The updater pubkey in tauri.conf.json requires TAURI_SIGNING_PRIVATE_KEY at build time. Pass the repo secrets to all three desktop build jobs (macOS, Windows, Linux). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 69aff622d140
WalkthroughThe deploy-staging GitHub Actions workflow is updated to pass Tauri signing credentials ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/deploy-staging.yml (1)
178-178: Standardizetauri-apps/tauri-actionversion across workflows.Version drift detected:
deploy-staging.yml(lines 178, 272, 348) uses@v0, whilebuild-desktop.ymluses@v1. Align to the same major version to avoid subtle behavior differences between staging and release pipelines.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/deploy-staging.yml at line 178, Update the tauri Action usage in the staging workflow: replace every occurrence of "uses: tauri-apps/tauri-action@v0" in deploy-staging.yml with the same major version used in build-desktop.yml (e.g., "uses: tauri-apps/tauri-action@v1") so both workflows use the same tauri-action major release; ensure you update all instances in the file and run a quick workflow lint to confirm syntax.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/deploy-staging.yml:
- Line 178: Update the tauri Action usage in the staging workflow: replace every
occurrence of "uses: tauri-apps/tauri-action@v0" in deploy-staging.yml with the
same major version used in build-desktop.yml (e.g., "uses:
tauri-apps/tauri-action@v1") so both workflows use the same tauri-action major
release; ensure you update all instances in the file and run a quick workflow
lint to confirm syntax.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0766574d-761d-4039-a6c5-69146ff3fd3a
📒 Files selected for processing (1)
.github/workflows/deploy-staging.yml
Summary
TAURI_SIGNING_PRIVATE_KEYandTAURI_SIGNING_PRIVATE_KEY_PASSWORDrepo secrets to all three desktop build jobs (macOS, Windows, Linux) in the staging deploy workflowtauri.conf.jsonbut the corresponding private key wasn't passed at build time, causingA public key has been found, but no private keyerrorsTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit