Skip to content

fix(desktop): use Web3Auth devnet network for production builds#462

Merged
FSM1 merged 5 commits into
mainfrom
fix/web3auth-devnet-network
May 25, 2026
Merged

fix(desktop): use Web3Auth devnet network for production builds#462
FSM1 merged 5 commits into
mainfrom
fix/web3auth-devnet-network

Conversation

@FSM1

@FSM1 FSM1 commented May 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • The desktop release workflow sets VITE_ENVIRONMENT=production, which mapped to WEB3AUTH_NETWORK.MAINNET in the Core Kit network config
  • The Web3Auth client ID is registered on sapphire_devnet, causing a network mismatch error on login: Client network mismatch, clientId ... belongs to network: sapphire_devnet, and app is configured on network: sapphire_mainnet
  • Changed the production mapping to DEVNET in the desktop Core Kit config to match the actual client ID registration

Test plan

  • Production desktop build initializes Web3Auth without network mismatch error
  • Desktop login flows (Google, Email) work in production builds

🤖 Generated with Claude Code

FSM1 and others added 4 commits May 25, 2026 20:09
The Web3Auth client ID is registered on sapphire_devnet, but production
builds set VITE_ENVIRONMENT=production which mapped to MAINNET, causing
a network mismatch error on login.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: b38f63f2e439
The web app deploy uses VITE_ENVIRONMENT=staging which already maps to
DEVNET. Only the desktop release workflow sets production, so only the
desktop config needed the change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: e32b56a89d3d
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 0dd0f9327354
Copilot AI review requested due to automatic review settings May 25, 2026 18:31
@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@github-actions[bot], we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 41 minutes and 27 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 184db56f-87fb-4140-adce-f75fad1045d0

📥 Commits

Reviewing files that changed from the base of the PR and between 1318138 and 063c4ce.

📒 Files selected for processing (2)
  • apps/desktop/src/auth.ts
  • release-please-config.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/web3auth-devnet-network

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the release:desktop:fix Patch version bump (bug fix) for desktop label May 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Release Preview

Package Bump Label Source
desktop minor release:desktop:fix Direct (fix commit)
web minor release:web:fix Direct (fix commit)

@github-actions github-actions Bot added the release:web:fix Patch version bump (bug fix) for web label May 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts CipherBox Desktop’s Web3Auth Core Kit network selection for production desktop builds to avoid Web3Auth “client network mismatch” failures during login, and updates the desktop package’s release-please configuration.

Changes:

  • Remaps VITE_ENVIRONMENT=production to use WEB3AUTH_NETWORK.DEVNET in the desktop Core Kit initialization.
  • Updates release-please-config.json for apps/desktop (inlines extra-files formatting and bumps release-as).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
release-please-config.json Updates desktop release-please settings (extra-files formatting + forces next desktop release version).
apps/desktop/src/auth.ts Changes the Web3Auth network mapping for production builds in the desktop auth module.

Comment thread apps/desktop/src/auth.ts
ci: WEB3AUTH_NETWORK.DEVNET,
staging: WEB3AUTH_NETWORK.DEVNET,
production: WEB3AUTH_NETWORK.MAINNET,
production: WEB3AUTH_NETWORK.DEVNET,
Comment on lines 82 to 84
"bump-minor-pre-major": true,
"extra-files": [
"src-tauri/tauri.conf.json",
@FSM1 FSM1 closed this May 25, 2026
@FSM1 FSM1 reopened this May 25, 2026
@FSM1 FSM1 removed the release:web:fix Patch version bump (bug fix) for web label May 25, 2026
@FSM1 FSM1 enabled auto-merge (squash) May 25, 2026 21:19
@github-actions github-actions Bot added the release:web:fix Patch version bump (bug fix) for web label May 25, 2026
@FSM1 FSM1 closed this May 25, 2026
auto-merge was automatically disabled May 25, 2026 21:25

Pull request was closed

@FSM1 FSM1 reopened this May 25, 2026
@FSM1 FSM1 enabled auto-merge (squash) May 25, 2026 21:27
@codecov

codecov Bot commented May 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.65%. Comparing base (1318138) to head (063c4ce).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   62.37%   62.65%   +0.28%     
==========================================
  Files         135      135              
  Lines       10157    10157              
  Branches     1083     1083              
==========================================
+ Hits         6335     6364      +29     
+ Misses       3598     3573      -25     
+ Partials      224      220       -4     
Flag Coverage Δ
api 84.72% <ø> (ø)
api-client 84.72% <ø> (ø)
core 84.72% <ø> (ø)
crypto 84.72% <ø> (ø)
sdk 84.72% <ø> (ø)
sdk-core 84.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FSM1 FSM1 merged commit d502940 into main May 25, 2026
41 checks passed
@FSM1 FSM1 deleted the fix/web3auth-devnet-network branch May 25, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:desktop:fix Patch version bump (bug fix) for desktop release:web:fix Patch version bump (bug fix) for web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants