chore(ci): remove standalone build-desktop workflow#379
Conversation
Desktop builds are handled by deploy-staging.yml when a staging tag is pushed. The standalone build-desktop.yml triggered on every release event (including SDK-only releases) and was redundant. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: dc31d724045f
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 27 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughRemoved the release-triggered multi-platform desktop build workflow and updated the staging deploy workflow to publish desktop releases as non-prereleases and include the updater JSON in release artifacts. Changes
Sequence Diagram(s)(omitted — changes are workflow deletion and small parameter updates, not a new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tauri's auto-updater fetches /releases/latest/download/latest.json, which only resolves to non-prerelease releases. With staging as the production environment: - Set prerelease: false so /releases/latest/ points to staging builds - Add includeUpdaterJson: true so latest.json is generated and attached Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: c007126f03a6
There was a problem hiding this comment.
Pull request overview
Removes the standalone desktop build workflow that ran on every GitHub Release event, relying instead on the existing staging deployment workflow for desktop builds.
Changes:
- Deleted
.github/workflows/build-desktop.yml(release-published desktop build pipeline). - Updated
.github/workflows/deploy-staging.ymldesktop build jobs to setprerelease: falseand enableincludeUpdaterJson.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/deploy-staging.yml |
Adjusts staging desktop release settings (prerelease flag + updater JSON generation). |
.github/workflows/build-desktop.yml |
Removes the release-triggered desktop build workflow entirely. |
The create step used --prerelease while tauri-action set prerelease: false, causing an inconsistent flip. Since staging is the production environment, all desktop releases should be non-prerelease so the Tauri auto-updater can find them via /releases/latest/. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: bfa867b7bfda
Summary
build-desktop.ymlwhich triggered on every release event (including SDK-only releases like@cipherbox/sdk-v0.31.0)deploy-staging.ymlwhen staging tags are pushed🤖 Generated with Claude Code
Summary by CodeRabbit
Revert
Chores