Skip to content

chore(ci): remove standalone build-desktop workflow#379

Merged
FSM1 merged 3 commits into
mainfrom
chore/remove-build-desktop-workflow
Mar 27, 2026
Merged

chore(ci): remove standalone build-desktop workflow#379
FSM1 merged 3 commits into
mainfrom
chore/remove-build-desktop-workflow

Conversation

@FSM1

@FSM1 FSM1 commented Mar 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove build-desktop.yml which triggered on every release event (including SDK-only releases like @cipherbox/sdk-v0.31.0)
  • Desktop builds are already handled by deploy-staging.yml when staging tags are pushed

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Revert

    • Automated desktop application builds have been removed from the release process.
  • Chores

    • Desktop release artifacts are now published as full releases (not prereleases) and include updater JSON to support the app updater.

Desktop builds are handled by deploy-staging.yml when a staging tag
is pushed. The standalone build-desktop.yml triggered on every release
event (including SDK-only releases) and was redundant.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: dc31d724045f
@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@FSM1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 27 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 27 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5d37943c-ac62-4bdf-97ab-09a96790e18d

📥 Commits

Reviewing files that changed from the base of the PR and between 411f42b and e1f27e8.

📒 Files selected for processing (1)
  • .github/workflows/deploy-staging.yml

Walkthrough

Removed the release-triggered multi-platform desktop build workflow and updated the staging deploy workflow to publish desktop releases as non-prereleases and include the updater JSON in release artifacts.

Changes

Cohort / File(s) Summary
Desktop Build Workflow Deletion
.github/workflows/build-desktop.yml
Deleted the GitHub Actions workflow that performed multi-platform Tauri builds (macOS aarch64/x86_64, Ubuntu 22.04, Windows), installed toolchain targets and platform-specific dependencies, cached Rust builds, and packaged release artifacts via tauri-action.
Staging Deploy Workflow Update
.github/workflows/deploy-staging.yml
Changed Tauri release creation parameters in macOS/Windows/Linux deploy jobs: set prerelease: false and added includeUpdaterJson: true to include updater JSON with release artifacts.

Sequence Diagram(s)

(omitted — changes are workflow deletion and small parameter updates, not a new multi-component control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately reflects the primary change: removal of the build-desktop.yml workflow file, which is the main alteration in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-build-desktop-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tauri's auto-updater fetches /releases/latest/download/latest.json,
which only resolves to non-prerelease releases. With staging as the
production environment:

- Set prerelease: false so /releases/latest/ points to staging builds
- Add includeUpdaterJson: true so latest.json is generated and attached

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: c007126f03a6

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the standalone desktop build workflow that ran on every GitHub Release event, relying instead on the existing staging deployment workflow for desktop builds.

Changes:

  • Deleted .github/workflows/build-desktop.yml (release-published desktop build pipeline).
  • Updated .github/workflows/deploy-staging.yml desktop build jobs to set prerelease: false and enable includeUpdaterJson.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/deploy-staging.yml Adjusts staging desktop release settings (prerelease flag + updater JSON generation).
.github/workflows/build-desktop.yml Removes the release-triggered desktop build workflow entirely.

Comment thread .github/workflows/deploy-staging.yml
Comment thread .github/workflows/deploy-staging.yml
Comment thread .github/workflows/deploy-staging.yml
The create step used --prerelease while tauri-action set prerelease:
false, causing an inconsistent flip. Since staging is the production
environment, all desktop releases should be non-prerelease so the
Tauri auto-updater can find them via /releases/latest/.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: bfa867b7bfda
@FSM1 FSM1 merged commit 766710f into main Mar 27, 2026
25 checks passed
@FSM1 FSM1 deleted the chore/remove-build-desktop-workflow branch March 27, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants