Skip to content

Bump expensify-common to 2.0.10 - #360

Merged
tomekzaw merged 18 commits into
Expensify:mainfrom
nkdengineer:fix/41078
Jun 7, 2024
Merged

tomekzaw merged 18 commits into
Expensify:mainfrom
nkdengineer:fix/41078

Conversation

@nkdengineer

Copy link
Copy Markdown
Contributor

Details

Bump new expensify-common version to fix the phone number mention for live-markdown preview

Related Issues

Expensify/App#41078

Manual Tests

Linked PRs

Expensify/expensify-common#697

@nkdengineer
nkdengineer marked this pull request as ready for review June 3, 2024 05:10
Comment thread parser/index.ts Outdated
Comment thread parser/patches/expensify-common+2.0.4.patch Outdated
@tomekzaw tomekzaw changed the title bump expensify-common version Bump expensify-common version Jun 3, 2024
Comment thread parser/index.ts
Comment thread parser/package.json Outdated
@blimpich

blimpich commented Jun 5, 2024

Copy link
Copy Markdown

@hungvu193 is this PR ready for internal engineer review other than the version bump specified here? Lets keep this PR moving 🏃‍♂️‍➡️ 🙂

@hungvu193

Copy link
Copy Markdown

@hungvu193 is this PR ready for internal engineer review other than the version bump specified here? Lets keep this PR moving 🏃‍♂️‍➡️ 🙂

All good. Just a comment left that you mentioned 😄

@tomekzaw tomekzaw changed the title Bump expensify-common version Bump expensify-common to 2.0.10 Jun 6, 2024
@tomekzaw

tomekzaw commented Jun 6, 2024

Copy link
Copy Markdown
Contributor

I was able to eliminate expensify-common patch as well as remove patch-package from parser directory by using Babel (in particular, module:@react-native/babel-preset) to transpile the bundled file.

tomekzaw
tomekzaw previously approved these changes Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants