Repository navigation
[HOLD for payment 2024-06-21] [$250] mWeb - Chat - Quote markdown is not applied #43180
Description
Activity
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
Not a deploy blocker.
Offended PR Expensify/expensify-common#691
this is a new expected behavior:
This PR changes quote regex to enforce following space after >.
not followed by space won't be parsed as quote. In the multiple level quote context spaces between > signs are irreleventIf this is indeed the new expected behavior, then react-native-live-markdown needs to be updated such that it's using the new rule. Because right now it's confusing that the markdown processing in the composer is different than what we show in the chat. I think this is a legitimate blocker.
Reacted by Tomasz ZawadzkiThese are our options:
- ignore this inconsistency, let this 🐛 go to prod for the time being.
- revert [TS migration] Update
expensify-commonusage in NewDot #42387 - push forward Bump expensify-common to 2.0.10 react-native-live-markdown#360
- Include Recognise only blockquotes followed by space expensify-common#691 in react-native-live-markdown via a patch
in any event, both PRs need to be included in the same release, or we'll have this inconsistency
TBH I think we should have a full regression test on Expensify/react-native-live-markdown#360, so I'm not sure that we should push it forward and CP a package bump in App. So that leaves us with adding a patch or demoting this to NAB since we know the root cause and will have a fix out soon
Reacted by Rory Abraham31 remaining items
@luacmartins/ @mountiny Can we please assign a BZ member for payment
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.- changed the title
[-][$250] mWeb - Chat - Quote markdown is not applied[/-][+][HOLD for payment 2024-06-21] [$250] mWeb - Chat - Quote markdown is not applied[/+]on Jun 20, 2024 @anmurali, @luacmartins, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@anmurali, @luacmartins, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
Paid.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.82-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Quote markdown must be applied
Actual Result:
Quote markdown is not applied
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6503955_1717682774519.Screenrecorder-2024-06-06-19-33-11-542.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @anmurali