You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove patching class ExpensiMark with an object #41
Currently, we need to patch expensify-common/lib/ExpensiMark.js to convert class ExpensiMark into a single object because Hermes does not support ES Classes (facebook/hermes#685 (comment)).
In particular, we had to make the following changes:
Remove class keyword:
-export default class ExpensiMark {+export const ExpensiMark = {
Rename constructor to initializer:
- constructor() {+ initializer() {
Add commas after method definitions:
- }+ },
It would be better to use a Babel plugin to automatically convert class ExpensiMark into something that Hermes can deal with.
Activity
tomekzaw commentedon Jul 15, 2024
Done in #360