[No QA] Docs updates for E/A#97108 Add Attendees to bulk Edit multiple expenses - #99962
Conversation
Co-authored-by: Samran Ahmed <samranahm@users.noreply.github.com>
@samranahm bump on this! |
|
🤖 Web test steps verification results: ✅ pass I drove the flow on web to check the docs in this PR against real behavior, so
view run · no recording available |
|
@stephanieelliott I will review it today. |
|
|
||
| ## How to add attendees to multiple expenses at once | ||
|
|
||
| **Attendees** appears in the **Edit multiple expenses** panel when every selected expense belongs to a Workspace on the Control plan that has **Attendee tracking** turned on. [Learn how to enable Workspace Rules](/articles/new-expensify/workspaces/Workspace-Rules). |
There was a problem hiding this comment.
@MelvinBot please change "turned on" to "enabled".
+ **Attendees** appears in the **Edit multiple expenses** panel when every selected expense belongs to a Workspace on the Control plan that has **Attendee tracking** enabled. [Learn how to enable Workspace Rules](/articles/new-expensify/workspaces/Workspace-Rules).| 7. Click **Save**. | ||
| 8. Click **Save** again to apply your changes to every selected expense. | ||
|
|
||
| The **Attendees** field starts empty, even when the selected expenses already have attendees. The attendees you select replace the attendees on each selected expense, and each expense total is split evenly across the new attendee list. [Learn how to add attendees to a single expense](/articles/new-expensify/reports-and-expenses/Adding-Attendees). |
There was a problem hiding this comment.
@MelvinBot please delete this whole paragraph.
- The **Attendees** field starts empty, even when the selected expenses already have attendees. The attendees you select replace the attendees on each selected expense, and each expense total is split evenly across the new attendee list. [Learn how to add attendees to a single expense](/articles/new-expensify/reports-and-expenses/Adding-Attendees).|
|
||
| ## Why don't I see the Attendees field in Edit multiple? | ||
|
|
||
| **Attendees** only appears when every expense you selected sits on a Workspace that is on the Control plan and has **Attendee tracking** turned on under **Rules**. It is not available for invoices or for personal expenses that aren't on a Workspace. |
There was a problem hiding this comment.
@MelvinBot please change "turned on" to "enabled" here too.
|
@MelvinBot Apply the inline review comments. |
|
@stephanieelliott Looks like I don't have access to trigger MelvinBot. Could you take a look at the inline comments when you have a minute? |
|
Yep, I'll get it -- thanks @samranahm! |
|
@MelvinBot why is |
|
Who can summon MelvinBot here: Expensify employees, plus members of the Note that PR write access isn't the gate. To fix it: add In the meantime I'll pick up the inline review comments from you. Why there was no error messageThe authorization check runs before MelvinBot even looks for the mention, and an unauthorized request exits silently — no comment, no reaction, no emoji. That's deliberate (it stops any comment on any Expensify repo from generating noise), but it does mean an unauthorized user gets zero feedback. Worth filing a follow-up if we want a one-time "you don't have access" reply. |
This comment has been minimized.
This comment has been minimized.
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@eh2077 @twisterdotcom One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| The attendees you select are added to every selected expense. | ||
|
|
||
| Select 2 or more expenses, click **Selected**, and choose **Edit multiple** to set the same attendees on all of them in one step. Learn how to [edit multiple expenses at once](/articles/new-expensify/reports-and-expenses/Edit-Expenses). |
There was a problem hiding this comment.
Readability / redundancy: This paragraph restates the numbered steps directly above it (lines 34-38), duplicating the same instructions and diluting scannability (HELP_AUTHORING_GUIDELINES.md §1 "concise and actionable"). Keep only the cross-link sentence, e.g. "To set the same attendees on several expenses in one step, learn how to edit multiple expenses at once." and drop the step restatement.
|
|
||
| 1. From the navigation tabs (on the left on web, and at the bottom on mobile), select **Spend > Expenses**. | ||
| 2. Select 2 or more expenses. | ||
| 3. Choose **Selected**, then select **Edit multiple**. |
There was a problem hiding this comment.
Naming / deterministic writing: "Choose Selected" here is inconsistent with how the same UI element is referenced elsewhere (Edit-Expenses.md uses "Click Selected"). Per HELPSITE_NAMING_CONVENTIONS.md (Deterministic Writing Rule), use one consistent verb for the same control across articles.
|
|
||
| ## How to add attendees to multiple expenses at once | ||
|
|
||
| **Attendees** appears in the **Edit multiple expenses** panel when every selected expense belongs to a Workspace on the Control plan that has **Attendee tracking** enabled. [Learn how to enable Workspace Rules](/articles/new-expensify/workspaces/Workspace-Rules). |
There was a problem hiding this comment.
Naming violation: "Edit multiple expenses panel" doesn't match the UI label used everywhere else in this article ("Edit multiple", e.g. lines 41 and 87). Per HELPSITE_NAMING_CONVENTIONS.md (use the exact UI text, no paraphrasing), reference it as the "Edit multiple panel".
| ## Does editing attendees in bulk keep the attendees already on my expenses? | ||
|
|
||
| No. The attendees you select replace the ones already on selected expense. | ||
|
|
There was a problem hiding this comment.
Readability / grammar: "replace the ones already on selected expense" is ungrammatical. Use "replace the ones already on the selected expenses." (HELP_AUTHORING_GUIDELINES.md §1 clarity).
|
|
||
| --- | ||
|
|
||
| ## How to add attendees to multiple expenses at once |
There was a problem hiding this comment.
AI readiness / scope duplication: This section largely repeats the existing "How to edit multiple expenses at once" steps (lines 34-44) and the new bulk-attendees section in Adding-Attendees.md. Per HELP_AUTHORING_GUIDELINES.md §6 (avoid multi-feature/duplicated coverage) and §1 (one workflow), consider consolidating the bulk-attendees steps into the existing "edit multiple" section rather than adding a near-identical parallel section.
|
A preview of your ExpensifyHelp changes have been deployed to https://7055e5ca.helpdot.pages.dev ⚡️ Updated articles: |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bbb7ce379
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 4. Select **Attendees**, choose the attendees, and select **Save**. | ||
| 5. Select **Save** again to apply your changes to every selected expense. | ||
|
|
||
| The attendees you select are added to every selected expense. |
There was a problem hiding this comment.
Describe bulk attendee updates as replacements
When any selected expense already has attendees, the bulk action replaces its entire attendee list rather than appending to it: updateMultipleMoneyRequests assigns changes.attendees directly to transactionChanges.attendees, and the new FAQ in this same commit also says the existing attendees are replaced. Saying the selected attendees are “added” can therefore lead members to unintentionally remove existing attendees; state explicitly here that the selected list replaces the current list.
Useful? React with 👍 / 👎.
|
|
||
| ## Why don't I see the Attendees field in Edit multiple? | ||
|
|
||
| **Attendees** only appears when every expense you selected sits on a Workspace that is on the Control plan and has **Attendee tracking** enabled under **Rules**. It is not available for invoices or for personal expenses that aren't on a Workspace. |
There was a problem hiding this comment.
Account for unreported expenses in attendee availability
When unreported expenses are selected while the active workspace is a Control workspace with attendee tracking enabled, the field does appear: isBulkEditAttendeeTrackingEnabled explicitly evaluates unreported transactions using the bulk-edit workspace policy. This sentence incorrectly tells members that expenses not yet on a workspace can never use the field, so document the active-workspace fallback instead of excluding all personal/unreported expenses.
Useful? React with 👍 / 👎.
| ## How to add attendees to several expenses at once | ||
|
|
||
| 1. From the navigation tabs (on the left on web, and at the bottom on mobile), select **Spend > Expenses**. |
There was a problem hiding this comment.
State attendee eligibility before the bulk-edit steps
For a Collect workspace or a Control workspace with attendee tracking disabled, users following this newly added procedure cannot complete step 4 because the Attendees row is absent. The prerequisite is mentioned only in the separate article linked after these steps, so readers who land directly on this attendee article are led through an unavailable flow; place the applicable plan and attendee-tracking requirements before the procedure.
Useful? React with 👍 / 👎.
|
@stephanieelliott do you care about Codex's comments here or not? |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.4.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.77-4 🚀
Bundle Size Analysis (Sentry): |










Explanation of Change
Docs-only follow-up to #97108, which added an Attendees field to the Edit multiple expenses panel. The help site described bulk edit without it, so members had no documented way to know the field exists, when it appears, or how it behaves differently from editing attendees on a single expense.
Three files changed:
docs/articles/new-expensify/reports-and-expenses/Edit-Expenses.md## How to add attendees to multiple expenses at oncesection with the step-by-step flow.docs/articles/new-expensify/workspaces/Workspace-Rules.mddocs/articles/new-expensify/reports-and-expenses/Adding-Attendees.mdUI labels verified against the running app (web):
Spend > Expenses, the bulk-select button,Edit multiple, theEdit multiple expensespage title, andWorkspaces > [workspace] > More features > Rules > Attendee tracking(Control plan only — a Collect plan Workspace shows an upgrade prompt).Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: single#heading plus# FAQ, all sections##and task-based, bolded UI labels in sentence case, relative cross-links with descriptive anchor text, and no links inside numbered steps.Fixed Issues
$ #94313
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your change worked.
Offline tests
N/A — documentation only, no app code changed.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@samranahm, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.