[Payment due @truph01] Rillet follow ups - fixing bugs - #96444
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c182f54ed
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-07-21.at.10.29.33.movAndroid: mWeb ChromeScreen.Recording.2026-07-21.at.10.33.00.moviOS: HybridAppScreen.Recording.2026-07-21.at.10.35.42.moviOS: mWeb SafariScreen.Recording.2026-07-21.at.10.37.02.movMacOS: Chrome / SafariScreen.Recording.2026-07-21.at.10.21.02.movScreen.Recording.2026-07-21.at.10.22.44.mov |
|
🎯 @truph01, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.42-0 🚀
|
|
🤖 Help site review: no changes required. I reviewed the changes in this PR against the help site content under Why:
@s77rt, please confirm this assessment matches the current behavior. If you believe a user-facing help article should exist or be updated for the Rillet export configuration flow, let me know and I'll draft one. |
|
🤖 Payment issue created: #96787 |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.42-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #96413
$ #96414
$ #96417
PROPOSAL:
Tests
Test 1:
Screen.Recording.2026-07-18.at.12.44.40.PM.mov
Test 2:
Screen.Recording.2026-07-18.at.12.56.35.PM.mov
Test 3:
(Note: the background may look different, this is expected for now)
Screen.Recording.2026-07-18.at.3.56.26.PM.mov
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari