Rillet - After refreshing per-card account export, default label and background change

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.36-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #95562
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Workspace is connected to Rillet.
• Workspace has direct feed.
• Workspace has at least one Expensify Card.
• Set Company card account to 21110 Brex Credit Card US in Rillet Export settings.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Click Export.
4. Enable Configure exporting to multiple accounts.
5. Click Per-card account.
6. Click Expensify Card.
7. Open any card.
   → Default label is shown next to Credit Card UK.
8. Refresh the page.

Expected Result:

• Default label will be next to Credit Card UK.
• Accounting will remain as the background.

Actual Result:

• Default label changes to Credit Card US.
• The background changes to Company cards.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7210796_1784305164279.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7210796

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7097dbd2358bb791908ccc75bb194e5bde8e7eb7e7033f8cbc1627415f462527

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #95562

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

Both symptoms (default label moves to Credit Card US, and the RHP background flips from Accounting to Company cards) have a single root cause: the per-card export route edit/export (DYNAMIC_COMPANY_CARD_EXPORT) is only registered under the Company Cards navigation chain, never under the Accounting / Rillet chain.

• In the linking config, DYNAMIC_COMPANY_CARD_EXPORT is nested only inside the company-cards block: config.ts:845, and its RHP↔central-pane relation lists it only under SCREENS.WORKSPACE.COMPANY_CARDS — it is absent from SCREENS.WORKSPACE.ACCOUNTING.ROOT: WORKSPACE_TO_RHP.ts:352.
• When reached in‑app, the page inherits feed from the parent .../card-account/:feed route and only appends cardID: RilletCardAccountCardList.tsx:93.
• On refresh, the URL .../accounting/rillet/export/card-account/<feed>/edit/export?cardID=X can't be re-parsed, because edit/export is only known under the company-cards prefix. So the deeplink re-parents the RHP under Company Cards (background bug) and loses the feed/cardID params.
• With feed/cardID lost, companyCard becomes undefined in DynamicWorkspaceCompanyCardAccountSelectCardPage.tsx:45-52, so getExportMenuItem's companyCard?.bank is falsy and the default account falls back from the per‑program account (UK) to the global creditCardAccountCode (US) — painting "(default)" on the wrong account: utils.tsx:383-413.

So UK (before refresh) is correct; US (after refresh) is the erroneous fallback.

What changes do you think we should make in order to solve the problem?

Make the edit/export page reachable from the Accounting/Rillet flow on a cold load so feed + cardID survive a refresh and the RHP re-parents under Accounting:

1. Add SCREENS.WORKSPACE.ACCOUNTING.RILLET_CARD_ACCOUNT_CARD_LIST (or the export screen itself) so the export route resolves under the Accounting central pane, not only Company Cards, in WORKSPACE_TO_RHP.ts. Note the route already declares RILLET_CARD_ACCOUNT_CARD_LIST as an entryScreens entry in ROUTES.ts:806-809, so the linking config is the missing piece.
2. Ensure the deeplink for the Rillet path (.../card-account/:feed/edit/export) is registered so getStateFromPath can rebuild the base chain with feed/cardID intact.
3. As defensive hardening, guard getExportMenuItem so that when companyCard is undefined it does not confidently mark a fallback account as the default.

What alternative solutions did you explore? (Optional)

Since this is a new-feature deploy blocker from #95562, reverting PR #95562 is a valid quick option if a targeted routing fix can't land within the deploy-blocker window.

Related issue & confidence

• Likely the same root cause: Rillet - Back button closes RHP after refreshing Card program account & Per-card account #96414 ("Rillet - Back button closes RHP after refreshing Card program account & Per-card account") — another refresh/deeplink navigation bug in the same Rillet per-card export pages.
• Confidence: Medium-high. The routing gap is confirmed directly from the linking config. The one link not verified at runtime is that route.params.feed/cardID are actually empty after refresh (vs. Rillet config simply not being hydrated yet). Both produce the identical US fallback, but since the background also changes on the same refresh, the routing root cause is by far the most likely. To confirm: after refresh, inspect route.params on the export page — if feed/cardID are missing, it's the routing bug.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/96417) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[MelvinBot]

🔍 Investigation Summary

Classification: Frontend bug (fix required in Expensify/App)
Causing PR: #95562 - "Add Rillet integration multiple account export pages" by @s77rt (High confidence)
Related Issues: #96414 (another Rillet refresh/deeplink navigation bug in the same pages — almost certainly the same root cause)

Recommendation: ROLL FORWARD (targeted fix)

Both symptoms come from one self-contained routing gap in the new-feature PR #95562. A targeted fix is smaller and safer than reverting a 44-file feature, and it also resolves the related blocker #96414. Revert remains a valid fallback if a fix can't land in the deploy window.

Assigned: @s77rt (PR author), @truph01 and @lakchote (approving reviewers) from the sole causing PR #95562
Labels: No changes. DeployBlockerCash is kept — this is an App-caused staging regression whose fix lives in Expensify/App. There is no DeployBlocker (Web) label to remove, and the two blocker labels are never removed simultaneously.

📋 Detailed Analysis

Evidence

• PR Add Rillet integration multiple account export pages #95562 ("Add Rillet integration multiple account export pages", merged 2026-07-16, +1209/-30 across 44 files) is item Reorder arguments so that path and keyPattern are next to each other #30 in the current StagingDeployCash Deploy Checklist: New Expensify 2026-07-16 #96356 and is checked off (on staging). The entire Rillet multiple-account export feature — the affected pages, routes, and the getExportMenuItem Rillet branch — is introduced by this PR, so it is the only candidate. The bug is staging-only / N/A in prod because the feature does not exist in production.
• The two symptoms (default label flips UK→US, and RHP background flips Accounting→Company cards) share a single root cause: the per-card export screen DYNAMIC_COMPANY_CARD_EXPORT (path edit/export) is only registered under the Company Cards navigation chain, never under the Accounting / Rillet chain.

Verification (independently confirmed against the code at e4ae3a2)

• src/libs/Navigation/linkingConfig/config.ts:845 — DYNAMIC_COMPANY_CARD_EXPORT is nested only inside the company-cards block.
• src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts — under SCREENS.WORKSPACE.ACCOUNTING.ROOT (list at line 46) the Rillet chain includes RILLET_CARD_ACCOUNT_CARD_LIST (line 214) but not DYNAMIC_COMPANY_CARD_EXPORT. That screen is listed only under SCREENS.WORKSPACE.COMPANY_CARDS (line 352).
• The PR diff confirms these are new: WORKSPACE_TO_RHP.ts was edited to add RILLET_CARD_ACCOUNT_CARD_LIST under ACCOUNTING.ROOT (hunk @@ -208,6 +208,10 @@) while DYNAMIC_COMPANY_CARD_EXPORT was left out of that block.
• Inconsistency proving the gap: src/ROUTES.ts:806-809 declares WORKSPACE_COMPANY_CARD_EXPORT (edit/export) with entryScreens: [DYNAMIC_COMPANY_CARD_DETAILS, RILLET_CARD_ACCOUNT_CARD_LIST] — the route builder knows the page can be entered from the Rillet list — but the linking config does not register it under Accounting, so getStateFromPath cannot re-parent it there on a cold load.
• In-app navigation only appends cardID and relies on the inherited feed base path: src/pages/workspace/accounting/rillet/export/RilletCardAccountCardList.tsx:93 (appendParam(createDynamicRoute(DYNAMIC_ROUTES.WORKSPACE_COMPANY_CARD_EXPORT.path), 'cardID', ...)).

Root Cause

On refresh, the URL .../accounting/rillet/export/card-account/<feed>/edit/export?cardID=X cannot be parsed under the Rillet chain because edit/export is only known beneath the company-cards prefix. The deeplink therefore re-parents the RHP under Company Cards (background symptom) and loses the feed/cardID route params. With those params gone, companyCard becomes undefined in src/pages/workspace/companyCards/DynamicWorkspaceCompanyCardAccountSelectCardPage.tsx:45-52 (card = allBankCards?.[cardID] with feed/cardID empty). In getExportMenuItem at src/pages/workspace/companyCards/utils.tsx:383:

const cardProgramAccountCode = (companyCard?.bank ? cardProgramsUsingCustomAccounts?.[companyCard.bank] : undefined) ?? creditCardAccountCode;

with companyCard undefined, companyCard?.bank is falsy, so the per-program account (Credit Card UK) is skipped and the code falls back to the global creditCardAccountCode (21110 Brex Credit Card US) — mislabeling US as "(default)". So UK before refresh is correct; US after refresh is the erroneous fallback. Both symptoms are one bug.

Suggested targeted fix

1. Register DYNAMIC_COMPANY_CARD_EXPORT (the edit/export page) under the Accounting/Rillet chain so it survives a cold load:
   • add it to SCREENS.WORKSPACE.ACCOUNTING.ROOT in WORKSPACE_TO_RHP.ts, and
   • register the Rillet path in config.ts so getStateFromPath rebuilds the base chain with feed/cardID intact and the RHP re-parents under Accounting.
2. Defensive hardening: guard getExportMenuItem so that when companyCard is undefined it does not confidently mark the global-fallback account as "(default)".

This fix also addresses #96414 (same refresh/deeplink navigation gap in the same Rillet pages).

Note for reviewers

Separately, @lakchote flagged during review that the per-card override stores the account code while the backend resolves that NVP as an account id, which can break export for cards with an override. That is a distinct backend/data concern, not the cause of this label/background bug, but worth tracking alongside the fix.