Rillet - Per-card account is shown when all cards are unassigned, which opens an empty list

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.36-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #95562
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Log in with Expensifail account.
• Workspace is connected to Rillet.
• Workspace has Wells Fargo direct feed with unassigned card.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Click Export.
4. Enable Configure exporting to multiple accounts.
5. Click Per-card account.
6. Click on the card feed name.

Expected Result:

Per-card account should be hidden when all cards are unassigned.

Actual Result:

Per-card account is shown when all cards are unassigned, which opens an empty list.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7210785_1784304283604.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7210785

Issue Owner

Current Issue Owner: @truph01

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/cba3abb95af5bbde3a6d92ce70df5c5d2f37ae99a43cca8584078fe12065569f

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #95562

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On a Rillet-connected workspace, Accounting → Export → Configure exporting to multiple accounts → Per-card account lists a card feed (e.g. a Wells Fargo direct feed) even when that feed has no assigned cards. Tapping the feed opens an empty list. The per-card entry should be hidden when all of a feed's cards are unassigned.

What is the root cause of that problem?

The per-card account page renders a row for every card feed unconditionally, without checking whether the feed has any assigned/active cards:

• RilletCardAccount.tsx:51 — Object.values(cardFeeds ?? {}).map(...) iterates the combined feeds from settings. A direct feed with oAuthAccountDetails but no assigned cards still appears in cardFeeds (see the feed-visibility comment in CardFeedUtils.ts:440-451), so its row is drawn even with zero cards.
• Tapping that row navigates to RilletCardAccountCardList.tsx:67, which maps over cardList (filtered to active/assigned cards via useCardsList → filterInactiveCards). With only unassigned cards, cardList is empty, so nothing but the description renders → the "empty list".

The Per-card account row on the export page itself is gated only on Object.keys(cardFeeds).length > 0 (RilletExportPage.tsx:125), never on whether any assigned cards actually exist.

This was introduced by the new-feature PR #95562.

What changes do you think we should make in order to solve the problem?

Only surface feeds/entries that have at least one assigned card:

1. In RilletCardAccount.tsx, skip rendering a feed row when that feed has no assigned cards. The count can be derived from cardLists using the same feed-matching logic as findMatchingCards in CardFeedUtils.ts:475 (match by card.bank/card.fundID). Consider exporting a small getAssignedCardCountPerFeed helper alongside getCardsUsingCustomExportCount.
2. In RilletExportPage.tsx:153-165, hide the whole Per-card account menu row when no feed has any assigned cards (i.e. total assigned-card count across feeds is 0), so the entry point disappears entirely in the all-unassigned case.

Notes & alternatives considered

• The Card program account row operates at the feed/program level and is unaffected — it should keep showing as long as feeds exist. Scope the fix to the per-card path only.
• A narrower alternative is to only apply change (1) (filter empty feeds in RilletCardAccount). That prevents the empty list per-feed, but if all feeds are unassigned the Per-card account row on the export page would still open a page with just a description and no rows — hence change (2) is recommended too to fully match the expected result.
• useCardsList/useCardsLists already exclude inactive cards (filterInactiveCards), so "no assigned cards" is well-defined as "empty filtered list for that feed".

What alternative solutions did you explore?

Guarding navigation (blocking the tap when the list is empty) was considered but rejected — it leaves a dead-end row visible, which contradicts the expected behavior of hiding the entry.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/96413) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[truph01]

Please assign me