[Payment due @abzokhattab] Add Greek (el) as beta locale by roryabraham · Pull Request #95655 · Expensify/App

roryabraham · 2026-07-09T02:47:22Z

Explanation of Change

Adds Greek (el) as a new beta locale. Registers el in LOCALES.ts, wires runtime loading in IntlStore (translations + date-fns locale), maps Apple Sign In's el_GR locale, loads Greek Intl.ListFormat polyfill data, adds a Greek translation prompt/glossary, and generates src/languages/el.ts from en.ts (6,048 strings, zero translation failures). Excludes the generated file from ESLint and cspell, matching every other beta locale's pattern.

This lands the infra prerequisite for Add Greek as a language to E/App, part of the translator-hiring epic #504749. Greek ships as beta: AI-generated, unaudited, no localized emoji keywords — same limitations as de/fr/ja/etc. Promoting to fully-supported happens after expert audit in a follow-up.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/657039
PROPOSAL:

Tests

Start the web dev server.
Sign in and go to Settings > Preferences > Language.
Confirm Ελληνικά appears in the language list.
Select Ελληνικά. Confirm the UI switches to Greek and the "translations generated automatically" hint shows under the Language row.
Navigate to Home, Inbox, and other Account tabs. Confirm nav labels and settings render in Greek with no raw English fallback, no undefined/[object Object], and no missing-key errors.
Switch back to English. Confirm the list re-sorts correctly and English strings are unaffected.

Verify that no errors appear in the JS console

Offline tests

N/A — locale files are bundled at build time; no network-dependent behavior changes.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — web-only locale infra change, no native platform code touched.

Android: mWeb Chrome

N/A — see MacOS: Chrome / Safari for representative web coverage.

iOS: Native

N/A — web-only locale infra change, no native platform code touched.

iOS: mWeb Safari

N/A — see MacOS: Chrome / Safari for representative web coverage.

MacOS: Chrome / Safari

Add el to BETA_LOCALES with Ελληνικά display name. Co-authored-by: Cursor <cursoragent@cursor.com>

Add el loader to IntlStore (date-fns/locale/el), map el to Apple Sign In's el_GR locale, and load el Intl.ListFormat polyfill data. Note: src/languages/el.ts does not exist yet; typecheck passes once added in a follow-up commit. Co-authored-by: Cursor <cursoragent@cursor.com>

Add glossary and tone rules for Greek to guide translation generation (formal register, gender/case agreement). Co-authored-by: Cursor <cursoragent@cursor.com>

Generate src/languages/el.ts from en.ts via generateTranslations.ts, using the base and Greek-specific prompts. 6,048 strings translated with zero failures. Co-authored-by: Cursor <cursoragent@cursor.com>

Match the existing pattern for other AI-generated locale files; still type-checked, just not linted as hand-authored source. Co-authored-by: Cursor <cursoragent@cursor.com>

Match the existing ignorePaths pattern for other beta locales; without this, CI spell-check fails on ~10k lines of Greek text. Co-authored-by: Cursor <cursoragent@cursor.com>

Ελληνικά in LOCALES.ts's LOCALE_TO_LANGUAGE_STRING is hand-written (not covered by ignorePaths), so it needs a words entry like the other locales' native display names (Deutsch, Français, etc.). Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham · 2026-07-09T02:56:36Z

CI failed on two unrelated, pre-existing test failures (both look like date/time-bomb bugs, not caused by this PR's Greek locale changes):

test (job 3): tests/unit/ReportSecondaryActionUtilsTest.ts › getSecondaryAction › should include SUBMIT option for admin with only pending transactions — expected true, got false. Run
test (job 8): tests/actions/ReportPreviewActionUtilsTest.ts › getReportPreviewAction › canSubmit should return true for expense preview report with only pending transactions — expected "submit", got "view". Run

Both tests use a hardcoded transaction created: '2025-01-01' and appear to depend on the gap between that fixed date and the real current date. Confirmed unrelated to this PR:

Reproduces locally on this branch with today's real system date (npx jest tests/unit/ReportSecondaryActionUtilsTest.ts -t "should include SUBMIT option for admin with only pending transactions").
main's own last test.yml run (2026-07-01) was green; the regression appeared sometime after that, before this PR's diff (which only touches src/CONST/LOCALES.ts, src/languages/IntlStore.ts, AppleSignInLocales.ts, polyfillListFormat.ts, translation prompts, and the generated el.ts — nothing in ReportSecondaryActionUtils/ReportPreviewActionUtils).

Tracked in Fix flaky test ReportSecondaryActionUtilsTest/ReportPreviewActionUtilsTest.

github-actions · 2026-07-09T03:25:01Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

Expensify Neue/Mono/New Kansas and the emoji fonts only cover Latin script and emoji glyphs. With no generic fallback at the end of the web font stack, glyphs missing from all of them (e.g. Greek) fell through to the browser's own default font, which is a serif font. Append a standard system font stack after the emoji fonts so uncovered scripts render in a sans-serif system font instead. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-15T06:16:58Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

main gained new copy (Agents, Rillet, onboarding, card statuses, etc.) since el.ts was generated, breaking typecheck. Regenerate incrementally against the pre-merge branch tip and manually fix Rillet export value keys the translator flattened incorrectly. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-15T07:05:18Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2026-07-15T07:08:09Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/LOCALES.ts	`100.00% <ø> (ø)`
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx	`83.11% <100.00%> (ø)`
...ponents/Search/SearchRouter/SearchRouterHelpers.ts	`95.55% <100.00%> (+0.10%)`	⬆️
...ts/SignInButtons/AppleSignIn/AppleSignInLocales.ts	`0.00% <ø> (ø)`
src/libs/EmojiTrie.ts	`96.00% <100.00%> (ø)`
src/libs/SearchQueryUtils.ts	`87.30% <100.00%> (ø)`
src/libs/StringUtils/index.ts	`83.60% <100.00%> (+1.15%)`	⬆️
src/libs/filterArrayByMatch.ts	`97.72% <100.00%> (ø)`
src/pages/inbox/sidebar/NavigationTabBarAvatar.tsx	`91.30% <100.00%> (ø)`
src/libs/IntlPolyfill/polyfillListFormat.ts	`20.00% <0.00%> (-1.43%)`	⬇️
... and 2 more
... and 7 files with indirect coverage changes

dubielzyk-expensify · 2026-07-15T22:25:20Z

Tested again and that's looking a lot better 👍 cc @Expensify/design for viz

dubielzyk-expensify · 2026-07-15T22:27:53Z

Wonder if we could shrink this as it's messing with me:

Account is also weird:

I guess it's part of the RSS so it makes sense, but I kinda would still assume the announcement type would be translated. I think we're removing it though so it's fine

dubielzyk-expensify · 2026-07-15T22:30:35Z

Serif font found here:

Same with description on workspace overview:

And domain RHP:

react-native-render-html keeps only the first whitelisted face, so Greek in RenderHTML lost our system sans-serif fallbacks and rendered as serif. Remap brand faces to full platform stacks via fallbackFonts. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-07-16T01:45:29Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

roryabraham · 2026-07-16T04:49:05Z

@dubielzyk-expensify I think that newest AdHoc build should fix the pieces of serif font you pointed out. However, I'd love your advice on how to fix the LHN word wrapping issues we were seeing. It sounds like there's no shorter word that would be a natural fit for either Inbox or Account, so that gives us a few options:

Decrease the font size for that text in Greek
a. For just the items that are too long, OR
b. For all LHN items for consistency
Widen the LHN. It's 72 pixels and there's kind of a lot of layout math that depends on that. Medium-to-high-effort to widen it to say 80 pixels, but certainly not impossible:
a. Widen it just for Greek, OR
b. Widen it for all locales
Embrace the wrapping:
1. Make sure that Account wraps like Inbox
2. Insert a zero-width character in the middle of each, so that even though they'll take up two lines, at least we won't have just 1 or 2 characters on their own line.

Fill missing el.ts keys from main and satisfy ESLint naming on the HTML font fallback map key for the CSS sans-serif generic family. Co-authored-by: Cursor <cursoragent@cursor.com>

abzokhattab · 2026-07-29T20:53:46Z

NAB: i would recommend adding unit tests for the newly added removeZeroWidthCharacters and normalizeForMatch functions in this util file

abzokhattab

The changes look good to me

abzokhattab · 2026-07-29T21:00:18Z

lets fix the failing pipeline

melvin-bot · 2026-07-29T21:00:32Z

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-29T21:00:34Z

🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/657039.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

roryabraham · 2026-07-30T05:32:53Z

@MelvinBot please fix failing typecheck in this pull request.

MelvinBot · 2026-07-30T05:47:40Z

🤖 Fixed the failing typecheck and pushed to this branch.

Root cause: main added three new keys to the gps section of src/languages/en.ts — edit, editStop, totalDistance — after el.ts was generated. The typecheck runs against the PR merged with main, so the generated Greek file was missing those keys and el.ts failed to satisfy TranslationDeepObject<typeof en> (TS2739). It passed on the raw branch head, which is why it looked confusing.

Fix:

Merged latest main into the branch (brings the updated en.ts).
Added the three Greek translations to gps in src/languages/el.ts, matching existing usage (edit → Επεξεργασία from common.edit, waypoint "stop" → στάσης from distance.addStop, totalDistance → Συνολική απόσταση from distance.odometer).

npm run typecheck (tsc) now passes locally with no el.ts errors.

chuckdries · 2026-08-03T17:13:15Z

Types still failing

OSBotify · 2026-08-03T21:21:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-03T21:23:06Z

🚧 chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-08-03T21:34:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95655.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a6f90e09e32-ecf5fdc-17cdc47561047243cd04ca88af44b709fb187c85/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a6f90e0-ecf5fdc-5a5e360a19f2b569ba83f51efab35eb6cc07b776/index.html

Web 🕸️
https://95655.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-03T23:50:29Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.4.49-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-08-03T23:57:32Z

Help site review — docs update required ✅

This PR adds Greek (Ελληνικά) as a new beta locale. That is user-facing, and one help article documents the set of supported languages:

docs/articles/new-expensify/settings/Account-Settings.md has a Supported Languages list that was missing Greek.

The rest of the diff (locale registration, font/emoji/Intl polyfill wiring, generated src/languages/el.ts) is internal infrastructure with no help-site impact.

Draft PR: #97739

I added Greek (Ελληνικά) to the Supported Languages list, matching the existing English name (Native name) format. I verified against the live New Expensify web UI (Account > Preferences > Language) that Ελληνικά now appears in the language picker, so the native name and its list position match current behavior.

@MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

jponikarchuk · 2026-08-04T10:59:31Z

Deploy Blocker #97781 was identified to be related to this PR.

melvin-bot · 2026-08-04T21:41:56Z

🤖 Payment issue created: #97830

OSBotify · 2026-08-04T21:43:46Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.49-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

roryabraham and others added 7 commits July 8, 2026 18:17

feat(i18n): register Greek locale

7158ae9

Add el to BETA_LOCALES with Ελληνικά display name. Co-authored-by: Cursor <cursoragent@cursor.com>

feat(i18n): add Greek translation prompt

dd01538

Add glossary and tone rules for Greek to guide translation generation (formal register, gender/case agreement). Co-authored-by: Cursor <cursoragent@cursor.com>

feat(i18n): generate Greek translations

07e6750

Generate src/languages/el.ts from en.ts via generateTranslations.ts, using the base and Greek-specific prompts. 6,048 strings translated with zero failures. Co-authored-by: Cursor <cursoragent@cursor.com>

chore(lint): exclude generated el.ts from ESLint

27aa359

Match the existing pattern for other AI-generated locale files; still type-checked, just not linted as hand-authored source. Co-authored-by: Cursor <cursoragent@cursor.com>

chore(spell): exclude generated el files from cspell

75992d1

Match the existing ignorePaths pattern for other beta locales; without this, CI spell-check fails on ~10k lines of Greek text. Co-authored-by: Cursor <cursoragent@cursor.com>

melvin-bot Bot assigned roryabraham Jul 9, 2026

Merge remote-tracking branch 'origin/main' into rory-657039-greek-locale

1b875f0

This comment has been minimized.

Sign in to view

dubielzyk-expensify self-requested a review July 13, 2026 23:01

This comment has been minimized.

Sign in to view

roryabraham and others added 2 commits July 14, 2026 23:46

Merge remote-tracking branch 'origin/main' into rory-657039-greek-locale

241fdc4

This comment has been minimized.

Sign in to view

roryabraham and others added 2 commits July 15, 2026 21:50

Merge remote-tracking branch 'origin/main' into rory-657039-greek-locale

ff9a044

fix(i18n): sync Greek strings after main merge

113cf0f

Fill missing el.ts keys from main and satisfy ESLint naming on the HTML font fallback map key for the CSS sans-serif generic family. Co-authored-by: Cursor <cursoragent@cursor.com>

abzokhattab reviewed Jul 29, 2026

View reviewed changes

abzokhattab approved these changes Jul 29, 2026

View reviewed changes

melvin-bot Bot requested a review from chuckdries July 29, 2026 21:00

melvin-bot Bot changed the title ~~Add Greek (el) as beta locale~~ [Payment due @abzokhattab] Add Greek (el) as beta locale Jul 29, 2026

roryabraham assigned MelvinBot Jul 30, 2026

roryabraham added 2 commits August 3, 2026 13:30

Merge remote-tracking branch 'origin/main' into rory-657039-greek-locale

c73b0a0

Add missing Greek translations after merge

061f68c

roryabraham force-pushed the rory-657039-greek-locale branch from 390529d to 061f68c Compare August 3, 2026 20:41

chuckdries approved these changes Aug 3, 2026

View reviewed changes

chuckdries merged commit a6f90e0 into main Aug 3, 2026
42 checks passed

chuckdries deleted the rory-657039-greek-locale branch August 3, 2026 21:06

OSBotify mentioned this pull request Aug 3, 2026

Deploy Checklist: New Expensify 2026-08-03 #97732

Closed

77 tasks done

MelvinBot mentioned this pull request Aug 3, 2026

[No QA] Docs updates for E/A#95655 Add Greek to Supported Languages list #97739

Merged

applause-bot Bot mentioned this pull request Aug 4, 2026

[Due for payment 2026-08-21] Spends - Expense date keep Greek spelling after changing the language to English #97781

Closed

4 of 7 tasks

melvin-bot Bot mentioned this pull request Aug 4, 2026

[Due for payment 2026-08-11] Payment issue for E/App PR#95655 #97830

Closed

MelvinBot mentioned this pull request Aug 18, 2026

[Due for payment 2026-08-25] [$250] German user cannot save a Per Diem (gets the "Please choose a time that is at least one minute in the future." error) #97796

Closed

2 of 7 tasks

Conversation

roryabraham commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

roryabraham commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jul 15, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jul 15, 2026

Uh oh!

codecov Bot commented Jul 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

dubielzyk-expensify commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Jul 15, 2026

Uh oh!

dubielzyk-expensify commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

This comment has been minimized.

roryabraham commented Jul 16, 2026

Uh oh!

abzokhattab Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

abzokhattab left a comment

Choose a reason for hiding this comment

Uh oh!

abzokhattab commented Jul 29, 2026

Uh oh!

melvin-bot Bot commented Jul 29, 2026

Uh oh!

melvin-bot Bot commented Jul 29, 2026

Uh oh!

roryabraham commented Jul 30, 2026

Uh oh!

MelvinBot commented Jul 30, 2026

Uh oh!

chuckdries commented Aug 3, 2026

Uh oh!

Uh oh!

OSBotify commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

OSBotify commented Aug 3, 2026

Uh oh!

MelvinBot commented Aug 3, 2026

Help site review — docs update required ✅

Uh oh!

jponikarchuk commented Aug 4, 2026

Uh oh!

melvin-bot Bot commented Aug 4, 2026

Uh oh!

OSBotify commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

roryabraham commented Jul 9, 2026 •

edited

Loading

codecov Bot commented Jul 15, 2026 •

edited by github-actions Bot

Loading

dubielzyk-expensify commented Jul 15, 2026 •

edited

Loading