Skip to content

[No QA] Docs updates for E/A#95655 Add Greek to Supported Languages list - #97739

Merged
roryabraham merged 1 commit into
mainfrom
melvin-docs-greek-locale
Aug 4, 2026
Merged

roryabraham merged 1 commit into
mainfrom
melvin-docs-greek-locale

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs update for #95655

#95655 adds Greek (Ελληνικά) as a new beta locale in New Expensify. The Supported Languages list in the Account Settings help article did not include Greek, so this PR adds it.

What changed

  • docs/articles/new-expensify/settings/Account-Settings.md — added Greek (Ελληνικά) to the Supported Languages list, using the same English name (Native name) format as the existing entries. Placed after Portuguese to match where Ελληνικά appears in the live Language picker.

Verification

  • Confirmed in the live New Expensify web UI (Account > Preferences > Language) that Ελληνικά now appears in the language list, between Português (BR) and 中文 (简体).
  • Native language name Ελληνικά matches the exact label rendered in the UI.

Source PR

#95655 — [Payment due @abzokhattab] Add Greek (el) as beta locale


@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 3, 2026
@MelvinBot MelvinBot self-assigned this Aug 3, 2026
@abzokhattab

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review August 4, 2026 01:27
@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Marked this PR as ready for review.

Before flipping it, I verified the change against the live New Expensify web UI (Account > Preferences > Language). The live picker order is:

… Português (BR) → Ελληνικά → 中文 (简体) → 日本語

The diff places Greek (Ελληνικά) immediately after Portuguese (Português – Brasil) in the Supported Languages list — matching where it renders in the live picker. All checks are passing.

Note: the pre-existing Japanese/Chinese ordering in the docs list (Japanese listed before Chinese) doesn't match the live UI order, but that's untouched by this PR and out of scope here.

@abzokhattab

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot melvin-bot Bot changed the title Docs updates for E/A#95655 Add Greek to Supported Languages list [Payment due @abzokhattab] Docs updates for E/A#95655 Add Greek to Supported Languages list Aug 4, 2026
@melvin-bot

melvin-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, tightly scoped change: it adds Greek (Ελληνικά) to the Supported Languages list in the Account Settings help article, reflecting the new Greek beta locale added in #95655. The change is minimal, accurate, and consistent with the existing list.

Scores Summary

  • Readability: 9/10 - The added line follows the exact "English name (Native name)" pattern used by every other entry in the list. Nothing to parse or interpret.
  • AI Readiness: 8/10 - The added content uses the full, UI-exact language label and native script, which aids retrieval. It sits under a pre-existing heading, so the change introduces no new metadata or heading concerns.
  • Style Compliance: 9/10 - Matches the established list format exactly, uses the precise native label Ελληνικά as rendered in the UI, and correctly places Greek to mirror the live Language picker order (after Portuguese). No terminology or UI-referencing violations in the added line.

Key Findings

  • The added line adheres to the existing list convention exactly (English (Native)), so it reads consistently and matches the live UI label.
  • Placement after Portuguese is intentional and verified against the in-product Language picker, per the PR description.
  • Positive: this is a clean, low-risk documentation sync that keeps the Supported Languages list current with the product.
  • Note (pre-existing, not part of this diff, so not scored): the surrounding article uses multiple top-level headings for its sections, which conflicts with the single-title-heading rule in HELP_AUTHORING_GUIDELINES.md Section 4, and the frontmatter lacks internalScope. These are out of scope for this PR.

Recommendations

  • No changes required for this PR. The addition is correct and ready.
  • Optional future cleanup (separate PR): align the article with the single-title-heading rule, convert section headings to task-based phrasing, and add internalScope to the frontmatter.

Files Reviewed

  • docs/articles/new-expensify/settings/Account-Settings.md - Approved. One line added (Greek (Ελληνικά)); consistent with list format and verified against the live UI.

Note: This change is a single-line addition; no inline comments were necessary.

@roryabraham

Copy link
Copy Markdown
Contributor

Updating the PR title because no additional payment should be due to @abzokhattab for this PR

@roryabraham roryabraham changed the title [Payment due @abzokhattab] Docs updates for E/A#95655 Add Greek to Supported Languages list Docs updates for E/A#95655 Add Greek to Supported Languages list Aug 4, 2026
@roryabraham
roryabraham merged commit c4c08d1 into main Aug 4, 2026
19 checks passed
@roryabraham
roryabraham deleted the melvin-docs-greek-locale branch August 4, 2026 02:04
@OSBotify OSBotify mentioned this pull request Aug 4, 2026
52 tasks done
@OSBotify

OSBotify commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.50-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@m-natarajan

Copy link
Copy Markdown

@abzokhattab @roryabraham @stephanieelliott NO QA steps, OK to checkoff this one?

@stephanieelliott

Copy link
Copy Markdown
Contributor

Yep! No QA on this one

@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.50-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#95655 Add Greek to Supported Languages list [No QA] Docs updates for E/A#95655 Add Greek to Supported Languages list Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants