Repository navigation
[No QA] Docs updates for E/A#95655 Add Greek to Supported Languages list - #97739
Conversation
Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
|
@MelvinBot mark this PR as ready for review |
|
✅ Marked this PR as ready for review. Before flipping it, I verified the change against the live New Expensify web UI (Account > Preferences > Language). The live picker order is:
The diff places Greek (Ελληνικά) immediately after Portuguese (Português – Brasil) in the Supported Languages list — matching where it renders in the live picker. All checks are passing. Note: the pre-existing Japanese/Chinese ordering in the docs list (Japanese listed before Chinese) doesn't match the live UI order, but that's untouched by this PR and out of scope here. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single, tightly scoped change: it adds Greek (Ελληνικά) to the Supported Languages list in the Account Settings help article, reflecting the new Greek beta locale added in #95655. The change is minimal, accurate, and consistent with the existing list. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This change is a single-line addition; no inline comments were necessary. |
|
Updating the PR title because no additional payment should be due to @abzokhattab for this PR |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.50-0 🚀
|
|
@abzokhattab @roryabraham @stephanieelliott NO QA steps, OK to checkoff this one? |
|
Yep! No QA on this one |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.50-3 🚀
Bundle Size Analysis (Sentry): |
Docs update for #95655
#95655 adds Greek (Ελληνικά) as a new beta locale in New Expensify. The Supported Languages list in the Account Settings help article did not include Greek, so this PR adds it.
What changed
docs/articles/new-expensify/settings/Account-Settings.md— addedGreek (Ελληνικά)to the Supported Languages list, using the sameEnglish name (Native name)format as the existing entries. Placed after Portuguese to match where Ελληνικά appears in the live Language picker.Verification
Ελληνικάmatches the exact label rendered in the UI.Source PR
#95655 — [Payment due @abzokhattab] Add Greek (el) as beta locale
@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.