Create GPS expenses using captured data by GCyganek · Pull Request #79914 · Expensify/App

GCyganek · 2026-01-19T17:20:42Z

Explanation of Change

Adding ability to create GPS expenses using recorded trip data

Fixed Issues

$ #77215
PROPOSAL: N/A

Tests

Creating expense from FAB (create at least two works workspaces first with More features > Distance rates enabled and with rates with different currencies and distance units):

FAB > Track Distance > GPS tab
Track some distance and save the trip
Verify that the default expense policy is used for distance unit
Tap Next
Verify that Amount and Distance fields are not editable and that there is a dynamic map with recorded route shown
Verify that the default workspace is set as participants is selected and the correct currency and distance unit are used for Amount, Distance and Rate values
Switch participants to other workspace with different currency and distance unit
Verify that the Amount, Distance and Rate values are updated correctly
Tap Create
Make sure that the expense is created correctly and that there is no way to edit Amount and Distance
Verify that the receipt image is correct

SelfDM:

FAB > Track Distance > GPS tab
Track some distance and save the trip
Tap Next
Change participant to yourself (selfDM)
Tap Create
Make sure that the expense is created correctly

Existing report:

Create GPS distance expense from existing report (+ at the bottom > Track distance > GPS tab)
Verify that participants are automatically selected correctly and that the correct currency and distance unit is used
Verify that the created expense is correct

Split expense:

Use created GPS expense > More > Split
Test and verify that split expenses are correct

Skip confirmation:

Create a selfDM GPS expense, then FAB -> Track distance (Quick action at the bottom).
Tap Next.
Expense is created immediately (no confirmation) with correct distance & amount values set.

Creating expense from FAB without a valid default expense policy (billable actions restricted or is not a paid group policy) with user's Payment currency set to other than GBP or USD (so that the default mileage rate does not use miles as distance unit) in Preferences:

FAB > Track distance > GPS tab
Track some distance and save the trip
Tap Next
Verify that it redirects to the Choose recipient screen, select yourself (selfDM)
Verify that the distance and amount is correct
Tap Create expense
Make sure that the created expense is correct

Verify that no errors appear in the JS console

Offline tests

Make sure you are in offline mode:

Create a GPS expense through FAB
Verify that created expense is pending
Connect to the internet
Verify that the expense is created correctly

QA Steps

Same as tests and verify there are no regressions for map/manual distance expense creation flows

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-create-distance-request-workspace.mov

android-skip-confirm.mov

android-split.mov

android-existing-report.mov

android-self-dm.mov

Creating expense from FAB without a valid default expense policy (billable actions restricted or is not a paid group policy):

Screen.Recording.2026-01-23.at.12.19.39.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-19T17:20:48Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

github-actions · 2026-01-19T17:20:51Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-01-20T16:39:58Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/MoneyRequestConfirmationList.tsx	`57.48% <100.00%> (+0.66%)`	⬆️
.../components/MoneyRequestConfirmationListFooter.tsx	`84.24% <100.00%> (+0.10%)`	⬆️
...m/TransactionPreview/TransactionPreviewContent.tsx	`76.08% <100.00%> (ø)`
src/hooks/useFetchRoute.ts	`100.00% <100.00%> (ø)`
src/libs/ReportUtils.ts	`72.02% <ø> (+0.02%)`	⬆️
src/libs/shouldUseDefaultExpensePolicy.ts	`100.00% <100.00%> (ø)`
src/pages/Share/SubmitDetailsPage.tsx	`0.00% <ø> (ø)`
...tep/IOURequestStepDistanceGPS/GPSButtons/index.tsx	`0.00% <ø> (ø)`
...tup/backgroundLocationTrackingTask/index.native.ts	`6.25% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`73.41% <93.75%> (+0.23%)`	⬆️
... and 11 more
... and 5 files with indirect coverage changes

blazejkustra

Couple of questions 👀

…nt default distance unit

GCyganek · 2026-01-21T15:31:36Z

Ignore ESlint error for now, there is no error, just too many warnings as it was on the main branch 2-3days ago

blazejkustra · 2026-01-21T15:39:42Z

Ignore ESlint error for now, there is no error, just too many warnings as it was on the main branch 2-3days ago

I don't think you can ignore it, you have to ignore these warnings in the code (with eslint disables comment) or increase the limit of warnings in the check (in package.json)

GCyganek · 2026-01-21T15:48:44Z

I don't think you can ignore it, you have to ignore these warnings in the code (with eslint disables comment) or increase the limit of warnings in the check (in package.json)

yeah what I meant is that you can ignore it and I will take a look what can be done about it 😄

jakubkalinski0

A few comments/suggestions 👀 but nothing major

jakubkalinski0

LGTM 🚀

dukenv0307 · 2026-01-23T02:08:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-01-23.at.09.03.58.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-01-22.at.23.48.57.mov

Screen.Recording.2026-01-22.at.23.53.47.mov

Screen.Recording.2026-01-22.at.23.56.27.mov

Screen.Recording.2026-01-23.at.00.03.01.mov

Screen.Recording.2026-01-23.at.08.52.17.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

dukenv0307 · 2026-01-23T02:09:26Z

Hmm... could you show me logs for trackExpense request? There should be a {request, response} entry logged with Verbose setting on. I just tried selfDM a few times and it works just fine 🤔

Weird, I can't reproduce it now. Anyway, can you please fix the failed lint, then we're good to approve?

GCyganek · 2026-01-23T08:41:03Z

Weird, I can't reproduce it now.

I just checked sentry for logs and it looks like maybe a temporary backend issue? I mean, I compared your successful trackExpense request to the failing one and they look the same (barring different GPS data of course), they both have "customUnitRateID":"FAKE_P2P_ID", but for some reason backend was returning The selected rate has been deleted error for some reason. 🤔 I also checked and your 3 failing requests were the only ones failing for this reason in the last 30 days on any env for all requests

GCyganek · 2026-01-23T10:54:33Z

I just found one additional bug, working on fixing it...

GCyganek · 2026-01-23T11:42:16Z

Fixed and added a test case + demo

OSBotify · 2026-01-24T03:37:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-26T22:27:46Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.9-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…k/gps/create-gps-expenses" This reverts commit f100497, reversing changes made to 6c2f68d.

jponikarchuk · 2026-01-27T11:01:03Z

This PR failing because of the issue
This issue is reproducible in: Android and iOS app

nlemma · 2026-01-27T12:06:46Z

@GCyganek Could you confirm if this is expected. When the app is running in the background with GPS tracking, live activity appears on the dynamic island, but there is no live widget or pop-up when long pressing on the live activity. Usually, the app that shows live activity will also show live widget or pop-up when long pressed.

ScreenRecording_01-27-2026.17-05-39_1.MP4

GCyganek · 2026-01-27T13:01:16Z

@GCyganek Could you confirm if this is expected. When the app is running in the background with GPS tracking, live activity appears on the dynamic island, but there is no live widget or pop-up when long pressing on the live activity. Usually, the app that shows live activity will also show live widget or pop-up when long pressed.

It is expected that there is no live widget/pop-up as handling ios GPS tracking notification is a part of the third release of the GPS feature

OSBotify · 2026-01-27T19:47:05Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Pujan92 · 2026-02-23T15:01:50Z

    const previousValidatedWaypoints = usePrevious(validatedWaypoints);
    const haveValidatedWaypointsChanged = !deepEqual(previousValidatedWaypoints, validatedWaypoints);
-    const isMapDistanceRequest = isDistanceRequest(transaction) && !isManualDistanceRequest(transaction);
+    const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction);


This caused an issue of not showing the route for split distance request.

Create GPS expenses using captured data

7be9ce2

melvin-bot Bot assigned GCyganek Jan 19, 2026

GCyganek added 3 commits January 20, 2026 17:13

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

096842c

fix spellcheck

d00a092

Fix type error

0ee013c

GCyganek added 5 commits January 20, 2026 17:40

Replace Onyx.connect with params

2172c3f

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

357945b

Revert Mobile-Expensify hash change

561271e

do not require passing firstGpsExpenseDate param

c127bfa

Revert IOURequestStepScan changes

6999d5e

blazejkustra suggested changes Jan 21, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceGPS/index.native.tsx Outdated

Comment thread src/libs/actions/IOU/index.ts Outdated

Comment thread src/components/MoneyRequestConfirmationList.tsx Outdated

Comment thread src/libs/actions/IOU/index.ts Outdated

GCyganek added 3 commits January 21, 2026 14:57

Fix updating distance when changing between participants with differe…

ca67a3e

…nt default distance unit

GPSDraftDetailsUtils

8026c0a

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

3739020

Fix eslint warnings

327a4eb

jakubkalinski0 reviewed Jan 21, 2026

View reviewed changes

GCyganek added 2 commits January 21, 2026 23:05

Changes according to feedback

78cc508

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

183f6b1

jakubkalinski0 approved these changes Jan 21, 2026

View reviewed changes

GCyganek added 4 commits January 22, 2026 10:47

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

61a4532

Revert mobile-expensify hash change

092445e

Add allBetas

2de4064

Temporary fix to tell GPS expense from Map expense

72b96c5

GCyganek marked this pull request as ready for review January 22, 2026 11:46

GCyganek added 2 commits January 23, 2026 09:32

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

a6714b3

Typescript error fix

7c22f9d

Fix distance conversion when no default participant

9a47468

GCyganek added 4 commits January 23, 2026 13:42

revert firstCreatedGpsExpenseDateNewDot changes for now

caba976

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

8488681

ESLint fix

ab94746

Merge branch 'main' into @GCyganek/gps/create-gps-expenses

da148b2

AndrewGable approved these changes Jan 24, 2026

View reviewed changes

AndrewGable merged commit f100497 into Expensify:main Jan 24, 2026
29 checks passed

OSBotify mentioned this pull request Jan 26, 2026

Deploy Checklist: New Expensify 2026-01-26 #80540

Closed

64 tasks

OSBotify mentioned this pull request Jan 27, 2026

Report - Amount shows "0,00" and no "Pending" label on distance if expense is created offline #80577

Closed

7 tasks

lakchote added a commit that referenced this pull request Jan 27, 2026

Revert "Merge pull request #79914 from software-mansion-labs/@GCygane…

95b832c

…k/gps/create-gps-expenses" This reverts commit f100497, reversing changes made to 6c2f68d.

lakchote mentioned this pull request Jan 27, 2026

[HOLD] Revert "Merge pull request #79914 from software-mansion-labs/@GCygane… #80585

Closed

53 tasks

jponikarchuk mentioned this pull request Jan 27, 2026

Distance - App proceeds to participant list when GPS Start and Stop point are the same #80601

Closed

7 tasks

GCyganek mentioned this pull request Jan 27, 2026

[CP Staging] Run distance update for GPS transactions only #80604

Merged

54 tasks

jponikarchuk mentioned this pull request Jan 27, 2026

Quick action - Create GPS distance expense with QAB, confirmation page is displayed #80609

Closed

7 tasks

melvin-bot Bot mentioned this pull request Jan 27, 2026

[Due for payment 2026-02-03] [GPS mileage expenses][Release 1] - Add ability to use captured GPS data to create expense #77215

Closed

mitarachim mentioned this pull request Jan 28, 2026

[Due for payment 2026-02-19] Distance - Map is missing green line when splitting distance expense, confirm page is empty #80714

Closed

7 tasks

Pujan92 reviewed Feb 23, 2026

View reviewed changes

Uh oh!

Conversation

GCyganek commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 19, 2026

Uh oh!

github-actions Bot commented Jan 19, 2026

Uh oh!

codecov Bot commented Jan 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GCyganek commented Jan 21, 2026

Uh oh!

blazejkustra commented Jan 21, 2026

Uh oh!

GCyganek commented Jan 21, 2026

Uh oh!

jakubkalinski0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakubkalinski0 left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jan 23, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Jan 23, 2026

Uh oh!

GCyganek commented Jan 23, 2026

Uh oh!

GCyganek commented Jan 23, 2026

Uh oh!

GCyganek commented Jan 23, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 24, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

jponikarchuk commented Jan 27, 2026

Uh oh!

nlemma commented Jan 27, 2026

Uh oh!

GCyganek commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

Pujan92 Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

GCyganek commented Jan 19, 2026 •

edited

Loading

codecov Bot commented Jan 20, 2026 •

edited by github-actions Bot

Loading