[Due for payment 2026-02-19] Distance - Map is missing green line when splitting distance expense, confirm page is empty

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.10-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-3692/folder/13176744/41237165/1152504622, #79914
Email or phone of affected tester (no customers): applausetester+sjodijnoindjsio222@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open 1:1 DM with any user.
3. Click + > Split expense > Distance.
4. Enter Start and Stop waypoint.
5. Click Next.

Expected Result:

In Step 4, map will show a green line connecting Start and Stop waypoint.
In Step 5, Confirm page will show split and total amount and distance.

Actual Result:

In Step 4, map is missing green line.
In Step 5, Confirm page does not show split and total amount and "Pending" as Distance.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7059776_1769560176154.14.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, map is missing green line.
In Step 5, Confirm page does not show split and total amount and "Pending" as Distance.

What is the root cause of that problem?

isMapDistanceRequest is only true if the iouRequestType is distance-map

App/src/hooks/useFetchRoute.ts

Lines 28 to 30 in 04bfa3e

	const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction);
	const shouldFetchRoute = isMapDistanceRequest && (isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) && !isLoadingRoute && Object.keys(validatedWaypoints).length > 1;

For split distance, iouRequestType is distance then shouldFetchRoute is false and the route isn't fetched which causes no green line in the map

What changes do you think we should make in order to solve the problem?

We should update isMapDistanceRequest to also return true if the iouRequestType is distance.

const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction) || isDistanceTypeRequest(transaction);

App/src/hooks/useFetchRoute.ts

Lines 28 to 30 in 04bfa3e

	const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction);
	const shouldFetchRoute = isMapDistanceRequest && (isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) && !isLoadingRoute && Object.keys(validatedWaypoints).length > 1;

What alternative solutions did you explore? (Optional)

We can change the tab name here to distance-map

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 355 in 04bfa3e

<TopTab.Screen name={CONST.TAB_REQUEST.DISTANCE}>

Or we can pass newIouType here as distance-map if the newIouType is distance

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[yatin-italy]

Proposal

Restate the problem this issue is trying to solve.

When a distance expense is split, the map step does not show the green route line and the confirm step shows the distance as Pending with empty amounts. The route data from the original distance request is not available in the split transaction, so the UI cannot show the route or calculate the distance.

What is the root cause of that problem?

The earliest wrong assumption is that route data will still be available after creating a split transaction. In src/libs/actions/IOU/index.ts, function createSplitsAndOnyxData, the code assumes fastMerge(existingTransaction, splitTransaction, false) will keep the route data from the draft transaction, but it does not. The split transaction is saved in the CURRENT state, while the route was fetched and stored on the DRAFT transaction, so the split transaction ends up without routes and later code cannot find them.

What changes do you think we should make in order to solve the problem?

• Preserve route data when creating split distance transactions.

  • File: src/libs/actions/IOU/index.ts
  • Location: after the merge in createSplitsAndOnyxData

// File: src/libs/actions/IOU/index.ts (after line 6598)
// Important data is set on the draft distance transaction, such as the iouRequestType marking it as a distance request, so merge it into the optimistic split transaction
if (isDistanceRequest) {
    splitTransaction = fastMerge(existingTransaction, splitTransaction, false);
    // Ensure route data is preserved when creating split transaction
    if (existingTransaction?.routes) {
        splitTransaction.routes = existingTransaction.routes;
    }
}

• Fetch routes from the correct transaction state for split transactions.

  • File: src/pages/iou/request/step/IOURequestStepDistanceMap.tsx
  • Location: around line 121

// File: src/pages/iou/request/step/IOURequestStepDistanceMap.tsx (line 121)
const transactionState =
    transaction?.reportID === CONST.REPORT.SPLIT_REPORT_ID
        ? CONST.TRANSACTION.STATE.CURRENT
        : (shouldUseTransactionDraft(action) ? CONST.TRANSACTION.STATE.DRAFT : CONST.TRANSACTION.STATE.CURRENT);

const {shouldFetchRoute, validatedWaypoints} = useFetchRoute(
    transaction,
    waypoints,
    action,
    transactionState,
);

• Use the same correct transaction state on the confirmation step.

  • File: src/pages/iou/request/step/IOURequestStepConfirmation.tsx
  • Location: around line 304

// File: src/pages/iou/request/step/IOURequestStepConfirmation.tsx (line 304)
const transactionState =
    transaction?.reportID === CONST.REPORT.SPLIT_REPORT_ID
        ? CONST.TRANSACTION.STATE.CURRENT
        : (shouldUseTransactionDraft(action) ? CONST.TRANSACTION.STATE.DRAFT : CONST.TRANSACTION.STATE.CURRENT);

useFetchRoute(transaction, transaction?.comment?.waypoints, action, transactionState);

What alternative solutions did you explore? (Optional)

• Always refetch the route for split transactions. This was not chosen because the route already exists and refetching adds extra network work and delay.

[marufsharifi]

🚨 Edited by proposal-police: This proposal was edited at 2026-01-28 08:22:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When splitting a distance expense, the distance map step does not draw the route line, and the confirmation step shows an empty split/total with “Pending” for distance, even after entering valid start/stop waypoints.

What is the root cause of that problem?

In the split distance flow, the draft transaction is initialized with the generic request type (iouRequestType: distance) rather than a map-specific type.

The route fetcher only triggers when isMapDistanceRequest is true (which maps to iouRequestType: distance-map before save or a distance custom unit after save). Because the split draft does not satisfy that check, the hook never calls getRoute(), so transaction.routes.route0.geometry.coordinates remains empty. With no coordinates, the map cannot draw the green line and the confirmation step has no route data to derive split totals.

Flow-wise, this is what happens in the split distance path:

1. The split flow initializes a draft transaction for the distance expense with the generic type (iouRequestType: distance) rather than the map-specific type. This happens during the split distance creation in src/libs/actions/IOU/index.ts.

App/src/libs/actions/IOU/index.ts

Lines 1182 to 1189 in 04bfa3e

	const newTransaction = {
	amount: 0,
	comment,
	created,
	currency,
	category: requestCategory,
	iouRequestType: newIouRequestType,
	reportID,

2. The distance map step and the confirmation step both rely on useFetchRoute (src/hooks/useFetchRoute.ts) to request a route when waypoints are valid.
3. useFetchRoute only fetches when isMapDistanceRequest(transaction) is true. isMapDistanceRequest (src/libs/TransactionUtils/index.ts) only returns true for iouRequestType: distance-map (pre‑save) or when the saved transaction has a distance custom unit.

App/src/hooks/useFetchRoute.ts

Lines 14 to 33 in 04bfa3e

	export default function useFetchRoute(
	transaction: OnyxEntry<Transaction>,
	waypoints: WaypointCollection | undefined,
	action: IOUAction,
	transactionState: TransactionState = CONST.TRANSACTION.STATE.CURRENT,
	) {
	const {isOffline} = useNetwork();
	const hasRouteError = !!transaction?.errorFields?.route;
	const hasRoute = hasRouteTransactionUtils(transaction);
	const isRouteAbsentWithoutErrors = !hasRoute && !hasRouteError;
	const isLoadingRoute = transaction?.comment?.isLoading ?? false;
	const validatedWaypoints = getValidWaypoints(waypoints);
	const previousValidatedWaypoints = usePrevious(validatedWaypoints);
	const haveValidatedWaypointsChanged = !deepEqual(previousValidatedWaypoints, validatedWaypoints);
	const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction);
	const shouldFetchRoute = isMapDistanceRequest && (isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) && !isLoadingRoute && Object.keys(validatedWaypoints).length > 1;
	useEffect(() => {
	if (isOffline || !shouldFetchRoute || !transaction?.transactionID) {
	return;

4. Because the split draft is iouRequestType: distance, the route fetch never triggers, so no route is written into transaction.routes.route0.geometry.coordinates.
5. Without route coordinates, the map cannot draw the green line and the confirmation step has no distance/amount data to show (stays pending).

What changes do you think we should make in order to solve the problem?

Allow draft distance transactions that are still marked as the generic request type (iouRequestType: distance) to be treated as route-eligible in the fetch hook. The smallest change is in src/hooks/useFetchRoute.ts, expanding the shouldFetchRoute condition to include draft transactions with iouRequestType: distance.

Solution code .
Apply in useFetchRoute.ts hook

 const isMapDistanceRequest = isMapDistanceRequestTransactionUtils(transaction);
-const shouldFetchRoute = isMapDistanceRequest && (isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) && !isLoadingRoute && Object.keys(validatedWaypoints).length > 1;
+const isDraftGenericDistanceRequest = transactionState === CONST.TRANSACTION.STATE.DRAFT && transaction?.iouRequestType === CONST.IOU.REQUEST_TYPE.DISTANCE;
+const shouldFetchRoute =  (isMapDistanceRequest || isDraftGenericDistanceRequest) &&  (isRouteAbsentWithoutErrors || haveValidatedWaypointsChanged) &&  !isLoadingRoute &&  Object.keys(validatedWaypoints).length > 1;

What alternative solutions did you explore? (Optional)

[Pujan92]

@nkdengineer's proposal looks good here(I am more inclined towards alternative solution of using distance-map as an iouType).

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.