[CP Staging] Run distance update for GPS transactions only by GCyganek · Pull Request #80604 · Expensify/App

GCyganek · 2026-01-27T09:59:56Z

Explanation of Change

The logic responsible for distance conversion while recipients change (default distance unit) for GPS transactions was added in #79914 but not constrained to only run for GPS transactions. Fixing it here

Fixed Issues

$ #80577
PROPOSAL: N/A

Tests

Prerequisite: Account has at least one workspace.
Prerequisite 2: Distance expense previously created so waypoints can be available while offline.

Open any workspace chat.
Turn off internet connection.
Tap on "+" button and select "Track Distance"
Select "Map" and add start and finish waypoints.
Tap on "Next"
Verify that on details page the "Distance" field shows a "Pending" label.
Finish the creation flow.
Open the report of the just created expense.
Verify that the "Distance" field shows a "Pending" label.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Regressions: Verify that creating other expenses in online and offline mode does has the correct "Distance" and "Amount" fields values/labels

Run tests from #79914:

Creating expense from FAB (create at least two works workspaces first with More features > Distance rates enabled and with rates with different currencies and distance units):

FAB > Track Distance > GPS tab
Track some distance and save the trip
Verify that the default expense policy is used for distance unit
Tap Next
Verify that Amount and Distance fields are not editable and that there is a dynamic map with recorded route shown
Verify that the default workspace is set as participants is selected and the correct currency and distance unit are used for Amount, Distance and Rate values
Switch participants to other workspace with different currency and distance unit
Verify that the Amount, Distance and Rate values are updated correctly
Tap Create
Make sure that the expense is created correctly and that there is no way to edit Amount and Distance
Verify that the receipt image is correct

SelfDM:

FAB > Track Distance > GPS tab
Track some distance and save the trip
Tap Next
Change participant to yourself (selfDM)
Tap Create
Make sure that the expense is created correctly

Existing report:

Create GPS distance expense from existing report (+ at the bottom > Track distance > GPS tab)
Verify that participants are automatically selected correctly and that the correct currency and distance unit is used
Verify that the created expense is correct

Split expense:

Use created GPS expense > More > Split
Test and verify that split expenses are correct

Skip confirmation:

Create a GPS expense, then FAB -> Track distance (Quick action at the bottom).
Tap Next.
Expense is created immediately (no confirmation) with correct distance & amount values set.

Creating expense from FAB without a valid default expense policy (billable actions restricted or is not a paid group policy) with user's Payment currency set to other than GBP or USD (so that the default mileage rate does not use miles as distance unit) in Preferences:

FAB > Track distance > GPS tab
Track some distance and save the trip
Tap Next
Verify that it redirects to the Choose recipient screen, select yourself (selfDM)
Verify that the distance and amount is correct
Tap Create expense
Make sure that the created expense is correct

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-01-27.at.10.49.33.mov

melvin-bot · 2026-01-27T10:00:05Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2026-01-27T10:21:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-01-27T10:32:30Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-27T10:37:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80604.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://80604.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

lakchote

LGTM

OSBotify · 2026-01-27T11:02:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…x-update-gps-distance-for-gps-expenses-only [CP Staging] Run distance update for GPS transactions only (cherry picked from commit 68eaf86) (cherry-picked to staging by roryabraham)

OSBotify · 2026-01-27T18:47:49Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.9-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-27T19:48:44Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.9-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-27T20:13:44Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.3.10-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

lanitochka17 · 2026-01-27T20:19:32Z

This PR is failing because of issue ##80661

The issue is reproducible in: IOS

OSBotify · 2026-01-28T22:58:33Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.10-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Run distance update for GPS transactions only

4307cc6

GCyganek requested review from a team as code owners January 27, 2026 09:59

melvin-bot Bot assigned GCyganek Jan 27, 2026

melvin-bot Bot requested review from ShridharGoel and heyjennahay and removed request for a team January 27, 2026 10:00

This was referenced Jan 27, 2026

Report - Amount shows "0,00" and no "Pending" label on distance if expense is created offline #80577

Closed

[HOLD] Revert "Merge pull request #79914 from software-mansion-labs/@GCygane… #80585

Closed

lakchote changed the title ~~Run distance update for GPS transactions only~~ [CP Staging] Run distance update for GPS transactions only Jan 27, 2026

blazejkustra approved these changes Jan 27, 2026

View reviewed changes

ShridharGoel approved these changes Jan 27, 2026

View reviewed changes

melvin-bot Bot requested a review from lakchote January 27, 2026 10:44

lakchote approved these changes Jan 27, 2026

View reviewed changes

lakchote merged commit 68eaf86 into Expensify:main Jan 27, 2026
32 of 33 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jan 27, 2026

OSBotify mentioned this pull request Jan 27, 2026

Deploy Checklist: New Expensify 2026-01-26 #80540

Closed

64 tasks

lanitochka17 mentioned this pull request Jan 27, 2026

[Due for payment 2026-02-23] [GPS mileage expenses] Unit is shown incorrectly in Distance and Rate fields after switching the workspace #80661

Closed

7 tasks

Navigation Menu

Uh oh!

[CP Staging] Run distance update for GPS transactions only - #80604

[CP Staging] Run distance update for GPS transactions only#80604
lakchote merged 1 commit into
Expensify:mainfrom
software-mansion-labs:@GCyganek/gps/fix-update-gps-distance-for-gps-expenses-only

GCyganek commented Jan 27, 2026

Uh oh!

melvin-bot Bot commented Jan 27, 2026

Uh oh!

ShridharGoel commented Jan 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

lakchote left a comment

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

lanitochka17 commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

GCyganek commented Jan 27, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 27, 2026

Uh oh!

ShridharGoel commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 27, 2026

Uh oh!

lanitochka17 commented Jan 27, 2026

Uh oh!

OSBotify commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ShridharGoel commented Jan 27, 2026 •

edited

Loading