Fix: Keyboard does not open in 2FA page when returning from recovery code by tienifr · Pull Request #30620 · Expensify/App

tienifr · 2023-10-31T03:56:00Z

Details

Keyboard does not open in 2FA page when returning from recovery code. This PR fixes that.

Fixed Issues

Tests

Login with 2FA-enabled account
In 2FA entry page, press Use recovery code
Press Use two-factor authentication code
Verify that keyboard opens

Note: For Safari before version 17, keyboard does not show. Just verify that the input is focused (i.e. highlighted).

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Login with 2FA-enabled account
In 2FA entry page, press Use recovery code
Press Use two-factor authentication code
Verify that keyboard opens

Note: For Safari before version 17, keyboard does not show. Just verify that the input is focused (i.e. highlighted).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-31.at.15.49.57-compressed.mov

Android: mWeb Chrome

Screen.Recording.2023-10-31.at.16.02.17-compressed.mov

iOS: Native

Screen.Recording.2023-10-31.at.16.08.25-compressed.mov

iOS: mWeb Safari

Screen.Recording.2023-10-31.at.16.06.38-compressed.mov

MacOS: Chrome / Safari

web-compressed.mov

MacOS: Desktop

desktop-compressed.mov

melvin-bot · 2023-10-31T09:17:13Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-10-31T09:23:19Z

@akinwale I tested further and verified that my original proposal did not work. The check for props change is redundant because MagicCodeInput is already auto focused.

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 321 to 334 in deb267f

    
           <MagicCodeInput 
        
               shouldDelayFocus 
        
               autoComplete={props.autoComplete} 
        
               ref={input2FARef} 
        
               label={props.translate('common.twoFactorCode')} 
        
               name="twoFactorAuthCode" 
        
               value={twoFactorAuthCode} 
        
               onChangeText={(text) => onTextInput(text, 'twoFactorAuthCode')} 
        
               onFulfill={validateAndSubmitForm} 
        
               maxLength={CONST.TFA_CODE_LENGTH} 
        
               errorText={formError.twoFactorAuthCode ? props.translate(formError.twoFactorAuthCode) : ''} 
        
               hasError={hasError} 
        
               autoFocus 
        
           />

The problem is that there's transition animation that blocked the focus. You might notice shouldDelayFocus was already enabled in the first place but there's not such property in MagicCodeInput.

As such, all we need is to add shouldDelayFocus prop definition to MagicCodeInput and pass it to the underlying TextInput.

akinwale · 2023-11-01T12:56:36Z

@tienifr The soft keyboard does not show up in mobile Safari on iOS simulator 16.2. Please check this. Video included.

30620-ios-safari-no-soft-keyboard.mp4

tienifr · 2023-11-02T17:36:41Z

@akinwale I can't reproduce even after pulling main. Tested on Safari iOS 17.0.1.

Screen.Recording.2023-11-03.at.00.35.51-compressed.mov

akinwale · 2023-11-03T09:15:21Z

@akinwale I can't reproduce even after pulling main. Tested on Safari iOS 17.0.1.

Could you please test with Safari iOS 16.2 or 16.4? We can't assume that every user has upgraded to 17 at this point, and this will be considered a regression if we merge, since the Applause team is likely to test with iOS 16. Thanks.

tienifr · 2023-11-06T08:00:00Z

@akinwale Confimred that this does not work on Safari 16.

Screen.Recording.2023-11-06.at.12.26.21.mov

I've digged into this and found out prior to Safari 17, user need to manually press the text input to toggle keyboard. Programatic focus does not work there (i.e. use .focus()). But it's fixed in Safari 17 (reference).

I think there're no ways we can hack around that. I'll note in the PR description about this behavior.

akinwale · 2023-11-06T08:03:29Z

@akinwale Confimred that this does not work on Safari 16.

Screen.Recording.2023-11-06.at.12.26.21.mov
I've digged into this and found out prior to Safari 17, user need to manually press the text input to toggle keyboard. Programatic focus does not work there (i.e. use .focus()). But it's fixed in Safari 17 (reference).

I think there're no ways we can hack around that. I'll note in the PR description about this behavior.

Ok, thanks for testing and confirming. Is this also the same behaviour on main without the changes in this PR? If yes, then it won't be considered a regression and we can file it as a separate issue.

tienifr · 2023-11-06T08:12:54Z

Yes, this is an existing behavior on main. For Safari prior to 17, user needs to press the text input to toggle keyboard. For Safari 17, keyboard is automatically shown on focus:

Before 17	17
Screen.Recording.2023-11-06.at.15.06.56.mov	Screen.Recording.2023-11-06.at.15.10.30-compressed.mov

akinwale · 2023-11-06T08:14:32Z

@tienifr Thanks. Please fix lint issues.

akinwale · 2023-11-06T08:28:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

30620-android-native.webm

Android: mWeb Chrome

30620-android-chrome.webm

iOS: Native

30620-ios-native.mp4

iOS: mWeb Safari

30620-ios-safari.mp4

MacOS: Chrome / Safari

MacOS: Desktop

akinwale

LGTM.

Tests well.

tienifr · 2023-11-08T09:34:06Z

@bondydaa Can you check?

OSBotify · 2023-11-10T16:11:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-14T22:11:49Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:55:04Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T21:10:39Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 4 commits October 28, 2023 16:20

fix: 30281

010ad86

Merge branch 'main' into fix/30281

f1d6b28

Merge branch 'main' of https://github.com/tienifr/App into fix/30281

4bb43c9

delay focus

c377987

tienifr marked this pull request as ready for review October 31, 2023 09:17

tienifr requested a review from a team as a code owner October 31, 2023 09:17

melvin-bot Bot requested review from akinwale and removed request for a team October 31, 2023 09:17

tienifr mentioned this pull request Oct 31, 2023

[Awaiting Checklist Completion] [$500] Android - Login - Keyboard does not open in 2FA code entry page when returning from recovery code page #30281

Closed

6 tasks

delay focus by default

89fe795

revert: shouldDelayFocus by default

bcdd589

Merge branch 'main' of https://github.com/tienifr/App into fix/30281

d22477e

Merge branch 'main' of https://github.com/tienifr/App into fix/30281

a5017c3

Merge branch 'main' of https://github.com/tienifr/App into fix/30281

5a3b88e

akinwale approved these changes Nov 6, 2023

View reviewed changes

melvin-bot Bot requested a review from bondydaa November 6, 2023 08:28

Merge branch 'main' of https://github.com/tienifr/App into fix/30281

dbd0c92

bondydaa approved these changes Nov 10, 2023

View reviewed changes

bondydaa merged commit cf01854 into Expensify:main Nov 10, 2023

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

OSBotify mentioned this pull request Nov 15, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

Conversation

tienifr commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 31, 2023

Uh oh!

tienifr commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akinwale commented Nov 1, 2023

Uh oh!

tienifr commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akinwale commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akinwale commented Nov 6, 2023

Uh oh!

tienifr commented Nov 6, 2023

Uh oh!

akinwale commented Nov 6, 2023

Uh oh!

akinwale commented Nov 6, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

akinwale left a comment

Choose a reason for hiding this comment

Uh oh!

tienifr commented Nov 8, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

OSBotify commented Nov 14, 2023

Uh oh!

OSBotify commented Nov 15, 2023

Uh oh!

OSBotify commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented Oct 31, 2023 •

edited

Loading

tienifr commented Oct 31, 2023 •

edited

Loading

tienifr commented Nov 2, 2023 •

edited

Loading

akinwale commented Nov 3, 2023 •

edited

Loading

tienifr commented Nov 6, 2023 •

edited

Loading