Skip to content

Fix: Keyboard does not open in 2FA page when returning from recovery code #30620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bondydaa merged 10 commits into from
Nov 10, 2023
Merged

Fix: Keyboard does not open in 2FA page when returning from recovery code #30620

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
010ad86
fix: 30281
tienifr Oct 28, 2023
f1d6b28
Merge branch 'main' into fix/30281
tienifr Oct 30, 2023
4bb43c9
Merge branch 'main' of https://github.com/tienifr/App into fix/30281
tienifr Oct 31, 2023
c377987
delay focus
tienifr Oct 31, 2023
89fe795
delay focus by default
tienifr Oct 31, 2023
bcdd589
revert: shouldDelayFocus by default
tienifr Oct 31, 2023
d22477e
Merge branch 'main' of https://github.com/tienifr/App into fix/30281
tienifr Nov 2, 2023
a5017c3
Merge branch 'main' of https://github.com/tienifr/App into fix/30281
tienifr Nov 6, 2023
5a3b88e
Merge branch 'main' of https://github.com/tienifr/App into fix/30281
tienifr Nov 6, 2023
dbd0c92
Merge branch 'main' of https://github.com/tienifr/App into fix/30281
tienifr Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/MagicCodeInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ const propTypes = {
/** Should the input auto focus */
autoFocus: PropTypes.bool,

/** Whether we should wait before focusing the TextInput, useful when using transitions */
shouldDelayFocus: PropTypes.bool,

/** Error text to display */
errorText: PropTypes.string,

Expand Down Expand Up @@ -60,6 +63,7 @@ const defaultProps = {
value: '',
name: '',
autoFocus: true,
shouldDelayFocus: false,
errorText: '',
shouldSubmitOnComplete: true,
innerRef: null,
Expand Down Expand Up @@ -312,6 +316,7 @@ function MagicCodeInput(props) {
}}
disableKeyboard={props.isDisableKeyboard}
autoFocus={index === 0 && props.autoFocus}
shouldDelayFocus={index === 0 && props.shouldDelayFocus}
inputMode={props.isDisableKeyboard ? 'none' : 'numeric'}
textContentType="oneTimeCode"
name={props.name}
Expand Down