[Awaiting Checklist Completion] [$500] Android - Login - Keyboard does not open in 2FA code entry page when returning from recovery code page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.90-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Precondition: User has a 2FA enabled account

1. Log in with 2FA-enabled account
2. On 2FA page, click Use recovery code
3. Click Use two-factor authentication code

Expected Result:

Keyboard will open in 2FA code entry page

Actual Result:

Keyboard does not open in 2FA code entry page after returning from recovery code entry page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6249087_1698166783466.Screen_Recording_20231024_225352_New_Expensify.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ae9b2533626bd83f
• Upwork Job ID: 1716865239020941312
• Last Price Increase: 2023-10-24
• Automatic offers:
• akinwale | Reviewer | 27443661
• tienifr | Contributor | 27443663

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ae9b2533626bd83f

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard does not open in 2FA code entry page after returning from recovery code entry page

What is the root cause of that problem?

In BaseValidateCodeForm, we're not triggering focus on the code input when the isUsingRecoveryCode prop changes

What changes do you think we should make in order to solve the problem?

We should trigger focus on the code input when the isUsingRecoveryCode prop changes from true to false.
We already do the same for the requiresTwoFactorAuth prop changes here, so we can just do similarly for the isUsingRecoveryCode, since both of them are props that control the login steps.

What alternative solutions did you explore? (Optional)

NA

[twisterdotcom]

Sounds good. Can we assign @tienifr @akinwale?

[akinwale]

Sounds good. Can we assign @tienifr @akinwale?

I'll review the proposal in a couple of hours.