Show red dot on the transaction thread/ iou report row in the LHN and only for the payee by Gonals · Pull Request #27494 · Expensify/App

Gonals · 2023-09-15T06:05:33Z

Details

Fixed Issues

$ #27633
#26832
PROPOSAL:

Tests

Set up Smartscan if you haven't yet. I'd recommend clearing any existing receipts in there to make this easier.
Run bwm.sh
On newdot, create a new receipt money request from USER B by going to + -> Request Money -> Scan and sending a random image. A "Smartscanning" transaction should be created.
Wait for a bit for bwm to do its thing (you are waiting for SmartScan?receiptID=XXX).
Log into expensify.com.dev/expensiworks/
Find the receipt you just uploaded (if you cleared up the other ones, it'll be the only one!) and populate all fields except for the merchant.
Wait for another bit for bwm to do its thing
Fields should be populated in App, and the merchant set to "Unknown merchant" and with a visible error:

9. Confirm the LHN row for the iou/money request report (the one that has all the individual requests) has the red dot:

Confirm the LHN row for the transaction also has the red dot (you'll have to open the transaction if you have never done so):

Log out and log back as user B (the payer).
Open the request, all the way to the transaction and confirm you still see the error message in the empty fields, BUT, the LHN rows do not display the red dot:

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

On newdot, create a new receipt money request from USER B by going to + -> Request Money -> Scan and sending a receipt with a missing merchant. A "Smartscanning" transaction should be created.
Wait until it smartscans (can take a while)
Confirm the Money Request fields get populated correctly, with the missing merchant

Confirm the LHN row for the iou/money request report (the one that has all the individual requests) has the red dot:

Confirm the LHN row for the transaction also has the red dot (you'll have to open the transaction if you have never done so):

Log out and log back as user B (the payer).
Open the request, all the way to the transaction and confirm you still see the error message in the empty fields, BUT, the LHN rows do not display the red dot:

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-15T06:06:10Z

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

madmax330 · 2023-09-15T09:43:21Z

@Gonals can you add a C+ for review? THanks

Gonals · 2023-09-18T09:17:44Z

@Gonals can you add a C+ for review? Thanks

Created internal issue for this and added C+, but I don't think they can fully test for this, as they can't access smartscan.

@0xmiroslav, instead of waiting for smartscan, I think you can populate the fields manually, setting the merchant to Unknown Merchant. That should trigger the red dots.

0xmiroslav · 2023-09-18T09:19:21Z

@0xmiroslav, instead of waiting for smartscan, I think you can populate the fields manually, setting the merchant to Unknown Merchant. That should trigger the red dots.

Got it

Gonals · 2023-09-22T06:09:12Z

Bump @0xmiroslav !

0xmiroslav · 2023-09-22T06:10:16Z

sorry missed this. will review in a few hrs

dylanexpensify · 2023-09-22T19:17:14Z

@0xmiroslav bump on this review

0xmiroslav

ReportActionUtils..getParentReportAction, TransactionUtils.getLinkedTransaction is going to be deprecated because of this reason - Use Onyx.connect() or withOnyx() instead

Gonals · 2023-09-25T06:42:25Z

ReportActionUtils..getParentReportAction, TransactionUtils.getLinkedTransaction is going to be deprecated because of this reason - Use Onyx.connect() or withOnyx() instead

When/why are we deprecating these?

0xmiroslav · 2023-09-25T07:48:39Z

ReportActionUtils..getParentReportAction, TransactionUtils.getLinkedTransaction is going to be deprecated because of this reason - Use Onyx.connect() or withOnyx() instead

When/why are we deprecating these?

P/S posted in this master tracking issue: #27262

Gonals · 2023-09-29T07:00:52Z

Comments addressed!

0xmiroslav · 2023-10-03T13:49:22Z

I am not seeing red dot in transaction thread report row in LHN from payee side.

Gonals · 2023-10-03T14:20:21Z

I am not seeing red dot in transaction thread report row in LHN from payee side.

Huh. Does it never show up or does it just take a while?

0xmiroslav · 2023-10-03T14:22:24Z

Huh. Does it never show up or does it just take a while?

Never show up

0xmiroslav · 2023-10-11T07:50:56Z

final reviewing in an hr

0xmiroslav · 2023-10-16T11:50:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Gonals · 2023-10-17T09:46:39Z

@madmax330, I think this is ready for you, right @0xmiroslav?

Gonals · 2023-10-19T09:25:55Z

bump @madmax330

madmax330 · 2023-10-19T09:55:38Z

@0xmiroslav did not approve the request so I'm not sure if he completed the review? I'll check it out anyways

0xmiroslav · 2023-10-19T10:13:02Z

Ah sorry forgot to approve. I will retest based on latest main and approve.

0xmiroslav · 2023-10-19T10:55:22Z

@Gonals transaction detail report is not visible from LHN (if not selected) even though RBR shows.
Is this expected?
Asking because I thought report with RBR should always show in LHN

Screen.Recording.2023-10-19.at.12.50.20.PM.mov

Gonals · 2023-10-19T11:13:17Z

@Gonals transaction detail report is not visible from LHN (if not selected) even though RBR shows. Is this expected? Asking because I thought report with RBR should always show in LHN

Screen.Recording.2023-10-19.at.12.50.20.PM.mov

Yep, that's fine 👍

0xmiroslav · 2023-10-19T11:15:06Z

Before fix:

Payee

DM chat 🔴
IOU report
IOU request
Workspace chat 🔴
Expense report
Expense request

Payer

Same as Payee

After fix:

Payee

DM chat
IOU report 🔴
IOU request 🔴
Workspace chat
Expense report 🔴
Expense request 🔴

Payer

N/A

@Gonals please double check ^

Gonals · 2023-10-19T11:22:21Z

Before fix:

Payee

DM chat 🔴 IOU report IOU request Workspace chat 🔴 Expense report Expense request

Payer

Same as Payee

After fix:

Payee

DM chat IOU report 🔴 IOU request 🔴 Workspace chat Expense report 🔴 Expense request 🔴

Payer

N/A

@Gonals please double check ^

I think it should still show In-chat (not on the LHN) for the Payer. Is that no longer happening?

0xmiroslav · 2023-10-19T11:24:33Z

I think it should still show In-chat (not on the LHN) for the Payer. Is that no longer happening?

Of course shows. I asked only LHN part as this PR didn't change logic In-chat.

0xmiroslav · 2023-10-19T11:29:39Z

payee

payee.mov

payer

payer.mov

workspace owner requested money in his own workspace

owner.mov

Gonals · 2023-10-19T11:33:15Z

I think it should still show In-chat (not on the LHN) for the Payer. Is that no longer happening?

Of course shows. I asked only LHN part as this PR didn't change logic In-chat.

All good then 👍

Gonals · 2023-10-19T11:33:47Z

All yours @madmax330!

OSBotify · 2023-10-19T12:01:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-20T21:39:09Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:51:21Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Gonals added 2 commits September 15, 2023 12:50

Show RBR in Transaction row in LHN for requestor

9216799

remove unneeded imports

540b784

Gonals requested a review from a team as a code owner September 15, 2023 06:05

Gonals self-assigned this Sep 15, 2023

melvin-bot Bot requested review from madmax330 and removed request for a team September 15, 2023 06:06

lint

a324d01

Gonals changed the title ~~Show red dot on the transaction thread row in the LHN and only for the payee~~ Show red dot on the transaction thread/ iou report row in the LHN and only for the payee Sep 18, 2023

Gonals added 3 commits September 18, 2023 15:07

Merge branch 'main' into alberto-rbrFix

18514ba

Add red dot to IOU report

212718d

also request reports

349220b

Gonals requested a review from 0xmiroslav September 18, 2023 09:15

MariaHCD mentioned this pull request Sep 19, 2023

[$500] [SCAN] Dot indicator doesn't display in IOU chat (in LHN) when scanning receipt failure #27699

Closed

6 tasks

0xmiroslav reviewed Sep 22, 2023

View reviewed changes

Merge branch 'main' into alberto-rbrFix

0b7ea8f

Gonals added 2 commits September 26, 2023 15:42

Merge branch 'main' into alberto-rbrFix

3999b39

avoid deprecated methods

95af7e4

0xmiroslav approved these changes Oct 19, 2023

View reviewed changes

melvin-bot Bot requested a review from marcochavezf October 19, 2023 11:30

Gonals removed the request for review from marcochavezf October 19, 2023 11:33

Expensify deleted a comment from melvin-bot Bot Oct 19, 2023

madmax330 approved these changes Oct 19, 2023

View reviewed changes

madmax330 merged commit ef75eca into main Oct 19, 2023

madmax330 deleted the alberto-rbrFix branch October 19, 2023 11:56

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

lanitochka17 mentioned this pull request Oct 21, 2023

[$500] Scan - __ fake __ is displayed as owner of the system generated message for failed scanning #30134

Closed

6 tasks

melvin-bot Bot mentioned this pull request Oct 23, 2023

[HOLD for payment 2023-10-30] [Polish] Update RBR behavior for failed Smartscanned receipts #27633

Closed

c3024 mentioned this pull request Dec 7, 2023

[$500] Request –Red dot is not displayed in LHN as Admin if upload image of blurry receipt as employee #32524

Closed

6 tasks

bernhardoj mentioned this pull request Feb 17, 2024

[$1000] [MEDIUM] Scan - No red dot for transaction thread in LHN when scanning fails #34827

Closed

6 tasks

Conversation

Gonals commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 15, 2023

Uh oh!

madmax330 commented Sep 15, 2023

Uh oh!

Gonals commented Sep 18, 2023

Uh oh!

0xmiroslav commented Sep 18, 2023

Uh oh!

Gonals commented Sep 22, 2023

Uh oh!

0xmiroslav commented Sep 22, 2023

Uh oh!

dylanexpensify commented Sep 22, 2023

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

Gonals commented Sep 25, 2023

Uh oh!

0xmiroslav commented Sep 25, 2023

Uh oh!

Gonals commented Sep 29, 2023

Uh oh!

0xmiroslav commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gonals commented Oct 3, 2023

Uh oh!

0xmiroslav commented Oct 3, 2023

Uh oh!

0xmiroslav commented Oct 11, 2023

Uh oh!

0xmiroslav commented Oct 16, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

Gonals commented Oct 17, 2023

Uh oh!

Gonals commented Oct 19, 2023

Uh oh!

madmax330 commented Oct 19, 2023

Uh oh!

0xmiroslav commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gonals commented Oct 19, 2023

Uh oh!

0xmiroslav commented Oct 19, 2023

Before fix:

Payee

Payer

After fix:

Payee

Payer

Uh oh!

Gonals commented Oct 19, 2023

Before fix:

Payee

Payer

After fix:

Payee

Payer

Uh oh!

0xmiroslav commented Oct 19, 2023

Uh oh!

0xmiroslav commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Gonals commented Sep 15, 2023 •

edited

Loading

0xmiroslav commented Oct 3, 2023 •

edited

Loading

0xmiroslav commented Oct 19, 2023 •

edited

Loading

0xmiroslav commented Oct 19, 2023 •

edited

Loading

0xmiroslav commented Oct 19, 2023 •

edited

Loading