[$500] [SCAN] Dot indicator doesn't display in IOU chat (in LHN) when scanning receipt failure

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Request Money > Scan
3. Upload an file (not a receipt)
4. Wait until scanning ends

Expected Result:

Dot indicator should display in IOU chat (in LHN) when scanning receipt failure

Actual Result:

Dot indicator doesn't display in IOU chat (in LHN) when scanning receipt failure

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.71-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-13.at.15.32.48.mov

Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694593816318179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01961d1d18426714ce
• Upwork Job ID: 1703817596511924224
• Last Price Increase: 2023-09-18

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01961d1d18426714ce

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dot indicator doesn't display in IOU chat (in LHN) when scanning receipt failure

What is the root cause of that problem?

App/src/libs/OptionsListUtils.js

Lines 358 to 365 in 6be8fca

	} else if (ReportActionUtils.isReportPreviewAction(action)) {
	const iouReportID = ReportActionUtils.getIOUReportIDFromReportActionPreview(action);
	// Instead of adding all Smartscan errors, let's just add a generic error if there are any. This
	// will be more performant and provide the same result in the UI
	if (ReportUtils.hasMissingSmartscanFields(iouReportID)) {
	_.extend(reportActionErrors, {smartscan: ErrorUtils.getMicroSecondOnyxError('report.genericSmartscanFailureMessage')});
	}

Currently, we only apply error to reportAction that has IOU type (isReportPreviewAction is true). We don't do that to reportAction that has REPORTPREVIEW type (isReportPreviewAction is true)

What changes do you think we should make in order to solve the problem?

In getAllReportErrors function, add condition to check if isReportPreviewAction is true, we also apply error

else if (ReportActionUtils.isMoneyRequestAction(action)) {
       if (ReportUtils.hasMissingSmartscanFields(report.reportID)) {
               _.extend(reportActionErrors, {smartscan: ErrorUtils.getMicroSecondOnyxError('report.genericSmartscanFailureMessage')});
            }
  }

Result