[24476] Participants list is not hidden anymore on small screen devices. by DanutGavrus · Pull Request #26179 · Expensify/App

DanutGavrus · 2023-08-29T11:22:46Z

Details

In SplitBill, the participants list would get hidden on small screen width devices as the ScrollView was missing from the page. Added that there, and found out that it was missing from the entering amount page, so added it there too.

Fixed Issues

$ #24476
PROPOSAL: #24476 (comment)

Tests

Same as QA Steps.

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps.

QA Steps

Choose the smallest available device you have, smaller available height the better;
Click on the + icon -> click on Split bill;
Enter any amount -> click on Next;
Select at least 5 other users -> click on Next;
Click on "Show more" button;
Verify that the participants list is scrollable & that the page, except the header, is either fully visible or scrollable depending on the device's height.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Played with resizing to very small & then to large values to make sure everything works as expected.

web.mp4

Android

In the second half of the video, I've manually duplicated the 'Date' & 'Merchant' fields twice in code in order to obtain a scrollable page.

android_native.mp4

Mobile Web - Chrome

In the first half of the video, I've tested the device in horizontal orientation, which would be an extreme case(on native for example, we don't allow device rotation) and it works fine.

android_chrome.mp4

iOS

My macOS is laggy, I've done the same tests as on android/laptop for each device, but I've only added Screenshots here.

Mobile Web - Safari

Desktop

melvin-bot · 2023-08-29T11:22:51Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DanutGavrus · 2023-08-29T11:28:20Z

@eVoloshchak There's currently a bug in the MoneyRequestAmountForm which may influence the testing process of this PR. In order to avoid that, please replace textInput.current.isFocused() with textInput.current?.isFocused() in all 3 places, and textInput.current.focus() with textInput.current?.focus() in all other 3 places while testing this. Thanks!

DanutGavrus · 2023-08-29T11:31:10Z

                    ) : null}
                    <SectionList
                        ref={innerRef}
+                        nestedScrollEnabled


nestedScrollEnabled is true by default on iOS

nestedScrollEnabled is false by default on Android, and it was added in API 21 which is exactly the lowest we support right now.

nestedScrollEnabled should have no effect on browsers.

Leaving it to true as default here would put both iOS and Android on the same line, and it should have no negative effect in the application for any platform. I've looked over places where this component is used, and couldn't find any new bugs/different behaviors.

DanutGavrus · 2023-08-29T11:33:27Z


    return (
-        <>
+        <ScrollView contentContainerStyle={styles.flexGrow1}>


We need contentContainerStyle={styles.flexGrow1} because we want this page to use the whole vertically available space even if the space is larger than the page. (same behavior as seen on current staging, removing this would make the page not place the custom keyboard at the bottom of the screen).

…r-devices

DanutGavrus · 2023-08-30T14:18:31Z

@eVoloshchak PR should be ready to merge, bump for review 😁.

eVoloshchak · 2023-08-31T13:26:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-31.at.17.11.09.mov

Mobile Web - Chrome

screen-20230831-170932.mp4

Mobile Web - Safari

Screen.Recording.2023-08-31.at.17.03.47.mov

Desktop

Screen.Recording.2023-08-31.at.17.12.54.mov

iOS

Screen.Recording.2023-08-31.at.17.01.43.mov

Android

Screen.Recording.2023-08-31.at.17.37.28.mov

eVoloshchak

Looks good and tests well

OSBotify · 2023-08-31T15:00:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-31T23:17:31Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-01T23:10:05Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.61-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-09-02T14:33:31Z

+                    {/*
+                     * The MoneyRequestConfirmationList component uses a SectionList which uses a VirtualizedList internally.
+                     * VirtualizedList cannot be directly nested within ScrollViews of the same orientation.
+                     * To work around this, we wrap the MoneyRequestConfirmationList component with a horizontal ScrollView.
+                     */}
+                    <ScrollView>
+                        <ScrollView
+                            horizontal
+                            contentContainerStyle={[styles.flex1, styles.flexColumn]}
+                        >


I don't see the problem or the need for the double ScrollView. The VirtualizedList does not seem to be directly nested. Can you please double checked whether this is needed?

@s77rt It is needed because MoneyRequestConfirmationList uses SectionList. From the docs:

This is a convenience wrapper around VirtualizedList, and thus inherits its props (as well as those of ScrollView) that aren't explicitly listed here...

Running the app on iOS/Android will throw a runtime error and may also break up some functionality as seen in this video:

mobile.mp4

Ah I see you are testing with a vertical ScrollView. What I meant is to use one horizontal ScrollView. Can we use that?

My bad here. We need a vertical scrollview. Thanks for your quick responses!

Unfortunately, we can't. The horizontal prop of the child ScrollView must be removed together with the parent ScrollView, otherwise the whole page won't be scrollable.

@s77rt

Thanks for your quick responses!

No problem! Sorry for the delay, I was out of town over the weekend and just got home. I would have replied sooner if I could, sorry again!

[24476] Participants list is not hidden anymore on small screen devices.

2fc53ce

DanutGavrus requested a review from a team as a code owner August 29, 2023 11:22

melvin-bot Bot requested review from eVoloshchak and removed request for a team August 29, 2023 11:22

DanutGavrus mentioned this pull request Aug 29, 2023

[HOLD for payment 2023-09-08] [$1000] Split money- participants detail hidden after clicking on show more button #24476

Closed

1 of 6 tasks

DanutGavrus commented Aug 29, 2023

View reviewed changes

DanutGavrus closed this Aug 29, 2023

DanutGavrus deleted the fix/24476-participants-list-hidden-on-smaller-devices branch August 29, 2023 17:01

DanutGavrus restored the fix/24476-participants-list-hidden-on-smaller-devices branch August 29, 2023 17:13

DanutGavrus reopened this Aug 29, 2023

Merge branch 'main' into fix/24476-participants-list-hidden-on-smalle…

a87f0b5

…r-devices

Merged main and fixed conflicts.

145a0d1

eVoloshchak approved these changes Aug 31, 2023

View reviewed changes

melvin-bot Bot requested a review from Gonals August 31, 2023 14:39

Gonals approved these changes Aug 31, 2023

View reviewed changes

Gonals merged commit aec1c85 into Expensify:main Aug 31, 2023

namhihi237 mentioned this pull request Aug 31, 2023

[HOLD for payment 2023-09-12] Dev: Web - Request button in the wrong position #26418

Closed

1 of 6 tasks

OSBotify mentioned this pull request Aug 31, 2023

Deploy Checklist: New Expensify 2023-08-31 #26444

Closed

36 tasks done

BhuvaneshPatil mentioned this pull request Sep 1, 2023

Web - Next button while creating split bill is not at bottom #26510

Closed

1 of 6 tasks

s77rt reviewed Sep 2, 2023

View reviewed changes

s77rt mentioned this pull request Sep 2, 2023

[$500] BUG: [distance] request money button isn't bottom docked #26544

Closed

6 tasks

DanutGavrus mentioned this pull request Sep 4, 2023

Docked req money btn at the bottom. #26655

Merged

59 tasks done

Conversation

DanutGavrus commented Aug 29, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 29, 2023

Uh oh!

DanutGavrus commented Aug 29, 2023

Uh oh!

DanutGavrus Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

DanutGavrus Aug 29, 2023

Choose a reason for hiding this comment

Uh oh!

DanutGavrus commented Aug 30, 2023

Uh oh!

eVoloshchak commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

OSBotify commented Sep 1, 2023

Uh oh!

s77rt Sep 2, 2023

Choose a reason for hiding this comment

Uh oh!

DanutGavrus Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Sep 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s77rt Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

DanutGavrus Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

DanutGavrus Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

eVoloshchak commented Aug 31, 2023 •

edited

Loading

s77rt Sep 4, 2023 •

edited

Loading