[HOLD for payment 2023-09-12] Dev: Web - Request button in the wrong position

@misgana96

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the website
Click the + icon from LHN
Click request money
Enter the amount and click next
Observe the Request button from cash detail

Expected Result:

The Request button should be at the bottom

Actual Result:

The request button is in the wrong position

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.60.1
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshare.-.2023-08-31.8_24_26.PM.mp4

Expensify/Expensify Issue URL:
Issue reported by: @misgana96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693502582644489

View all open jobs on GitHub

@tjferriss

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Request button should be at the bottom

What is the root cause of that problem?

This PR introduced this issue
We didn't make it full vertically as the content wasn't enough here

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 234 to 239 in 54e6904

    
           <ScrollView> 
        
               <ScrollView 
        
                   horizontal 
        
                   contentContainerStyle={[styles.flex1, styles.flexColumn]} 
        
               > 
        
                   <MoneyRequestConfirmationList

What changes do you think we should make in order to solve the problem?

We should add flexGrow1 in ScrollView

       <ScrollView
           contentContainerStyle={[styles.flexGrow1]}
        >

What alternative solutions did you explore? (Optional)

It is reproducible in staging too for the latest version v1.3.61-2
Screencast from 01-09-2023 7:28:50 ከሰዓት.webm

Proposal

Can create a PR ASAP if required

Please re-state the problem that we are trying to solve in this issue.

Next button while creating split bill is not at bottom

What is the root cause of that problem?

Regression from #26179
Because of added ScrollView, it's not taking full height.

What changes do you think we should make in order to solve the problem?

We should make this flex grow

in MoneyRequestConfirmPage

<ScrollView contentContainerStyle={[styles.flexGrow1]}>
                        <ScrollView
                            horizontal
                            contentContainerStyle={[styles.flex1, styles.flexColumn]}
                        >

result -

What alternative solutions did you explore? (Optional)

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@tjferriss

@tjferriss Can you please close this one? We will handle this in #26544

@s77rt

@s77rt Why do we close this one? since #26544 is a dupe of #26418

@misgana96

@misgana96 No specific reason except that I'd like to work on the other issue and this one is not assigned to anyone. You'd be still the bug reporter for the other issue.

@s77rt

@s77rt Thank you for your quick response

Reviewing label has been removed, please complete the "BugZero Checklist".

@misgana96

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Docked req money btn at the bottom. #26655

If no regressions arise, payment will be issued on 2023-09-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@misgana96 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@marcaaron

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
[@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@marcaaron] Determine if we should create a regression test for this bug.
[@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The due date for the payment has passed. It was sechduled for 2023/09/12 if there is no any regression.

@marcaaron

@marcaaron @tjferriss The payment was scheduled for 2023/09/12 if there is no regression. Can you process the payment, please? It is almost 11 days since the PR was deployed to production, and I haven't received the payment for the bug reporter. Thank you

@marcaaron

@marcaaron @tjferriss still waiting for your response. It is almost 16 days since it merged in the production but payment not processed still now.

@tjferriss

Not involved in the payments system. I will reopen it so that @tjferriss can take a look though.

@tjferriss

Not involved in the payments system. I will reopen it so that @tjferriss can take a look though.

Thank you

@misgana96

@misgana96 sorry for the delay. Let's get you paid. I just sent an offer via Upworks: https://www.upwork.com/jobs/~01f0919fe7166fcdbe.

No worries. Offer accepted

@misgana96

Payment has been sent to @misgana96

Accepted. Thank you

Navigation Menu

Repository navigation

[HOLD for payment 2023-09-12] Dev: Web - Request button in the wrong position #26418

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ScrollView>
	<ScrollView
	horizontal
	contentContainerStyle={[styles.flex1, styles.flexColumn]}
	>
	<MoneyRequestConfirmationList

[HOLD for payment 2023-09-12] Dev: Web - Request button in the wrong position #26418

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 31, 2023

melvin-bot commented on Aug 31, 2023

Bug0 Triage Checklist (Main S/O)

namhihi237 commented on Aug 31, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

misgana96 commented on Sep 1, 2023

BhuvaneshPatil commented on Sep 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 1, 2023

s77rt commented on Sep 2, 2023

misgana96 commented on Sep 2, 2023

s77rt commented on Sep 2, 2023

misgana96 commented on Sep 2, 2023

13 remaining items

melvin-bot commented on Sep 5, 2023

melvin-bot commented on Sep 5, 2023

melvin-bot commented on Sep 5, 2023

misgana96 commented on Sep 13, 2023

misgana96 commented on Sep 16, 2023

misgana96 commented on Sep 22, 2023

marcaaron commented on Sep 25, 2023

misgana96 commented on Sep 25, 2023

tjferriss commented on Sep 25, 2023

misgana96 commented on Sep 25, 2023

tjferriss commented on Sep 26, 2023

misgana96 commented on Sep 26, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions