[$500] BUG: [distance] request money button isn't bottom docked

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Run App on latest main branch (for now)
Sign in with an account on the distance requests beta (or enable all betas)
Click green plus, request money, distance
Enter start and finish addresses
Click next
Select a workspace

Expected Result:

The request money button is bottom docked, meaning that it is pushed to the bottom of the screen

Actual Result:

The request money button is not bottom docked

Workaround:

Ignore it

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

Version Number: Unreleased
Reproducible in staging?: Not yet
Reproducible in production?: Not yet
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Originally reported by Tom here

Screen.Recording.2023-08-31.at.4.14.19.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify / @hayata-suenaga
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693611761287139

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e6ec526dc1626e01
Upwork Job ID: 1697758865698336768
Last Price Increase: 2023-09-08

@kevinksullivan

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~01e6ec526dc1626e01

@kevinksullivan

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

@s77rt

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

request money button isn't bottom docked

What is the root cause of that problem?

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Line 253 in 8fbe6aa

here ScrollView wrapped with twice

What changes do you think we should make in order to solve the problem?

we need remove extra ScrollView

Result :

Proposal

Please re-state the problem that we are trying to solve in this issue.

Money request confirmation page not taking full height.

What is the root cause of that problem?

We're not adding a flex: 1 property to the parent scroll view here.

Removing the ScrollView would re-introduce #24476 so we should avoid that.

What changes do you think we should make in order to solve the problem?

We need to add contentContainerStyle={[styles.flex1, styles.flexColumn]} here.

What alternative solutions did you explore? (Optional)

None

@kevinksullivan

@kevinksullivan Let's pay the bug reporter and close this

@kevinksullivan

Not overdue. @kevinksullivan ^

@s77rt

@s77rt The payment was sechdule for 2023/09/12 if thereis no any regression for the issue initial issue

@s77rt

@s77rt @kevinksullivan @hayata-suenaga this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

bug reporters were internal so there's no one to pay here.

@s77rt

@s77rt The payment was sechdule for 2023/09/12 if thereis no any regression for the issue initial issue

@kevinksullivan you make a wrong decission. I am the reporter for the bug. The internal reporter was dupe of my report initial issue @s77rt

@kevinksullivan

@kevinksullivan @s77rt please review the conversation from initial issue and will find that I am the bug reporter

@misgana96

It looks like you asked about payment on the original issue, so that'll be where we'd handle it @misgana96

@misgana96

It looks like you asked about payment on the original issue, so that'll be where we'd handle it @misgana96

The original issue is on hold for payment state that's why I asked there. It was scheduled for 23/09/12

Ok, like I said if that' the issue where you should be paid, then we'll discuss it there.

Ok, like I said if that' the issue where you should be paid, then we'll discuss it there.

Thank you

Navigation Menu

Repository navigation

[$500] BUG: [distance] request money button isn't bottom docked #26544

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

26 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$500] BUG: [distance] request money button isn't bottom docked #26544

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Sep 1, 2023

melvin-bot commented on Sep 1, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Sep 1, 2023

melvin-bot commented on Sep 1, 2023

melvin-bot commented on Sep 1, 2023

pradeepmdk commented on Sep 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

allroundexperts commented on Sep 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

26 remaining items

s77rt commented on Sep 11, 2023

s77rt commented on Sep 13, 2023

misgana96 commented on Sep 14, 2023

melvin-bot commented on Sep 15, 2023

kevinksullivan commented on Sep 15, 2023

misgana96 commented on Sep 15, 2023

misgana96 commented on Sep 15, 2023

kevinksullivan commented on Sep 21, 2023

misgana96 commented on Sep 21, 2023

kevinksullivan commented on Sep 21, 2023

misgana96 commented on Sep 21, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions