Fix: Expensify help website color code and caret icons are not updated by dukenv0307 · Pull Request #17491 · Expensify/App

dukenv0307 · 2023-04-17T05:29:25Z

Details

Expensify help website color code and caret icons are not updated

Fixed Issues

$ #17238
PROPOSAL: #17238 (comment)

Tests

Note: This case could be only tested in Web, mobile Web

Go to Expensify help web locally
Verify that LHN background color is "#07271F"
Verify that LHN border color is "#1A3D32"
Verify that LHN text selected is "#E7ECE9"
Verify that arrow-up, arrow-down, arrow-right icon using svg image
Click to Send money in LHN, select any option in Send money page
Verify that icon back-left icon using svg image

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Note: This case could be only tested in Web, mobile Web

Go to https://help.expensify.com/
Verify that LHN background color is "#07271F"
Verify that LHN border color is "#1A3D32"
Verify that LHN text selected is "#E7ECE9"
Verify that arrow-up, arrow-down, arrow-right icon using svg image
Click to Send money in LHN, select any option in Send money page
Verify that icon back-left icon using svg image

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.2023-04-19.10.13.07.mp4

Mobile Web - Chrome

Record_2023-04-19-10-13-55.mp4

Mobile Web - Safari

original-37B3A18C-F16D-4666-90E6-A3D5B786F25E.mp4

Desktop

NA

iOS

NA

Android

NA

MelvinBot · 2023-04-17T08:09:56Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

stitesExpensify · 2023-04-17T14:06:36Z

Adding @Santhosh-Sellavel as C+ since they are the C+ on the issue. Not sure why they weren't auto-assigned...

Santhosh-Sellavel · 2023-04-17T16:32:31Z

@dukenv0307 Make sure to the link issue correctly before marking the PR ready for review!

dukenv0307 · 2023-04-17T16:59:03Z

@Santhosh-Sellavel I'm sorry for that. I updated the link issue please check again

Santhosh-Sellavel · 2023-04-17T17:04:15Z

Please ensure the same on other PRs as well, because it could affect automations.

Santhosh-Sellavel · 2023-04-17T18:03:42Z

@Expensify/design Are we good here or missing any changes?

shawnborton · 2023-04-18T11:49:56Z

-        padding-left: 4px;
+
+    &.icon-left, &.icon-right, &.icon-up, &.icon-down {
+        width: 16px;


I think these should be 20px. I also think there is probably a cleaner way to do this? Let's create some kind of base icon class that uses 20px for dimensions and uses our standard icon fill color. This way we have one base class instead of needing to repeat these classes so many times.

@shawnborton for set color for icon. Actually, I set it by pass fill attr into path in svg file. If you want to use css to set color, I think we could covert our standard icon fill color to filter css. Do you have any solution to set it?

We should have a color variable for icons, if not it should be #8B9C8F

Good point about how to set these... is there any way to do it via CSS?

@shawnborton I saw that color variable for icons and I used this color to set color of svg icon. Other than filter css, I dont't know other way now.

Okay yeah, let's just keep the icons colored as they are then. Thanks!

shawnborton · 2023-04-18T11:50:41Z

Left a comment. Wow, I had no idea we were using fontawesome before but that was definitely a mistake. Can we rip out all of the other fontawesome references/styles/etc given that we don't need them anymore?

dukenv0307 · 2023-04-18T12:42:03Z

@shawnborton Do you want to me replace bars icon that's the only fontawesome icon left by svg

shawnborton · 2023-04-18T12:42:46Z

Can you show me what that looks like?

dukenv0307 · 2023-04-18T12:55:45Z

            <div id="header-button">
-                <i id="angle-up-icon" class="fa-solid fa-angle-up icon hide"></i>
+                <img src="/assets/images/arrow-up.svg" class="icon icon-up"></img>
                <i id="bars-icon" class="fa-solid fa-bars icon"></i>


@shawnborton that is bars-icon

Can you share a screenshot please?

@shawnborton bars icon in left

Ah thank you. Yeah, let's use this one instead: menu.svg.zip

@shawnborton any more problems? If temporarily not available, I'll push code to continue the review

I think this is generally looking good. Did border colors get updated too?

@shawnborton I updated border-right-color of LHN is "#1A3D32"

Cool, that is correct

shawnborton · 2023-04-18T13:31:16Z

One thing I am realizing is that it's super hard to understand the color names. Like color-super-dark-green doesn't really mean anything. I would prefer to change the names to reflect their meanings some more, like color-icons or color-highlightBG or color-appBG

Thoughts on something like that? cc @grgia as we've talked about color names before.

grgia · 2023-04-18T13:38:12Z

@shawnborton yeah let's talk about cleaning up our color naming system as part of the theme-switching project!

shawnborton · 2023-04-18T13:40:28Z

Ah yeah, good shout @grgia

Santhosh-Sellavel · 2023-04-18T14:07:49Z

+    nokogiri (1.13.10-x86_64-linux)
+      racc (~> 1.4)


Why we need this changes in this file, seems irrelevant here

Sorry I forgot restore after run in local

Santhosh-Sellavel · 2023-04-18T14:08:57Z

    </div>
    <div class="right-icon">
-        <i class="fa-solid fa-angle-right icon"></i>
+        <img src="/assets/images/arrow-right.svg" class="base-icon icon icon"></img>


class name is not correct here

Santhosh-Sellavel · 2023-04-18T14:09:28Z

+    height: 20px;
 }

+


Unnecessary Line break

@Santhosh-Sellavel I just fixed it. Please help to check again

Santhosh-Sellavel · 2023-04-18T20:46:43Z

@dukenv0307 Can you update the screens in the PR, please?

@shawnborton Are good here any other changes expected here?

shawnborton · 2023-04-18T20:50:16Z

I think we're good, will confirm once screenshots are updated.

dukenv0307 · 2023-04-19T04:09:51Z

@Santhosh-Sellavel I just updated screens in PR, please check again

shawnborton · 2023-04-20T12:58:16Z

    display: flex;
    flex-direction: column;
-    background-color: $color-super-dark-green;
+    background-color: $color-appBG;


If we give the body a correct color ($color-appBG) we might not even need this here, but I don't feel strongly.

should we remove it if give the body a correct color @shawnborton

shawnborton · 2023-04-20T12:59:40Z


    &__fine-print {
-        color: $color-gray-green;
+        color: $color-icons;


We should add a new color for this.

The color value is #AFBBB0 and we could name it something like $color-light-gray-green in colors.css

Then in main.scss, we would use $color-text-supporting: $color-light-gray-green

Let me know if that makes sense.

dukenv0307 · 2023-04-20T13:23:48Z

@shawnborton I just updated

shawnborton · 2023-04-20T13:49:21Z

Okay this feels good to me. All you @grgia @stitesExpensify @Santhosh-Sellavel

Santhosh-Sellavel · 2023-04-20T22:40:20Z

Up & Menu buttons are both shown at the same time, only one should be present at a time

Screen.Recording.2023-04-21.at.4.08.46.AM.mov

@dukenv0307

dukenv0307 · 2023-04-21T01:02:40Z

@Santhosh-Sellavel I missed class and id when change to svg. I updated, please help to check again

Santhosh-Sellavel · 2023-04-21T20:44:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-22.at.1.54.13.AM.mov

Mobile Web - Chrome

Screen_Recording_20230422_020822_Chrome.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2023-04-22.at.01.55.07.mp4

Santhosh-Sellavel · 2023-04-21T20:44:47Z

@grgia Not sure shouldn't this be internal QA?

Santhosh-Sellavel · 2023-04-21T20:47:09Z

Screen_Recording_20230422_020916_Chrome.mp4

Selection fill is a bit off in mWeb in Android, should we do something about it @shawnborton? If so let's create a new bug to handle it let me know if needs to be reported thanks!

Santhosh-Sellavel

Looks good to me tests well, thanks!

cc: @puneetlath

puneetlath

Oh interesting. Not sure why I didn't get auto-assigned to this PR.

In any case, thanks for doing all the legwork everyone! It looks good to me too. Let's wait for @shawnborton's approval though before merging.

dukenv0307 · 2023-04-22T03:56:22Z

@shawnborton please help to check again and approval the PR

dukenv0307 · 2023-04-24T05:03:30Z

@stitesExpensify Please help to check and approval the PR

Santhosh-Sellavel · 2023-04-24T13:53:46Z

Bump @shawnborton

shawnborton · 2023-04-24T14:11:16Z

Colors look good to me.

Did we ever fix the bug where both the menu icon and the caret icon show at the same time?

dukenv0307 · 2023-04-24T14:13:45Z

@shawnborton This bug is reported by @Santhosh-Sellavel and I fixed it after the report

shawnborton · 2023-04-24T14:17:10Z

Cool, all good on my end. @stitesExpensify all you!

puneetlath · 2023-04-24T14:18:12Z

Gonna go ahead and merge since we have a good amount of approvals here.

OSBotify · 2023-04-24T14:24:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-25T06:08:59Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-26T05:50:59Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 2 commits April 17, 2023 12:24

expensify help website color code and caret icons are not updated

b4f9f21

edit LHN background color

c839e16

dukenv0307 marked this pull request as ready for review April 17, 2023 08:09

dukenv0307 requested a review from a team as a code owner April 17, 2023 08:09

melvin-bot Bot requested review from stitesExpensify and removed request for a team April 17, 2023 08:09

stitesExpensify requested a review from Santhosh-Sellavel April 17, 2023 14:06

Santhosh-Sellavel reviewed Apr 17, 2023

View reviewed changes

Comment thread docs/_includes/lhn-template.html

fix weird linking compared to other linking in default.html

5f732bd

shawnborton reviewed Apr 18, 2023

View reviewed changes

dukenv0307 commented Apr 18, 2023

View reviewed changes

refactor css cleanner

c84e61e

Santhosh-Sellavel suggested changes Apr 18, 2023

View reviewed changes

dukenv0307 and others added 2 commits April 18, 2023 21:59

format code

82f03d7

Update Gemfile.lock

ae65bed

shawnborton reviewed Apr 20, 2023

View reviewed changes

add color light gray green

939d3a1

shawnborton previously approved these changes Apr 20, 2023

View reviewed changes

fix both icon display in mWeb

deacd0b

dukenv0307 dismissed shawnborton’s stale review via deacd0b April 21, 2023 01:01

grgia approved these changes Apr 21, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Apr 21, 2023

View reviewed changes

puneetlath approved these changes Apr 21, 2023

View reviewed changes

shawnborton approved these changes Apr 24, 2023

View reviewed changes

puneetlath merged commit d8622b0 into Expensify:main Apr 24, 2023

OSBotify mentioned this pull request Apr 25, 2023

Deploy Checklist: New Expensify 2023-04-25 #17948

Closed

37 tasks

kbecciv mentioned this pull request Apr 25, 2023

Help website - Color codes are not as required in PR #17995

Closed

6 tasks

Conversation

dukenv0307 commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 17, 2023

Uh oh!

stitesExpensify commented Apr 17, 2023

Uh oh!

Santhosh-Sellavel commented Apr 17, 2023

Uh oh!

dukenv0307 commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel commented Apr 17, 2023

Uh oh!

Uh oh!

Santhosh-Sellavel commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Apr 18, 2023

Uh oh!

dukenv0307 commented Apr 18, 2023

Uh oh!

shawnborton commented Apr 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Apr 18, 2023

Uh oh!

grgia commented Apr 18, 2023

Uh oh!

shawnborton commented Apr 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Apr 17, 2023 •

edited

Loading

dukenv0307 commented Apr 17, 2023 •

edited

Loading

Santhosh-Sellavel commented Apr 17, 2023 •

edited

Loading

dukenv0307 Apr 18, 2023 •

edited

Loading

dukenv0307 Apr 18, 2023 •

edited

Loading

dukenv0307 commented Apr 24, 2023 •

edited

Loading