[$1000] Expensify Help website color code and caret icons are not updated

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://help.expensify.com/

Expected Result:

LHN color, border color and text color should get updated as in ND color values

Actual Result:

Not adjusted and caret icons are also to be updated.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.98-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.193.mp4

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681136382590979

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c6ce94e5c5aaf840
• Upwork Job ID: 1645759871931166720
• Last Price Increase: 2023-04-11

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[shawnborton]

Assigning myself too to help with making sure the correct colors are chosen.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01c6ce94e5c5aaf840

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Help page's color palette is not consistent with NewDot.

What is the root cause of that problem?

1. The colors defined in _colors.scss and their usage in _main.scss is not consistent with NewDot color palette.

caret icons are also to be updated

The arrow icons in the Help site is using default font-awesome icons as can be seen here

App/docs/_includes/lhn-template.html

Line 42 in c1a2b23

<i class="fa-solid fa-angle-right icon"></i>

(the fa-angle-xxx)

What changes do you think we should make in order to solve the problem?

Here're the inconsistencies listed in the OP and the corresponding fix:
a. LHN color: currently set here, needs to be updated to the greenHighlightBackground in NewDot

App/src/styles/colors.js

Line 25 in d196a12

greenHighlightBackground: '#07271F',

b. LHN border color: currently set here, needs to be updated to the greenBorders in NewDot

App/src/styles/colors.js

Line 26 in d196a12

greenBorders: '#1A3D32',

c. Text color: page-wide should be updated to the white color in NewDot

App/src/styles/colors.js

Line 30 in d196a12

white: '#E7ECE9',

Similar updates should be done with the rest of the inconsistencies like the link hover color, ... (which are missed in the issue OP) if we want to fix it as part of this issue.

2. The arrow icons need to be updated to use <svg> tag, with our NewDot arrow svgs, for example the ArrowRight svg in NewDot here https://github.com/Expensify/App/blob/main/assets/images/arrow-right.svg.

We need to replace all instances of the fa-angle arrow icons with our svgs from NewDot, we need to do the same for other inconsistent icons if applicable as well.

What alternative solutions did you explore? (Optional)

NA