fix: follow-up #100567 by ahmedGaber93 · Pull Request #103166 · Expensify/App

ahmedGaber93 · 2026-10-06T10:48:42Z

Distance rates, per diem amounts, and card limits share this cell, and the symbol was flush against the amount for formats such as "CZK 100.00".

Explanation of Change

Fixed Issues

$ #103108
$ #103110
$ #103154
$ #103150
$ #103128
$ #103127
$ #103223
PROPOSAL:

Tests

[Due for payment 2026-10-16] Distance rate - No spacing between currency and amount when inline editing rate #103108

Precondition:

You have a workspace with a currency that has a space between the symbol and the amount, e.g. CZK or EGP
You have distance rates on

Open the App
Go to workspace settings > Distance rates
Inline edit a rate
Verify there is spacing between the currency and the amount

[Due for payment 2026-10-16] Members - Unable to inline edit role after inviting member/inviting member offline #103110

Open the App
Go to workspace settings > Members
Invite a non-existing user
Hover over the Role field
Verify the Role field can be inline edited immediately
Go offline
Invite a non-existing user
Hover over the Role field
Verify the Role field can be inline edited

[Due for payment 2026-10-16] Category - Invalid character can saved when inline editing category #103154

Open the App
Go to workspace settings > Categories
Add a category
Open the category
Click Name
Edit the name to </> and save it
Verify an invalid character error is shown and it cannot be saved
Close the RHP
Inline edit the name to </>
Verify the invalid character cannot be saved

[Due for payment 2026-10-16] Expensify Card - Bigger gap between card name and freeze card message #103150

Precondition:

You have Expensify Card enabled, and a card issued to yourself

Open the App
Go to workspace settings > Expensify Card
Freeze any card
Verify the gap between the card name and the freeze message is not bigger than on production
Verify that the Expensify card name is not editable on all rows, as we temporarily removed this feature.

[Due for payment 2026-10-16] Expensify Card - Limit type pop-over auto scrolls down when Approvals are disabled #103128

Precondition:

You have Expensify Card enabled, and a card issued to yourself
You have approvals disabled in Workflows > Approval

Open the App
Go to workspace settings > Expensify Card
Inline edit the limit type
Verify the limit type pop-over does not scroll down

[Due for payment 2026-10-16] Expensify Card - Card limit field reverts to original amount when confirmation pop-up appears #103127

Precondition:

You have Expensify Card enabled, and a card issued to yourself

Open the App
Go to workspace settings > Expensify Card
Inline edit the card limit
Enter 0 and press Enter
Verify the card limit field shows 0 when the confirmation pop-up appears

[Due for payment 2026-10-16] Distance rates - Amount flickers when entering amount during inline edit #103223

Precondition:

Enable Distance rates.

Go to workspace settings > Distance rates.
Inline edit the amount.
Clear the field quickly and re-enter the amount.
Verify amount will not flicker when entering amount.

Verify that no errors appear in the JS console

Offline tests

Same as Tests step

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests step

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-06.at.1.52.36.PM.mov

Screen.Recording.2026-10-06.at.2.02.11.PM.mov

Screen.Recording.2026-10-06.at.3.18.43.PM.mov

Screen.Recording.2026-10-06.at.1.51.31.PM.mov

Screen.Recording.2026-10-06.at.3.52.20.PM.mov

Screen.Recording.2026-10-06.at.3.45.13.PM.mov

Screen.Recording.2026-10-07.at.5.11.36.AM.mov

Distance rates, per diem amounts, and card limits share this cell, and the symbol was flush against the amount for formats such as "CZK 100.00".

codecov · 2026-10-06T10:52:12Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/AmountTextInput.tsx	`100.00% <ø> (ø)`
src/components/EditableCell/useInlineEditState.ts	`100.00% <100.00%> (ø)`
src/components/NumberWithSymbolForm.tsx	`94.35% <ø> (ø)`
...onents/Tables/WorkspaceCompanyCardsTable/index.tsx	`78.60% <ø> (ø)`
...sifyCardsTable/WorkspaceExpensifyCardsTableRow.tsx	`0.00% <ø> (ø)`
...ents/Tables/WorkspaceExpensifyCardsTable/index.tsx	`76.74% <ø> (ø)`
.../components/Tables/WorkspaceMembersTable/index.tsx	`54.54% <ø> (ø)`
...ponents/TransactionItemRow/DataCells/TotalCell.tsx	`90.76% <100.00%> (-0.28%)`	⬇️
src/libs/CardUtils.ts	`87.63% <100.00%> (+0.08%)`	⬆️
src/libs/CategoryUtils.ts	`75.59% <100.00%> (+0.39%)`	⬆️
... and 14 more
... and 456 files with indirect coverage changes

…me page.

…s it.

…age sits tight again.

… not only the amount.

melvin-bot · 2026-10-06T13:28:13Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2026-10-06T13:36:08Z

@codex review

ahmedGaber93 · 2026-10-06T13:39:19Z

The Codex review doesn’t seem to be working.

@MelvinBot please review.

MelvinBot · 2026-10-06T13:44:59Z

I reviewed the PR and found one UX issue worth fixing and one minor robustness nit. Everything else looks correct, and CI is green apart from the approval check.

1. If the user cancels the limit confirm, the modal comes back on every blur.
When the user cancels, changeCardLimit returns false (WorkspaceExpensifyCardListPage.tsx:224). keepEditing then resets hasEndedRef and puts focus back in the input (useInlineEditState.ts:79). If the user then clicks anywhere else, the input blurs and save runs. The value is still 0, so the same confirm modal opens again. To get out, the user has to press Escape or type the original limit back in. Touch users have no Escape key.

Expensify Card - Card limit field reverts to original amount when confirmation pop-up appears only asks for the typed value to stay visible while the modal is open, and isAwaitingConfirm already does that. Suggestion: when the user cancels, call closeEditing() so the field reverts. Keep return false only for callers that really need the editor to stay open.

2. Nit: the promise callbacks can use an out-of-date value.
closeEditing uses the value from the render where save ran (useInlineEditState.ts:40-43). Suppose value changes while the modal is open, for example from a Pusher update. After confirm, localValue is reset to the old value, and the prevValue check won't fix it. If the user then opens the editor and saves without typing, onSave gets that old value. Reading value from a ref in closeEditing avoids this.

Checked and fine

Categories: INVALID is already in the CategoryNameError union and handled by getCategoryNameErrorMessage, so the create and edit forms show the right error.
Members: updateWorkspaceMembersRole sends emails, not accountIDs. Removing the isOptimisticPersonalDetail check is safe for pending invites, and the request queues behind the invite.
Expensify Card: removing the name editing leaves nothing behind. updateExpensifyCardTitle is still used by DynamicExpensifyCardNamePage.
Currency spacing: hasSpaceBetweenSymbolAndAmount matches the old logic in TotalCell. Both cells use PREFIX, so pr1 is on the correct side.
Escape key: Escape is turned off while the confirm modal is open, and the second save from the modal's blur is ignored. Both behave as intended, and tests cover them.

view run

Krishna2323 · 2026-10-06T13:49:17Z

+        result.then(
+            (shouldClose) => {
+                if (shouldClose === false) {
+                    keepEditing();


After declining, the editor stays open with the typed value, so the next blur re-triggers save and reopens the same modal. Is Escape meant to be the only exit?

Fixed! After declining, we’ll cancel editing and revert to the current value.

Screen.Recording.2026-10-06.at.7.19.50.PM.mov

Fixed the editor staying open after a cancelled confirm modal on d2b6e9f.

…ne rename so they match the Name page.

Overwriting the buffer made the next blur read the edit as unchanged and drop it. The RHP forms already ignore defaultValue once the user types, so the table cells were the odd ones out. The cell catches up to the newer value once editing closes.

Krishna2323 · 2026-10-06T15:36:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

part_1.mp4

part_2.mp4

part_3.mp4

… already bails when the callback is missing.

ahmedGaber93 · 2026-10-08T06:44:23Z

heads up, I think #100567 introduced a column-width regression in the Members table: Role renders Workspace ad….

Working on it.

ahmedGaber93 · 2026-10-08T08:34:25Z

One question: editableCellEditButton is 28px and absolutely positioned over the text on hover. Should we reserve space for it too, or is the overlap intentional?

I’d keep it as is for now. It looks the same on Spend, and we already have a follow-up for inline errors and the Expensify card name. Let’s address all of these together with the design team since they’re related design decisions.

…bels no longer clip.

ahmedGaber93 · 2026-10-08T08:35:47Z

Fixed!

Screen.Recording.2026-10-08.at.11.24.36.AM.mov

Screen.Recording.2026-10-08.at.11.17.17.AM.mov

…es check no longer flags them.

JS00001

LGTM, @Krishna2323 do you want to d a final review of the new changes?

Krishna2323

Still works well!

Monosnap.screencast.2026-10-08.18-14-15.mp4

github-actions · 2026-10-08T12:53:49Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-08T12:56:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-08T12:58:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103166.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-37d34a0-b8010af-123d5f25f6cbef4d6e38516b58d7193434b22774/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-37d34a0-b8010af-a04ff8a040edbcb46cc50d4f82efdcd89befe7cc/index.html

Web 🕸️
https://103166.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-08T19:46:01Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.6-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-08T19:51:58Z

No help site update needed. This PR fixes inline-editing bugs in workspace tables, such as currency spacing, invalid-character checks, and limit pop-ups. It also removes inline card-name editing from the Expensify Card table, but no article describes that. Set up and manage the Expensify Card says to click a card to change its Card name, and that still works.

view run

OSBotify · 2026-10-09T20:31:39Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.5.6-6 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Pad inline number editors when the currency format includes a space.

fce0c02

Distance rates, per diem amounts, and card limits share this cell, and the symbol was flush against the amount for formats such as "CZK 100.00".

melvin-bot Bot assigned ahmedGaber93 Oct 6, 2026

ahmedGaber93 added 2 commits October 6, 2026 13:55

Allow inline role edits for a member whose invite is still pending.

664b99a

Reject HTML-like category names on inline rename so they match the Na…

1a9d572

…me page.

ahmedGaber93 changed the title ~~Pad inline number editors when the currency format includes a space.~~ fix: follow-up #100567 Oct 6, 2026

ahmedGaber93 added 6 commits October 6, 2026 14:35

Close the gap the card name cell adds above the freeze message.

227b1ff

Keep padding under the card name when the row has no freeze message.

8aad4ef

Stop the limit type menu from opening scrolled when approvals are off.

b0a4b49

Keep the typed card limit in the inline editor until the user confirm…

b5d86ea

…s it.

Remove inline editing from the Expensify Card name so the freeze mess…

9bd69c6

…age sits tight again.

Generalize the confirm-modal comment so it covers every inline field,…

59cbd69

… not only the amount.

ahmedGaber93 marked this pull request as ready for review October 6, 2026 13:28

ahmedGaber93 requested review from a team as code owners October 6, 2026 13:28

melvin-bot Bot requested review from JmillsExpensify and Krishna2323 and removed request for a team October 6, 2026 13:28

melvin-bot Bot removed the request for review from a team October 6, 2026 13:28

Krishna2323 reviewed Oct 6, 2026

View reviewed changes

ahmedGaber93 added 2 commits October 6, 2026 18:00

Reject HTML-like tag, card, distance rate, and per diem names on inli…

192be7b

…ne rename so they match the Name page.

Krishna2323 reviewed Oct 6, 2026

View reviewed changes

Comment thread src/components/EditableCell/useInlineEditState.ts Outdated

Drop the redundant onSave check from inline save, since the next line…

c0e478b

… already bails when the callback is missing.

Include editable cell chrome in column measurements so fit-content la…

d2567b6

…bels no longer clip.

ahmedGaber93 requested a review from Krishna2323 October 8, 2026 08:36

Inline editable cell sizes on the variables export so the unused-styl…

f9b7005

…es check no longer flags them.

JS00001 approved these changes Oct 8, 2026

View reviewed changes

Krishna2323 approved these changes Oct 8, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 October 8, 2026 12:46

JS00001 approved these changes Oct 8, 2026

View reviewed changes

JS00001 merged commit 37d34a0 into Expensify:main Oct 8, 2026
36 of 37 checks passed

OSBotify mentioned this pull request Oct 8, 2026

Deploy Checklist: New Expensify 2026-10-08 #103502

Closed

90 tasks done

This was referenced Oct 8, 2026

Keep duplicated expenses on the source report when it can accept them #103072

Open

Show the generic Control upgrade page for the Auto-pay approved reports toggle #102660

Merged

Return to the intent list from work email Back after a refresh #103532

Merged

francoisl mentioned this pull request Oct 8, 2026

[No QA] Fix ESLint errors in popover save callbacks #103540

Closed

1 of 38 tasks

MelvinBot mentioned this pull request Oct 8, 2026

Clear the merge-blocked onboarding flag when choosing Join Workspace #103537

Merged

38 tasks done

Conversation

ahmedGaber93 commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 6, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 6, 2026

Uh oh!

ahmedGaber93 commented Oct 6, 2026

Uh oh!

ahmedGaber93 commented Oct 6, 2026

Uh oh!

MelvinBot commented Oct 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Krishna2323 Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Krishna2323 commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

ahmedGaber93 commented Oct 8, 2026

Uh oh!

ahmedGaber93 commented Oct 8, 2026

Uh oh!

ahmedGaber93 commented Oct 8, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

github-actions Bot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 8, 2026

Uh oh!

MelvinBot commented Oct 8, 2026

Uh oh!

OSBotify commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ahmedGaber93 commented Oct 6, 2026 •

edited

Loading

codecov Bot commented Oct 6, 2026 •

edited by github-actions Bot

Loading

Krishna2323 commented Oct 6, 2026 •

edited

Loading