[Due for payment 2026-10-16] Distance rate - No spacing between currency and amount when inline editing rate

@ahmedGaber93

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

Version Number: 9.5.3-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100567
Email or phone of affected tester (no customers): jsdiojsdnidjos@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

Enable Distance rates.

Go to staging.new.expensify.com
Go to workspace settings > Distance rates.
Inline edit rate.

Expected Result:

There will be spacing between currency and amount when inline editing rate (similar to inline editing amount on expense report).

Actual Result:

There is no spacing between currency and amount when inline editing rate.

Workaround:

Unknown

Platforms:

Screenshots/Videos

To be added by Applause Leads

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7278339

Issue Owner

Current Issue Owner: @ahmedGaber93

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/5d480531f6f95691fbca8cecede031c2990455ad862fc3a14fff8744335c819a

You have been assigned to this deploy blocker because you recently merged this PR: #100567

@JS00001

@JS00001 @Krishna2323 you have been assigned to this deploy blocker because you reviewed the offending PR: #100567

@ahmedGaber93

@ahmedGaber93 you have been assigned to this deploy blocker because you authored the offending PR: #100567

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Deploy Blocker Analysis

Causing PR: feat: support inline editing for workspace settings tables (high confidence). It added the new InlineNumberEditCell that the distance-rate inline editor uses.

Root cause: InlineNumberEditCell passes only styles.editableCellSymbolStyle to the symbol (InlineNumberEditCell.tsx:118). The expense-report editor it was modeled on first checks whether the currency format contains a space. If so, it adds styles.pr1 (TotalCell.tsx:146-151, TotalCell.tsx:194). The new cell dropped that check.

Recommended fix (roll forward, don't revert): Move the hasSymbolSpaceInPreview logic into a shared helper in CurrencyUtils. Use it in both cells:

symbolTextStyle={[styles.editableCellSymbolStyle, hasSymbolSpace && styles.pr1]}

This also fixes the same gap in per diem amounts and Expensify Card limits, which use the same cell.

Blocker status: The bug is cosmetic and only affects admins on web. It shows only for currency/locale pairs whose format includes a space (USD in English has none). Saved values are correct. Reverting would remove inline editing from about 85 files, so a two-line fix from ahmedGaber93 is the cheaper path. Demoting is also reasonable.

Investigation details

The PR merged on 2026-10-05 and is in Deploy Checklist: New Expensify 2026-10-05, which matches 9.5.3-0 on staging only.
The PR created both InlineNumberEditCell.tsx and WorkspaceDistanceRateValueCell.tsx:22-31. In TotalCell.tsx it only changed imports. The spacing logic there came from feat: Add inline editing for tables on desktop.
Display mode uses convertAmountToDisplayString (PolicyDistanceRatesPage.tsx:318). It applies Intl formatting, so some currencies show a space, for example "CZK 0.670". Edit mode renders the symbol as a separate button with no gap before the input (BaseTextInputWithSymbol.tsx:57-64).
The tester's currency isn't visible because the issue has no screenshots. It was likely a currency whose format includes a space.
I found no existing fix PR.

view run

not a blocker, demoting

@ahmedGaber93

@ahmedGaber93 / @Krishna2323

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.6-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: follow-up #100567 #103166

If no regressions arise, payment will be issued on 2026-10-16. 🎊

The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Closing this one, fix is on prod.

Navigation Menu

Repository navigation

[Due for payment 2026-10-16] Distance rate - No spacing between currency and amount when inline editing rate #103108

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Deploy Blocker Analysis

2 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2026-10-16] Distance rate - No spacing between currency and amount when inline editing rate #103108

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

applause-bot commented on Oct 6, 2026

melvin-bot commented on Oct 6, 2026

melvin-bot commented on Oct 6, 2026

melvin-bot commented on Oct 6, 2026

melvin-bot commented on Oct 6, 2026

github-actions commented on Oct 6, 2026

MelvinBot commented on Oct 6, 2026

Deploy Blocker Analysis

2 remaining items

JS00001 commented on Oct 6, 2026

melvin-bot commented on Oct 9, 2026

Krishna2323 commented on Oct 11, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions