[No QA] Consolidated help docs: travel/booking-travel - #101945
stephanieelliott wants to merge 1 commit into
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@puneetlath @johncschuster One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| Tap the **➕ Create** button at the bottom of your screen, then choose **Book travel**. | ||
|
|
||
| You can also select **Search** (the magnifying glass icon), type **Book travel**, then select the **Book travel** result. **Book travel** appears in both places only when Expensify Travel is enabled on your active workspace. |
There was a problem hiding this comment.
Readability: This sentence is hard to scan — it repeats Book travel three times in one sentence and packs a search flow plus a conditional into a single line. Consider splitting into a short step and a separate conditional sentence, e.g. "Or select Search (the magnifying glass icon), type Book travel, then select the Book travel result." followed by a separate note that this option only appears when Expensify Travel is enabled on your active workspace.
| Tap the **➕ Create** button at the bottom of your screen, then choose **Book travel**. | ||
|
|
||
| You can also select **Search** (the magnifying glass icon), type **Book travel**, then select the **Book travel** result. **Book travel** appears in both places only when Expensify Travel is enabled on your active workspace. | ||
|
|
There was a problem hiding this comment.
Readability: The sentence repeats Book travel three times and combines a search-based navigation flow with a conditional in one line, hurting scannability. Split the search flow and the availability condition into two shorter sentences.
|
|
||
| Tap the **➕ Create** button at the bottom of your screen, then choose **Book travel**. | ||
|
|
||
| You can also select **Search** (the magnifying glass icon), type **Book travel**, then select the **Book travel** result. **Book travel** appears in both places only when Expensify Travel is enabled on your active workspace. |
There was a problem hiding this comment.
Readability: The sentence repeats Book travel three times and merges a search flow with an availability condition in one line, hurting scannability. Split the search-based navigation and the condition into two shorter sentences.
|
|
||
| Tap the **➕ Create** button at the bottom of your screen, then choose **Book travel**. | ||
|
|
||
| You can also select **Search** (the magnifying glass icon), type **Book travel**, then select the **Book travel** result. **Book travel** appears in both places only when Expensify Travel is enabled on your active workspace. |
There was a problem hiding this comment.
Readability: The sentence repeats Book travel three times and combines a search flow with a conditional in one line, reducing scannability. Split the search-based navigation and the availability condition into two shorter sentences.
| Tap the **➕ Create** button at the bottom of your screen, then choose **Book travel**. | ||
|
|
||
| You can also select **Search** (the magnifying glass icon), type **Book travel**, then select the **Book travel** result. **Book travel** appears in both places only when Expensify Travel is enabled on your active workspace. | ||
|
|
There was a problem hiding this comment.
Readability: The sentence repeats Book travel three times and merges a search flow with an availability condition in one line, hurting scannability. Split the search-based navigation and the condition into two shorter sentences.
| Tap the **➕ Create** button at the bottom of your screen, then choose **Book travel**. | ||
|
|
||
| You can also select **Search** (the magnifying glass icon), type **Book travel**, then select the **Book travel** result. **Book travel** appears in both places only when Expensify Travel is enabled on your active workspace. | ||
|
|
There was a problem hiding this comment.
Readability: The sentence repeats Book travel three times and combines a search flow with a conditional in one line, reducing scannability. Split the search-based navigation and the availability condition into two shorter sentences.
HelpDot Documentation ReviewOverall AssessmentThis PR consolidates a single upstream change (PR 100223) and adds one identical sentence to six Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65bf6f4afc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| Subproject commit 2a25b4883a6d80dc7f005605ecce914f2ada01d6 | |||
There was a problem hiding this comment.
When a workflow checks out submodules—such as .github/workflows/deploy.yml at line 44 or .github/workflows/buildAndroid.yml at line 68—Git treats this new entry as a submodule, but .gitmodules defines only Mobile-Expensify, so initialization aborts with fatal: no submodule mapping found in .gitmodules for path 'Web-Expensify'. Remove this accidental gitlink, or add a valid mapping if it is intentional, so deploy and mobile-build jobs can complete checkout.
Useful? React with 👍 / 👎.
|
Handling in the original PR |
1 participant
Summary
Consolidates 1 help doc PRs for
travel/booking-travelinto a single reviewable PR.Included PRs
Test plan