[No QA] Docs updates for E/A#99516 Book travel now available from Search - #100223
Conversation
Co-authored-by: Nabi <nabi-ebrahimi@users.noreply.github.com>
MelvinBot
added
the
HelpDot
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
|
I reviewed the documentation changes and confirmed they match the implemented behavior in #99516. @MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@marufsharifi @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -13,6 +13,8 @@ Book flights easily with Expensify Travel. This guide walks you through finding | |||
|
|
|||
| Tap the **➕ Create** button at the bottom of your screen, then choose **Book travel**. | |||
|
|
|||
There was a problem hiding this comment.
Cross-platform / deterministic consistency: The preceding step uses "Tap the ➕ Create button at the bottom of your screen" (mobile phrasing), but this added sentence uses "select Search" with the desktop-oriented "(the magnifying glass icon)". Keep the interaction verb consistent and state the platform explicitly per the Cross-Platform Clarity and Deterministic Writing rules.
HelpDot Documentation ReviewOverall AssessmentThis PR documents a new entry point: Book travel (and other actions) can now be started from Search, following #99516. It adds a task section plus two FAQ entries to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4469955f7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
…nsify/getting-started
5 participants
Explanation of Change
Help site follow-up for #99516, which surfaces Book travel in the Search Router's Create suggestions. Before that PR, Book travel could only be started from the ➕ Create button, and that is the only entry point the help site documents.
Changes:
docs/articles/new-expensify/getting-started/Navigating-New-Expensify.md— this article already documents jumping to a destination from Search, but not starting an action from it. Added a## How to start an action using Searchsection, two FAQ entries (Can I book travel from Search?andWhy don't I see Book travel in Search?), and updatedkeywords/internalScope.docs/articles/travel/booking-travel/— each carries the same## Where to find Expensify Travelblock. Added one sentence to each giving Search as a second entry point, plus the eligibility rule.Behavior documented, taken from the code in #99516:
Scope note for the reviewer: the same one-line "where to find Expensify Travel" boilerplate also appears in roughly 25 other travel articles (travel policy, company setup, managing trips, and analytics). I limited this PR to the booking articles, where the reader is actively trying to open the booking tool, to keep the diff reviewable. Say the word and I'll roll the same sentence out to the rest.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. UI labels were verified against dev NewDot on web: the entry point's accessible name is exactly Search (magnifying glass icon), and the action rows read Create expense, Create report, Track distance, Start chat, and New workspace. Book travel could not be observed directly because the test account has no Travel-enabled workspace — which matches the eligibility rule above — so its label is taken fromtravel.bookTravelinsrc/languages/en.ts(Book travel), the same string the ➕ Create button item uses.Fixed Issues
$ #92752
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR only changes help site markdown under
docs/articles.QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
AI Tests
Docs-only change (7 markdown files under
docs/articles), so no app test bundle applies.cspellandnpm run spell-changedcould not be run in this environment — no new or unusual vocabulary was introduced, but CI's spell check is the authoritative gate.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@nabi-ebrahimi, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.